ci: Post CMake-migration fixes and amendments #30841

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:240907-ci-cmake changing 2 files +13 −2
  1. hebasto commented at 1:33 pm on September 7, 2024: member

    This PR addresses the change in logging that happened in CMake 3.26.

    Additionally, the make invocation replaced with cmake --build.

    Here are examples of the CI logs:

  2. hebasto added the label Tests on Sep 7, 2024
  3. DrahtBot commented at 1:33 pm on September 7, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. ci: Handle log files regardless of CMake's version 6e5f33af58
  5. ci: Switch from `make` to `cmake --build` c45186ca54
  6. hebasto force-pushed on Sep 7, 2024
  7. DrahtBot added the label CI failed on Sep 7, 2024
  8. DrahtBot commented at 1:38 pm on September 7, 2024: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/29819480143

    Make sure to run all tests locally, according to the documentation.

    The failure may happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  9. hebasto force-pushed on Sep 8, 2024
  10. hebasto force-pushed on Sep 8, 2024
  11. hebasto marked this as ready for review on Sep 8, 2024
  12. maflcko commented at 7:05 am on September 11, 2024: member
    review ACK c45186ca548362b75a6640393ccf79b11ff727da
  13. fanquake approved
  14. fanquake commented at 8:53 am on September 12, 2024: member
    ACK c45186ca548362b75a6640393ccf79b11ff727da
  15. fanquake merged this on Sep 12, 2024
  16. fanquake closed this on Sep 12, 2024

  17. hebasto deleted the branch on Sep 12, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me