[28.x] backports and finalize #30959

1. 
   achow101 commented at 3:41 pm on September 24, 2024: member

   • #30952
   • #30962
   • Finalize 28.0 (or rc3 if additional backports are needed)
2. test: Use shell builtins in run_command test case

   Github-Pull: bitcoin/bitcoin#30952
   Rebased-From: 7bd3ee62f6d6f59ca599e85f81776d282dee1539

   e24a25d882
3. 
   DrahtBot commented at 3:41 pm on September 24, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipa
   Stale ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Backport on Sep 24, 2024
5. achow101 added this to the milestone 28.0 on Sep 24, 2024
6. achow101 renamed this:
   [28.x] Further backports
   [28.x] backports and finalize (or rc3)
   on Sep 24, 2024
7. hebasto approved
8. 
   hebasto commented at 10:49 am on September 25, 2024: member

   ACK 1f6c3caf30849a6e53957aa15c6ac27b97004dc5.

   A new backport only affects the test code, so I agree to skip the rc3 phase.

9. validation: Disable CheckForkWarningConditions for background chainstate

   The comparison of m_best_invalid with the tip of the respective chainstate
   makes no sense for the background chainstate, and can lead to incorrect
   error messages.
   
   Github-Pull: bitcoin/bitcoin#30962
   Rebased-From: c0a0c72b4d68a4f0c53c2c4b95f4d6e399f8e4ee

   7fcd7b85c6
10. build: Bump to 28.0 5feef9ce7e
11. doc: generate manpages 98745e03ff
12. achow101 force-pushed on Sep 25, 2024
13. 
    achow101 commented at 6:35 pm on September 25, 2024: member

    Added #30962

    I think it’s trivial enough to not require rc3 as well.

14. 
    stickies-v commented at 3:23 pm on September 27, 2024: contributor

    code LGTM 98745e03ffc9f69f901b827e19e4d8d645a27112

    Verified all backport commits are clean and make sense, and that I’m getting the same manpages. I think doc/release-notes.md still needs to be updated though?

15. 
    achow101 commented at 4:01 pm on September 30, 2024: member

    I think doc/release-notes.md still needs to be updated though?

    I think that’s usually done when after the release is published on the website.

16. achow101 renamed this:
    [28.x] backports and finalize (or rc3)
    [28.x] backports and finalize
    on Sep 30, 2024
17. 
    stickies-v commented at 5:07 pm on September 30, 2024: contributor

    It seems to have been the process for 26.0 and 27.0 at least:

    • https://github.com/bitcoin/bitcoin/pull/29780/files#diff-e04cb1e9f29f76897c6b84334238f621ff45ba13cf180ad1d0d442d50ebe51f7
    • https://github.com/bitcoin/bitcoin/pull/28959/files#diff-e04cb1e9f29f76897c6b84334238f621ff45ba13cf180ad1d0d442d50ebe51f7
18. 
    achow101 commented at 5:19 pm on September 30, 2024: member

    Hmm ok, will add those soon. Still some changes to be made on the release notes.
19. doc: 28.0 Release Notes 5de225f5c1
20. 
    achow101 commented at 9:14 pm on September 30, 2024: member

    Added release notes (as of eab8c9df5996bfe0d0997f747eefbdb745381aa0)
21. 
    instagibbs commented at 5:05 pm on October 1, 2024: member

    LGTM https://github.com/bitcoin/bitcoin/pull/30959/commits/5de225f5c145368f70cb5f870933bcf9df6b92c8
22. 
    sipa commented at 5:12 pm on October 1, 2024: member

    utACK 5de225f5c145368f70cb5f870933bcf9df6b92c8
23. DrahtBot requested review from hebasto on Oct 1, 2024
24. achow101 merged this on Oct 1, 2024
25. achow101 closed this on Oct 1, 2024

    ---

26. 
    glozow commented at 5:40 pm on October 1, 2024: member

    post merge ACK
27. 
    stickies-v commented at 6:38 pm on October 1, 2024: contributor

    Added release notes (as of eab8c9df5996bfe0d0997f747eefbdb745381aa0)

    Thanks! I’ve added https://github.com/bitcoin-core/bitcoin-devwiki/wiki/28.0-Release-Notes-Draft/6677e1b3aa3ecadd142786f1393d2a7affe9e03e which adds missing PR numbers.

    Release notes otherwise LGTM, I verified the author list and read through the descriptions. I think these 3 might benefit from being added to the list too, I’ll give them a go later:

    • bitcoin/bitcoin#29648
    • bitcoin/bitcoin#28981
    • bitcoin/bitcoin#28280

    Edit: oh, too late. I’m on bad wifi today, didn’t see it got merged already.

28. 
    Imebeez commented at 6:33 am on October 9, 2024: none

    N-2

Contributors
achow101 DrahtBot hebasto stickies-v instagibbs sipa glozow Imebeez

Review Requested
hebasto

Labels
Backport

Milestone
28.0