Wallet: “listreceivedby*” fix #30972

pull BrandonOdiwuor wants to merge 3 commits into bitcoin:master from BrandonOdiwuor:wallet-listreceivedby-fix changing 2 files +71 −33
  1. BrandonOdiwuor commented at 4:59 pm on September 25, 2024: contributor

    Fixes #16159,

    This PR builds on #25973, fixing listreceivedby* RPCs by filtering out send addresses using IsMine (see #25973 (review)). It also breaks down the listreceivedby tests into subtests and adds a test to verify ’listreceivedby*’ does not return send addresses

  2. DrahtBot commented at 4:59 pm on September 25, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  3. BrandonOdiwuor marked this as a draft on Sep 25, 2024
  4. DrahtBot added the label CI failed on Sep 25, 2024
  5. DrahtBot commented at 5:24 pm on September 25, 2024: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/30659059850

    Make sure to run all tests locally, according to the documentation.

    The failure may happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  6. wallet: 'Filter' out 'send' addresses from 'listreceivedby*' 1ebbc00fd8
  7. test: split 'listreceivedby' tests in subtests
    Co-authored-by: Andreas Kouloumos <kouloumosa@gmail.com>
    c4968d5147
  8. test: 'listreceivedby*' does not return send address
    Co-authored-by: Andreas Kouloumos <kouloumosa@gmail.com>
    a35115f17c
  9. BrandonOdiwuor force-pushed on Sep 26, 2024
  10. BrandonOdiwuor renamed this:
    Wallet listreceivedby fix
    Wallet: "listreceivedby*" fix
    on Sep 26, 2024
  11. BrandonOdiwuor marked this as ready for review on Sep 26, 2024
  12. DrahtBot removed the label CI failed on Sep 26, 2024
  13. DrahtBot added the label Wallet on Sep 26, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-08 07:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me