[28.x] Some backports #31104

1. 
   fanquake commented at 3:52 pm on October 16, 2024: member

   Backports:

   • #30568
   • #31007
   • #31013
   • #31016
   • #31035
   • #31166
2. doc: Archive 28.0 release notes

   Github-Pull: #31035
   Rebased-From: f019fcec4126aa2618734016711063d3b44260fc

   6643fd2145
3. 
   DrahtBot commented at 3:52 pm on October 16, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31104.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Backport on Oct 16, 2024
5. DrahtBot added the label CI failed on Oct 16, 2024
6. DrahtBot removed the label CI failed on Oct 17, 2024
7. fanquake added this to the milestone 28.1 on Oct 21, 2024
8. doc: add testnet4 section header for config file

   Github-Pull: #31007
   Rebased-From: 61cdb1c9d83778b95f4f9596f34617b7a191d0a5

   f072721181
9. test: add missing sync to feature_fee_estimation.py

   Fixes a race between node 1 catching up with the chain and mining a
   new block in the sanity_check_rbf_estimates subtest.
   
   Github-Pull: #31016
   Rebased-From: a1576edab356053c4c736691e4950b58e9a14f76

   b917334208
10. ci: add LLVM_SYMBOLIZER_PATH to Valgrind fuzz job

    Otherwise:
    ```bash
    	NEW_FUNC[1/23]: ==4710==WARNING: invalid path to external symbolizer!
    ==4710==WARNING: Failed to use and restart external symbolizer!
    0xb72010  (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a010) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)
    	NEW_FUNC[2/23]: 0xb72240  (/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0xa6a240) (BuildId: 2087ad415cb752eea259ed750f3b78a7fcb0b43b)
    
    ```
    
    Github-Pull: #30961
    Rebased-From: c1832584bfd1b352095bc41a13ff17564e456d43

    0773560abf
11. fanquake force-pushed on Oct 22, 2024
12. fanquake marked this as a draft on Oct 22, 2024
13. key: clear out secret data in `DecodeExtKey`

    Same as in `DecodeSecret`, we should also clear out the secret data from
    the vector resulting from the Base58Check parsing for xprv keys. Note
    that the if condition is needed in order to avoid UB, see #14242 (commit
    d855e4cac8303ad4e34ac31cfa7634286589ce99).
    
    Github-Pull: #31166
    Rebased-From: 559a8dd9c0aafcecf00f9ccd9aabe5720bcebe8c

    f998ac6286
14. fanquake force-pushed on Oct 31, 2024
15. depends: For mingw cross compile use -gcc-posix to prevent library conflict

    CMake parses some paths from the spec of the C compiler, assuming it
    will be the linker, resulting in the link to end up with
    `-L/usr/lib/gcc/x86_64-w64-mingw32/12-win32` on debian bookworm if both
    -win32 and -posix variants are installed, and -win32 is the default
    alternative.
    
    This results in the wrong C++ library being linked, missing
    std::threads::hardware_concurrency and other threading functions.
    
    To fix this, use the -posix variant of gcc as well when available. This
    fixes a regression compared to autotools, where this scenario worked.
    
    Github-Pull: #31013
    Rebased-From: ae56b3230b287eef5a5657d3089abebffde51484

    7fec638222
16. fanquake force-pushed on Oct 31, 2024
17. addrman, refactor: introduce user-defined type for internal nId

    This makes it easier to track which spots refer to an nId
    (as opposed to, for example, bucket index etc. which also use int)
    
    Co-authored-by: Pieter Wuille <pieter@wuille.net>
    
    Github-Pull: #30568
    Rebased-From: 051ba3290e30e210bfc50dea974063053313ad3e

    1d0411dc8f
18. addrman: change nid_type from int to int64_t

    With nId being incremented for each addr received,
    an attacker could cause an overflow in the past.
    (https://bitcoincore.org/en/2024/07/31/disclose-addrman-int-overflow/)
    Even though that attack was made infeasible by
    rate-limiting (PR #22387), to be on the safe side change the
    type to an int64_t.
    
    Github-Pull: #30568
    Rebased-From: 051ba3290e30e210bfc50dea974063053313ad3e

    4c1d74b60c
19. fanquake force-pushed on Nov 4, 2024
20. refactor: Drop deprecated space in operator""_mst

    Github-Pull: #31267
    Rebased-From: faf21625652fd0d4bbf9b86fd9ebedb5857505ea

    41c2adea9c
21. doc: clean out release-notes

    Add new notes for next rel.

    24cfce311f
22. fanquake force-pushed on Nov 11, 2024

Contributors
fanquake DrahtBot

Labels
Backport

Milestone
28.1