build: Temporarily disable compiling fuzz/utxo_snapshot.cpp with MSVC #31307

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:241117-msvc changing 1 files +4 −1
  1. hebasto commented at 4:57 pm on November 17, 2024: member

    This PR suggests a temporary workaround for a compiler bug introduced in Visual Studio 2022 version 17.12.

    This workaround is required to fix the CI until the upstream compiler bug is resolved.

  2. build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC
    Visual Studio 2022 version 17.12 introduced a bug that causes an
    internal compiler error.
    
    See: https://github.com/bitcoin/bitcoin/issues/31303.
    b2d5361002
  3. hebasto added the label Windows on Nov 17, 2024
  4. hebasto added the label Build system on Nov 17, 2024
  5. DrahtBot commented at 4:57 pm on November 17, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31307.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, TheCharlatan, brunoerg

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  6. maflcko commented at 8:15 am on November 18, 2024: member
    lgtm ACK b2d536100282bd901d3e0be7f7f4a6966e0ef817
  7. TheCharlatan approved
  8. TheCharlatan commented at 9:31 am on November 18, 2024: contributor
    ACK b2d536100282bd901d3e0be7f7f4a6966e0ef817
  9. brunoerg approved
  10. brunoerg commented at 12:54 pm on November 18, 2024: contributor
    ACK b2d536100282bd901d3e0be7f7f4a6966e0ef817
  11. fanquake commented at 3:34 pm on November 18, 2024: member
    Can you link to your upstream bug report.
  12. hebasto commented at 3:37 pm on November 18, 2024: member

    Can you link to your upstream bug report.

    I haven’t reported this upstream yet, as I’ve been struggling to create minimal reproducible code.

  13. maflcko commented at 7:12 am on November 19, 2024: member
    I’d say this is fine to merge even without an upstream report. Even if there was one, it will take some time (weeks?) to propagate the fix. Blocking the CI for this repo on that seems not ideal.
  14. fanquake commented at 10:21 am on November 19, 2024: member
    Not blocking, but we can leave #31303 open until an upstream report is filed.
  15. fanquake merged this on Nov 19, 2024
  16. fanquake closed this on Nov 19, 2024

  17. hebasto deleted the branch on Nov 19, 2024
  18. bitcoin deleted a comment on Nov 19, 2024
  19. fanquake referenced this in commit 5d6374f44f on Dec 2, 2024
  20. fanquake referenced this in commit 1025090fbe on Dec 2, 2024
  21. fanquake commented at 2:30 pm on December 2, 2024: member
    Added a commit for 28.x to #31104 to work around the same MSVC failure.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me