build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC #31307

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:241117-msvc changing 1 files +4 −1

hebasto commented at 4:57 PM on November 17, 2024: member

This PR suggests a temporary workaround for a compiler bug introduced in Visual Studio 2022 version 17.12.

This workaround is required to fix the CI until the upstream compiler bug is resolved.

build: Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC

Visual Studio 2022 version 17.12 introduced a bug that causes an
internal compiler error.

See: https://github.com/bitcoin/bitcoin/issues/31303.

b2d5361002

hebasto added the label Windows on Nov 17, 2024
hebasto added the label Build system on Nov 17, 2024
DrahtBot commented at 4:57 PM on November 17, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31307.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, TheCharlatan, brunoerg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
maflcko commented at 8:15 AM on November 18, 2024: member

lgtm ACK b2d536100282bd901d3e0be7f7f4a6966e0ef817
sedited approved
sedited commented at 9:31 AM on November 18, 2024: contributor

ACK b2d536100282bd901d3e0be7f7f4a6966e0ef817
brunoerg approved
brunoerg commented at 12:54 PM on November 18, 2024: contributor

ACK b2d536100282bd901d3e0be7f7f4a6966e0ef817
fanquake commented at 3:34 PM on November 18, 2024: member

Can you link to your upstream bug report.
hebasto commented at 3:37 PM on November 18, 2024: member

Can you link to your upstream bug report.

I haven’t reported this upstream yet, as I’ve been struggling to create minimal reproducible code.
maflcko commented at 7:12 AM on November 19, 2024: member

I'd say this is fine to merge even without an upstream report. Even if there was one, it will take some time (weeks?) to propagate the fix. Blocking the CI for this repo on that seems not ideal.
fanquake commented at 10:21 AM on November 19, 2024: member

Not blocking, but we can leave #31303 open until an upstream report is filed.
fanquake merged this on Nov 19, 2024
fanquake closed this on Nov 19, 2024
hebasto deleted the branch on Nov 19, 2024
bitcoin deleted a comment on Nov 19, 2024
fanquake referenced this in commit 5d6374f44f on Dec 2, 2024
fanquake referenced this in commit 1025090fbe on Dec 2, 2024
fanquake commented at 2:30 PM on December 2, 2024: member

Added a commit for 28.x to #31104 to work around the same MSVC failure.
sedited referenced this in commit bd64a555d7 on Dec 3, 2024
sedited referenced this in commit 15319cfcd5 on Dec 4, 2024
fanquake referenced this in commit d6b225f165 on Dec 4, 2024
stickies-v referenced this in commit f6b6da7935 on Dec 18, 2024
stickies-v referenced this in commit 6816a65596 on Dec 18, 2024
stickies-v referenced this in commit de777e8ed6 on Dec 18, 2024
bug-castercv502 referenced this in commit c87bcd9110 on Sep 28, 2025
bitcoin locked this on Dec 2, 2025