Our CMake toolchain for a Darwin cross build currently contains:
set(CMAKE_AR "/usr/bin/llvm-ar")
set(CMAKE_RANLIB "/usr/bin/llvm-ranlib")
set(CMAKE_STRIP "/usr/bin/llvm-strip")
set(CMAKE_OBJCOPY "arm64-apple-darwin-objcopy")
set(CMAKE_OBJDUMP "/usr/bin/llvm-objdump")
objcopy isn't currently used for the Darwin build (only for Linux and splitting the debug symbols), but we shouldn't be producing a toolchain file that refers to nonexistent tools.
Our CMake toolchain for a Darwin cross build currently contains:
```bash
set(CMAKE_AR "/usr/bin/llvm-ar")
set(CMAKE_RANLIB "/usr/bin/llvm-ranlib")
set(CMAKE_STRIP "/usr/bin/llvm-strip")
set(CMAKE_OBJCOPY "arm64-apple-darwin-objcopy")
set(CMAKE_OBJDUMP "/usr/bin/llvm-objdump")
```
`objcopy` isn't currently used for the Darwin build (only for Linux and
splitting the debug symbols), but we shouldn't be producing a toolchain
file that refers to nonexistent tools.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31840.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Code review ACK 3edaf0b4286a771520b7e5b0b5064eca713ff0ad
utACK 3edaf0b4286a771520b7e5b0b5064eca713ff0ad
Our CMake toolchain for a Darwin cross build currently contains:
set(CMAKE_AR "/usr/bin/llvm-ar") set(CMAKE_RANLIB "/usr/bin/llvm-ranlib") set(CMAKE_STRIP "/usr/bin/llvm-strip") set(CMAKE_OBJCOPY "arm64-apple-darwin-objcopy") set(CMAKE_OBJDUMP "/usr/bin/llvm-objdump")
objcopyisn't currently used for the Darwin build (only for Linux and splitting the debug symbols), but we shouldn't be producing a toolchain file that refers to nonexistent tools.
From CMake’s perspective, the complete toolchain for the Darwin platform additionally includes install_name_tool. It seems reasonable to reconsider 3bee51427a05075150721f0a05ead8f92e1ba019 to avoid the following hack:https://github.com/bitcoin/bitcoin/blob/c242fa5be358150d83c2446896b6f4c45c6365e9/CMakeLists.txt#L62-L66
even though it's annoying because it's not actually necessary, I don't see much harm in setting it. @fanquake ?
I'm just not sure of us having to setup/provide tools because CMake thinks they should be available, when we don't use them. iirc one of the issues with install-name-tool was that it was only available version-suffixed on certain distros (even when the main llvm install was not suffixed), making it hard to find.
This required a similar hack for #30434 as well.
This hack is only to work around other Boost/CMake issues right? (CMake wants a tool available to compile libraries just for us to throw those libraries away anyways). I'm not sure redundantly compiling things is a great argument for setting up tools we don't otherwise need.
I'm assuming there are likely other tools/programs for various toolchains that CMake might expect in some sense, that we aren't providing (or using) or ensuring are available?
even though it's annoying because it's not actually necessary, I don't see much harm in setting it. @fanquake ?
I'm just not sure of us having to setup/provide tools because CMake thinks they should be available, when we don't use them. iirc one of the issues with
install-name-toolwas that it was only available version-suffixed on certain distros (even when the main llvm install was not suffixed), making it hard to find.
Ah right, I'd forgotten that bit. Blah.
Yeah, ok, nevermind. I figured there was no harm in adding this if it was trivial, but indeed the missing prefix makes it annoying enough to treat differently.
iirc one of the issues with
install-name-toolwas that it was only available version-suffixed on certain distros (even when the main llvm install was not suffixed), making it hard to find.
If it's not too much trouble, could you recall which distros those were?
If it's not too much trouble, could you recall which distros those were?
It's still the case with Ubuntu, i.e 24.04:
# apt install llvm
# ls /usr/bin/llvm-* | grep objdump
/usr/bin/llvm-objdump
/usr/bin/llvm-objdump-18
# ls /usr/bin/llvm-* | grep install-name
/usr/bin/llvm-install-name-tool-18
.
Milestone
29.0