depends: avoid an unset `CMAKE_OBJDUMP` #31857

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:unset_objdump changing 1 files +1 −0
  1. fanquake commented at 1:07 PM on February 13, 2025: member

    Similar to #31840, currently our Linux toolchain file contains:

    set(CMAKE_AR "aarch64-linux-gnu-ar")
    set(CMAKE_RANLIB "aarch64-linux-gnu-ranlib")
    set(CMAKE_STRIP "aarch64-linux-gnu-strip")
    set(CMAKE_OBJCOPY "aarch64-linux-gnu-objcopy")
    set(CMAKE_OBJDUMP "")
    

    objdump is currently only used for the macOS cross build, where it's llvm-objdump, but we should be consistent in producing a toolchain file that points to actual tools, rather than leaving variables unset.

  2. depends: avoid an unset CMAKE_OBJDUMP
    Similar to #31840, currently our Linux toolchain file contains:
    ```bash
    set(CMAKE_AR "aarch64-linux-gnu-ar")
    set(CMAKE_RANLIB "aarch64-linux-gnu-ranlib")
    set(CMAKE_STRIP "aarch64-linux-gnu-strip")
    set(CMAKE_OBJCOPY "aarch64-linux-gnu-objcopy")
    set(CMAKE_OBJDUMP "")
    ```
    
    `objdump` is currently only used for the macOS cross build, where it's
    `llvm-objdump`, but we should be consistent in producing a toolchain
    file that points to actual tools, rather than leaving variables unset.
    2434aeab62
  3. DrahtBot commented at 1:08 PM on February 13, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31857.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, theuni

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Feb 13, 2025
  5. hebasto approved
  6. hebasto commented at 1:36 PM on February 13, 2025: member

    ACK 2434aeab62ba07c5380112838f3600b3dbbceef2.

  7. theuni approved
  8. theuni commented at 7:56 PM on February 13, 2025: member

    utACK 2434aeab62ba07c5380112838f3600b3dbbceef2

  9. fanquake merged this on Feb 14, 2025
  10. fanquake closed this on Feb 14, 2025

  11. fanquake deleted the branch on Feb 14, 2025
  12. sedited referenced this in commit f78a01a560 on Feb 22, 2025
  13. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
  14. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
  15. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
  16. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
  17. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
  18. bug-castercv502 referenced this in commit d15545ffaa on Sep 28, 2025
  19. knst referenced this in commit d354d28c21 on Oct 22, 2025
  20. tomt1664 referenced this in commit 7b38887785 on Apr 15, 2026
  21. Kino1994 referenced this in commit 2c5fac10cf on Jun 28, 2026
  22. BigcoinBGC referenced this in commit 32829e4351 on Jun 30, 2026
  23. bitcoin locked this on Jul 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-10 21:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me