depends: avoid an unset CMAKE_OBJDUMP #31857

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:unset_objdump changing 1 files +1 −0
  1. fanquake commented at 1:07 pm on February 13, 2025: member

    Similar to #31840, currently our Linux toolchain file contains:

    0set(CMAKE_AR "aarch64-linux-gnu-ar")
    1set(CMAKE_RANLIB "aarch64-linux-gnu-ranlib")
    2set(CMAKE_STRIP "aarch64-linux-gnu-strip")
    3set(CMAKE_OBJCOPY "aarch64-linux-gnu-objcopy")
    4set(CMAKE_OBJDUMP "")
    

    objdump is currently only used for the macOS cross build, where it’s llvm-objdump, but we should be consistent in producing a toolchain file that points to actual tools, rather than leaving variables unset.

  2. depends: avoid an unset CMAKE_OBJDUMP
    Similar to #31840, currently our Linux toolchain file contains:
    ```bash
    set(CMAKE_AR "aarch64-linux-gnu-ar")
    set(CMAKE_RANLIB "aarch64-linux-gnu-ranlib")
    set(CMAKE_STRIP "aarch64-linux-gnu-strip")
    set(CMAKE_OBJCOPY "aarch64-linux-gnu-objcopy")
    set(CMAKE_OBJDUMP "")
    ```
    
    `objdump` is currently only used for the macOS cross build, where it's
    `llvm-objdump`, but we should be consistent in producing a toolchain
    file that points to actual tools, rather than leaving variables unset.
    2434aeab62
  3. DrahtBot commented at 1:08 pm on February 13, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31857.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, theuni

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Feb 13, 2025
  5. hebasto approved
  6. hebasto commented at 1:36 pm on February 13, 2025: member
    ACK 2434aeab62ba07c5380112838f3600b3dbbceef2.
  7. theuni approved
  8. theuni commented at 7:56 pm on February 13, 2025: member
    utACK 2434aeab62ba07c5380112838f3600b3dbbceef2
  9. fanquake merged this on Feb 14, 2025
  10. fanquake closed this on Feb 14, 2025

  11. fanquake deleted the branch on Feb 14, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me