depends: patch around PlacementNew issue in capnp #31998

1. 
   fanquake commented at 3:13 pm on March 5, 2025: member

   See #31772 and https://github.com/capnproto/capnproto/pull/2235.

   Given there isn’t agreement in #29796, pulled this out so it could be merged separately, and it’s easier to run different test configurations externally.

   Closes #31772.

2. 
   DrahtBot commented at 3:13 pm on March 5, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31998.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	ryanofsky, TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29796 (build: align debugging flags to -O0 by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Build system on Mar 5, 2025
4. in depends/patches/capnp/abi_placement_new.patch:1 in fe283860b1 outdated

   0@@ -0,0 +1,68 @@
   1+commit 3007ac1e4a4bf80420471be45e25b3694025becd
   

   ---

   ---

   

   ryanofsky commented at 9:45 pm on March 10, 2025:

   In commit “depends: patch around PlacementNew issue in capnp” (fe283860b10709ef8e7a69269c70708cb85f47f3)

   This patch seems right but I can’t figure out how it was generated. Commit 3007ac1e4a4bf80420471be45e25b3694025becd does not seem to be a commit in the capnproto repository. The upstream patch is https://github.com/capnproto/capnproto/commit/74560f26f75dda4257dce541ca362a1e763b2971, which edits c++/src/kj/common.h and is applied with -p2 while the patch here edits src/kj/common.h and is applied with -p1.

   This all seems ok but it might be nice to use the upstream patch (can be generated with git format-patch -n1 74560f26f75dda4257dce541ca362a1e763b2971) to make the origin of the change clearer.

   ---

   

   fanquake commented at 8:13 am on March 12, 2025:

   Thanks, I’ve adjusted this to use -p2 (should have just done this in the first place rather than adjusting the paths).
5. ryanofsky approved
6. 
   ryanofsky commented at 9:50 pm on March 10, 2025: contributor

   Code review ACK fe283860b10709ef8e7a69269c70708cb85f47f3. This seems like a good change to get rid of a confusing failure that can affect debug builds and remove a complication from #29796.
7. depends: patch around PlacementNew issue in capnp

   See #31772 and https://github.com/capnproto/capnproto/pull/2235.

   1ef22ce335
8. fanquake force-pushed on Mar 12, 2025
9. ryanofsky approved
10. 
    ryanofsky commented at 3:54 pm on March 12, 2025: contributor

    Code review ACK 1ef22ce3351708bdd294d675f818880b7c93fffc. Confirmed patch is identical to one merged upstream. Only change since last review was tweaking the file paths and commit data in the patch.
11. TheCharlatan approved
12. 
    TheCharlatan commented at 4:03 pm on March 12, 2025: contributor

    ACK 1ef22ce3351708bdd294d675f818880b7c93fffc
13. fanquake merged this on Mar 13, 2025
14. fanquake closed this on Mar 13, 2025

    ---

15. fanquake deleted the branch on Mar 13, 2025

Contributors
fanquake DrahtBot ryanofsky TheCharlatan

Labels
Build system