depends: patch around PlacementNew issue in capnp #31998

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fix_multiprocess_no_opt changing 2 files +76 −0
  1. fanquake commented at 3:13 PM on March 5, 2025: member

    See #31772 and https://github.com/capnproto/capnproto/pull/2235.

    Given there isn't agreement in #29796, pulled this out so it could be merged separately, and it's easier to run different test configurations externally.

    Closes #31772.

  2. DrahtBot commented at 3:13 PM on March 5, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31998.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ryanofsky, TheCharlatan

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #29796 (build: align debugging flags to -O0 by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label Build system on Mar 5, 2025
  4. in depends/patches/capnp/abi_placement_new.patch:1 in fe283860b1 outdated 
       0 | @@ -0,0 +1,68 @@
   1 | +commit 3007ac1e4a4bf80420471be45e25b3694025becd
    ryanofsky commented at 9:45 PM on March 10, 2025:

    In commit "depends: patch around PlacementNew issue in capnp" (fe283860b10709ef8e7a69269c70708cb85f47f3)

    This patch seems right but I can't figure out how it was generated. Commit 3007ac1e4a4bf80420471be45e25b3694025becd does not seem to be a commit in the capnproto repository. The upstream patch is https://github.com/capnproto/capnproto/commit/74560f26f75dda4257dce541ca362a1e763b2971, which edits c++/src/kj/common.h and is applied with -p2 while the patch here edits src/kj/common.h and is applied with -p1.

    This all seems ok but it might be nice to use the upstream patch (can be generated with git format-patch -n1 74560f26f75dda4257dce541ca362a1e763b2971) to make the origin of the change clearer.

    fanquake commented at 8:13 AM on March 12, 2025:

    Thanks, I've adjusted this to use -p2 (should have just done this in the first place rather than adjusting the paths).

  5. ryanofsky approved
  6. ryanofsky commented at 9:50 PM on March 10, 2025: contributor

    Code review ACK fe283860b10709ef8e7a69269c70708cb85f47f3. This seems like a good change to get rid of a confusing failure that can affect debug builds and remove a complication from #29796.

  7. depends: patch around PlacementNew issue in capnp
    See #31772 and https://github.com/capnproto/capnproto/pull/2235.
    1ef22ce335
  8. fanquake force-pushed on Mar 12, 2025
  9. ryanofsky approved
  10. ryanofsky commented at 3:54 PM on March 12, 2025: contributor

    Code review ACK 1ef22ce3351708bdd294d675f818880b7c93fffc. Confirmed patch is identical to one merged upstream. Only change since last review was tweaking the file paths and commit data in the patch.

  11. sedited approved
  12. sedited commented at 4:03 PM on March 12, 2025: contributor

    ACK 1ef22ce3351708bdd294d675f818880b7c93fffc

  13. fanquake merged this on Mar 13, 2025
  14. fanquake closed this on Mar 13, 2025
  15. fanquake deleted the branch on Mar 13, 2025
  16. sedited referenced this in commit 2cab7a09ea on Mar 16, 2025
  17. stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
  18. stickies-v referenced this in commit cc83553352 on Mar 17, 2025
  19. stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
  20. stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
  21. stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
  22. bug-castercv502 referenced this in commit a6aeab1eeb on Sep 28, 2025
  23. kwvg referenced this in commit 0f8d04f1eb on Oct 24, 2025
  24. kwvg referenced this in commit 4e0fb4405a on Oct 24, 2025
  25. kwvg referenced this in commit 585b8a3d50 on Oct 24, 2025
  26. kwvg referenced this in commit d9eb950f75 on Oct 25, 2025
  27. kwvg referenced this in commit 212108320c on Oct 25, 2025
  28. kwvg referenced this in commit f1f25cd02b on Nov 4, 2025
  29. kwvg referenced this in commit 2d25a8ab28 on Nov 8, 2025
  30. kwvg referenced this in commit 3bd6182998 on Nov 12, 2025
  31. kwvg referenced this in commit 6020cdcc02 on Nov 14, 2025
  32. PastaPastaPasta referenced this in commit 9590d57aaf on Nov 14, 2025
  33. UdjinM6 referenced this in commit 3b41a910fa on Nov 18, 2025
  34. Kino1994 referenced this in commit 8386e1237f on Jun 28, 2026
  35. BigcoinBGC referenced this in commit 58610cca7c on Jun 30, 2026
  36. bitcoin locked this on Jul 30, 2026
Contributors
fanquakeDrahtBotryanofskysedited
Labels
Build system
Linked (view graph)
#29796 build: align debugging flags to `-O0`#31772 test: 32-bit Clang `ipc_test` failure at `-O0`
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-11 11:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me