Update secp256k1 subtree to latest master #32028

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:250310-secp-subtree changing 39 files +469 −398
  1. hebasto added the label Build system on Mar 10, 2025
  2. DrahtBot commented at 5:37 pm on March 10, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32028.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK Sjors

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #29491 ([EXPERIMENTAL] Schnorr batch verification for blocks by fjahr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. fanquake commented at 7:11 am on March 11, 2025: member

    The latter is required for #31507.

    If we are going to start bumping subtrees, can you at least add a PR description, given 31507 still doesn’t have one.

  4. hebasto commented at 3:29 pm on March 11, 2025: member

    The latter is required for #31507.

    If we are going to start bumping subtrees, can you at least add a PR description, given 31507 still doesn’t have one.

    My apologies. Fixed.

  5. Sjors commented at 10:28 am on March 12, 2025: member

    Concept ACK on (temporarily) using master instead of a release tag. However we should probably wait with merging this until #31507 has at least one code review ACK from a build system expert?

    ACK 7803eb4a51f3a7a7e76b4f45fb211ffa87a7e9bd

    Ran the git-subtree-check.sh check. I didn’t review the upstream changes.

    On (ARM) macOS 15.3.1 I ran a testnet4 IBD with a debug build.

  6. Squashed 'src/secp256k1/' changes from 0cdc758a56..70f149b9a1
    70f149b9a1 Merge bitcoin-core/secp256k1#1662: bench: add ellswift to bench help output
    6b3fe51fb6 bench: add ellswift to bench help output
    d84bb83e26 Merge bitcoin-core/secp256k1#1661: configure: Show exhaustive tests in summary
    3f54ed8c1b Merge bitcoin-core/secp256k1#1659: include: remove WARN_UNUSED_RESULT for functions always returning 1
    20b05c9d3f configure: Show exhaustive tests in summary
    e56716a3bc Merge bitcoin-core/secp256k1#1660: ci: Fix exiting from ci.sh on error
    d87c3bc58f ci: Fix exiting from ci.sh on error
    1b6e081538 include: remove WARN_UNUSED_RESULT for functions always returning 1
    2abb35b034 Merge bitcoin-core/secp256k1#1657: tests: remove unused uncounting_illegal_callback_fn
    51907fa918 tests: remove unused uncounting_illegal_callback_fn
    a7a5117144 Merge bitcoin-core/secp256k1#1359: Fix symbol visibility issues, add test for it
    13ed6f65dc Merge bitcoin-core/secp256k1#1593: Remove deprecated `_ec_privkey_{negate,tweak_add,tweak_mul}` aliases from API
    d1478763a5 build: Drop no longer needed  `-fvisibility=hidden` compiler option
    8ed1d83d92 ci: Run `tools/symbol-check.py`
    41d32ab2de test: Add `tools/symbol-check.py`
    88548058b3 Introduce `SECP256K1_LOCAL_VAR` macro
    03bbe8c615 Merge bitcoin-core/secp256k1#1655: gha: Print all *.log files, in a separate action
    59860bcc24 gha: Print all *.log files, in a separate action
    4ba1ba2af9 Merge bitcoin-core/secp256k1#1647: cmake: Adjust diagnostic flags for `clang-cl`
    abd25054a1 Merge bitcoin-core/secp256k1#1656: musig: Fix clearing of pubnonces
    961ec25a83 musig: Fix clearing of pubnonces
    3186082387 Merge bitcoin-core/secp256k1#1614: Add _ge_set_all_gej and use it in musig for own public nonces
    6c2a39dafb Merge bitcoin-core/secp256k1#1639: Make static context const
    37d2c60bec Remove deprecated _ec_privkey_{negate,tweak_add,tweak_mul} aliases
    432ac57705 Make static context const
    1b1fc09341 Merge bitcoin-core/secp256k1#1642: Verify `compressed` argument in `secp256k1_eckey_pubkey_serialize`
    c0d9480fbb Merge bitcoin-core/secp256k1#1654: use `EXIT_` constants over magic numbers for indicating program execution status
    13d389629a CONTRIBUTING: mention that `EXIT_` codes should be used
    c855581728 test, bench, precompute_ecmult: use `EXIT_...` constants for `main` return values
    965393fcea examples: use `EXIT_...` constants for `main` return values
    2e3bf13653 Merge bitcoin-core/secp256k1#1646: README: add instructions for verifying GPG signatures
    b682dbcf84 README: add instructions for verifying GPG signatures
    00774d0723 Merge bitcoin-core/secp256k1#1650: schnorrsig: clear out masked secret key in BIP-340 nonce function
    a82287fb85 schnorrsig: clear out masked secret key in BIP-340 nonce function
    4c50d73dd9 ci: Add new "Windows (clang-cl)" job
    84c0bd1f72 cmake: Adjust diagnostic flags for clang-cl
    f79f46c703 Merge bitcoin-core/secp256k1#1641: doc: Improve cmake instructions in README
    2ac9f558c4 doc: Improve cmake instructions in README
    1823594761 Verify `compressed` argument in `secp256k1_eckey_pubkey_serialize`
    8deef00b33 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
    39705450eb Fix some misspellings
    ec329c2501 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
    c97059f594 release cleanup: bump version after 0.6.0
    64228a648f musig: Use _ge_set_all_gej for own public nonces
    300aab1c05 tests: Improve _ge_set_all_gej(_var) tests
    365f274ce3 group: Simplify secp256k1_ge_set_all_gej
    d3082ddead group: Add constant-time secp256k1_ge_set_all_gej
    
    git-subtree-dir: src/secp256k1
    git-subtree-split: 70f149b9a1bf4ed3266f97774d0ae9577534bf40
    dd59896431
  7. Update secp256k1 subtree to latest master 0e8254fef9
  8. hebasto force-pushed on Mar 17, 2025
  9. hebasto commented at 12:25 pm on March 17, 2025: member
    Rebased and updated with the recent changes from the upstream repo.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-31 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me