Update `secp256k1` subtree to latest master

hebasto commented at 5:37 pm on March 10, 2025: member

This PR updates the secp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/4ba1ba2af953b7d124db9b80b34568e5c4a2d48a, which includes the following changes:

https://github.com/bitcoin-core/secp256k1/pull/1647 is required for #31507.

hebasto added the label Build system on Mar 10, 2025

DrahtBot commented at 5:37 pm on March 10, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32028.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#29491 ([EXPERIMENTAL] Schnorr batch verification for blocks by fjahr)
#28201 (Silent Payments: sending by josibake)
#28122 (Silent Payments: Implement BIP352 by josibake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake commented at 7:11 am on March 11, 2025: member

The latter is required for #31507.

If we are going to start bumping subtrees, can you at least add a PR description, given 31507 still doesn’t have one.

hebasto commented at 3:29 pm on March 11, 2025: member

The latter is required for #31507.

If we are going to start bumping subtrees, can you at least add a PR description, given 31507 still doesn’t have one.

My apologies. Fixed.

Sjors commented at 10:28 am on March 12, 2025: member

Concept ACK on (temporarily) using master instead of a release tag. However we should probably wait with merging this until #31507 has at least one code review ACK from a build system expert?

ACK 7803eb4a51f3a7a7e76b4f45fb211ffa87a7e9bd

Ran the git-subtree-check.sh check. I didn’t review the upstream changes.

On (ARM) macOS 15.3.1 I ran a testnet4 IBD with a debug build.

Squashed 'src/secp256k1/' changes from 0cdc758a56..70f149b9a1

70f149b9a1 Merge bitcoin-core/secp256k1#1662: bench: add ellswift to bench help output
6b3fe51fb6 bench: add ellswift to bench help output
d84bb83e26 Merge bitcoin-core/secp256k1#1661: configure: Show exhaustive tests in summary
3f54ed8c1b Merge bitcoin-core/secp256k1#1659: include: remove WARN_UNUSED_RESULT for functions always returning 1
20b05c9d3f configure: Show exhaustive tests in summary
e56716a3bc Merge bitcoin-core/secp256k1#1660: ci: Fix exiting from ci.sh on error
d87c3bc58f ci: Fix exiting from ci.sh on error
1b6e081538 include: remove WARN_UNUSED_RESULT for functions always returning 1
2abb35b034 Merge bitcoin-core/secp256k1#1657: tests: remove unused uncounting_illegal_callback_fn
51907fa918 tests: remove unused uncounting_illegal_callback_fn
a7a5117144 Merge bitcoin-core/secp256k1#1359: Fix symbol visibility issues, add test for it
13ed6f65dc Merge bitcoin-core/secp256k1#1593: Remove deprecated `_ec_privkey_{negate,tweak_add,tweak_mul}` aliases from API
d1478763a5 build: Drop no longer needed  `-fvisibility=hidden` compiler option
8ed1d83d92 ci: Run `tools/symbol-check.py`
41d32ab2de test: Add `tools/symbol-check.py`
88548058b3 Introduce `SECP256K1_LOCAL_VAR` macro
03bbe8c615 Merge bitcoin-core/secp256k1#1655: gha: Print all *.log files, in a separate action
59860bcc24 gha: Print all *.log files, in a separate action
4ba1ba2af9 Merge bitcoin-core/secp256k1#1647: cmake: Adjust diagnostic flags for `clang-cl`
abd25054a1 Merge bitcoin-core/secp256k1#1656: musig: Fix clearing of pubnonces
961ec25a83 musig: Fix clearing of pubnonces
3186082387 Merge bitcoin-core/secp256k1#1614: Add _ge_set_all_gej and use it in musig for own public nonces
6c2a39dafb Merge bitcoin-core/secp256k1#1639: Make static context const
37d2c60bec Remove deprecated _ec_privkey_{negate,tweak_add,tweak_mul} aliases
432ac57705 Make static context const
1b1fc09341 Merge bitcoin-core/secp256k1#1642: Verify `compressed` argument in `secp256k1_eckey_pubkey_serialize`
c0d9480fbb Merge bitcoin-core/secp256k1#1654: use `EXIT_` constants over magic numbers for indicating program execution status
13d389629a CONTRIBUTING: mention that `EXIT_` codes should be used
c855581728 test, bench, precompute_ecmult: use `EXIT_...` constants for `main` return values
965393fcea examples: use `EXIT_...` constants for `main` return values
2e3bf13653 Merge bitcoin-core/secp256k1#1646: README: add instructions for verifying GPG signatures
b682dbcf84 README: add instructions for verifying GPG signatures
00774d0723 Merge bitcoin-core/secp256k1#1650: schnorrsig: clear out masked secret key in BIP-340 nonce function
a82287fb85 schnorrsig: clear out masked secret key in BIP-340 nonce function
4c50d73dd9 ci: Add new "Windows (clang-cl)" job
84c0bd1f72 cmake: Adjust diagnostic flags for clang-cl
f79f46c703 Merge bitcoin-core/secp256k1#1641: doc: Improve cmake instructions in README
2ac9f558c4 doc: Improve cmake instructions in README
1823594761 Verify `compressed` argument in `secp256k1_eckey_pubkey_serialize`
8deef00b33 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
39705450eb Fix some misspellings
ec329c2501 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
c97059f594 release cleanup: bump version after 0.6.0
64228a648f musig: Use _ge_set_all_gej for own public nonces
300aab1c05 tests: Improve _ge_set_all_gej(_var) tests
365f274ce3 group: Simplify secp256k1_ge_set_all_gej
d3082ddead group: Add constant-time secp256k1_ge_set_all_gej

git-subtree-dir: src/secp256k1
git-subtree-split: 70f149b9a1bf4ed3266f97774d0ae9577534bf40

dd59896431

Update secp256k1 subtree to latest master 0e8254fef9

hebasto force-pushed on Mar 17, 2025

hebasto commented at 12:25 pm on March 17, 2025: member

Rebased and updated with the recent changes from the upstream repo.

maflcko added the label DrahtBot Guix build requested on Apr 16, 2025

DrahtBot commented at 12:08 pm on April 20, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit d91a746815e4428c738f1a096a950292cbdb5469(master)	commit 7d6fb6351d0e9435dd96f0bbb0e0fa4b842e7d59(pull/32028/merge)
*-aarch64-linux-gnu-debug.tar.gz	`2110c9d6963c9c61...`	`9d8462b17d042813...`
*-aarch64-linux-gnu.tar.gz	`dbb660c817c639e1...`	`85582e98ed0951e4...`
*-arm-linux-gnueabihf-debug.tar.gz	`ac8336f21d087a0b...`	`14045d0878a2ab00...`
*-arm-linux-gnueabihf.tar.gz	`bb9c16d16af758b4...`	`1829c07022ae53a7...`
*-arm64-apple-darwin-codesigning.tar.gz	`b1f7376f5a76be17...`	`9e1b948bbb081fe9...`
*-arm64-apple-darwin-unsigned.tar.gz	`76b73d4ad051154f...`	`0ae84736eef74b20...`
*-arm64-apple-darwin-unsigned.zip	`714ab6c2ec0b666c...`	`cbb942f0bcdafd4c...`
*-powerpc64-linux-gnu-debug.tar.gz	`a1c3361a3648d343...`	`3637a5cbc58b1579...`
*-powerpc64-linux-gnu.tar.gz	`1972c6a33c3e7e14...`	`9a9355a15054755a...`
*-riscv64-linux-gnu-debug.tar.gz	`1c3321331846d84a...`	`ceb4885d45ec3e46...`
*-riscv64-linux-gnu.tar.gz	`1330260253e01275...`	`9f4fe243a06ffc0b...`
*-x86_64-apple-darwin-codesigning.tar.gz	`7cbc330771ad9193...`	`eb600b9214d25e6f...`
*-x86_64-apple-darwin-unsigned.tar.gz	`426bfa03adfbb09f...`	`0b01f031616d33e3...`
*-x86_64-apple-darwin-unsigned.zip	`23f8efdab69a8c18...`	`cee777f9668a2df9...`
*-x86_64-linux-gnu-debug.tar.gz	`eb48af97e91875d0...`	`77db7dc5edcb2b0f...`
*-x86_64-linux-gnu.tar.gz	`db07a4c7b7a9ddfa...`	`44c5809a23a7e37f...`
*.tar.gz	`612cf2d5e889847d...`	`509e9472927585a7...`
SHA256SUMS.part	`d1d37d157054fdb7...`	`0b5d66ff079505c6...`
guix_build.log	`3b26cb33be7e6c10...`	`05580ee40e41a737...`
guix_build.log.diff		`d29f2d7747fff509...`

DrahtBot removed the label DrahtBot Guix build requested on Apr 20, 2025

Update secp256k1 subtree to latest master #32028

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Update `secp256k1` subtree to latest master #32028