Update `secp256k1` subtree to latest master #32028

hebasto commented at 5:37 PM on March 10, 2025: member

This PR updates the secp256k1 subtree to https://github.com/bitcoin-core/secp256k1/commit/4ba1ba2af953b7d124db9b80b34568e5c4a2d48a, which includes the following changes:

https://github.com/bitcoin-core/secp256k1/pull/1647 is required for #31507.

hebasto added the label Build system on Mar 10, 2025

DrahtBot commented at 5:37 PM on March 10, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32028.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake
Concept ACK	Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#28201 (Silent Payments: sending by josibake)
#28122 (Silent Payments: Implement BIP352 by josibake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

Here are the identified typographic and grammatical errors that impact comprehension in the provided git diff:

CHECK(secp256k1_ec_seckey_tweak_add(CTX, privkey, rnd); -> CHECK(secp256k1_ec_seckey_tweak_add(CTX, privkey, rnd)); [missing closing parenthesis]
CHECK(secp256k1_ec_pubkey_tweak_add(CTX, &pubkey, rnd); -> CHECK(secp256k1_ec_pubkey_tweak_add(CTX, &pubkey, rnd)); [missing closing parenthesis]
CHECK(secp256k1_ec_seckey_tweak_mul(CTX, privkey, rnd); -> CHECK(secp256k1_ec_seckey_tweak_mul(CTX, privkey, rnd)); [missing closing parenthesis]
CHECK(secp256k1_ec_pubkey_tweak_mul(CTX, &pubkey, rnd); -> CHECK(secp256k1_ec_pubkey_tweak_mul(CTX, &pubkey, rnd)); [missing closing parenthesis]
tests_wycheproof_generate_ecdsa.py\. -> tests_wycheproof_generate_ecdsa.py [missing backtick]

fanquake commented at 7:11 AM on March 11, 2025: member

The latter is required for #31507.

If we are going to start bumping subtrees, can you at least add a PR description, given 31507 still doesn't have one.

hebasto commented at 3:29 PM on March 11, 2025: member

The latter is required for #31507.

If we are going to start bumping subtrees, can you at least add a PR description, given 31507 still doesn't have one.

My apologies. Fixed.

Sjors commented at 10:28 AM on March 12, 2025: member

Concept ACK on (temporarily) using master instead of a release tag. However we should probably wait with merging this until #31507 has at least one code review ACK from a build system expert?

ACK 7803eb4a51f3a7a7e76b4f45fb211ffa87a7e9bd

Ran the git-subtree-check.sh check. I didn't review the upstream changes.

On (ARM) macOS 15.3.1 I ran a testnet4 IBD with a debug build.

hebasto force-pushed on Mar 17, 2025

hebasto commented at 12:25 PM on March 17, 2025: member

Rebased and updated with the recent changes from the upstream repo.

maflcko added the label DrahtBot Guix build requested on Apr 16, 2025

DrahtBot commented at 12:08 PM on April 20, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit d91a746815e4428c738f1a096a950292cbdb5469<br>(master)	commit 7d6fb6351d0e9435dd96f0bbb0e0fa4b842e7d59<br>(pull/32028/merge)
*-aarch64-linux-gnu-debug.tar.gz	`2110c9d6963c9c61...`	`9d8462b17d042813...`
*-aarch64-linux-gnu.tar.gz	`dbb660c817c639e1...`	`85582e98ed0951e4...`
*-arm-linux-gnueabihf-debug.tar.gz	`ac8336f21d087a0b...`	`14045d0878a2ab00...`
*-arm-linux-gnueabihf.tar.gz	`bb9c16d16af758b4...`	`1829c07022ae53a7...`
*-arm64-apple-darwin-codesigning.tar.gz	`b1f7376f5a76be17...`	`9e1b948bbb081fe9...`
*-arm64-apple-darwin-unsigned.tar.gz	`76b73d4ad051154f...`	`0ae84736eef74b20...`
*-arm64-apple-darwin-unsigned.zip	`714ab6c2ec0b666c...`	`cbb942f0bcdafd4c...`
*-powerpc64-linux-gnu-debug.tar.gz	`a1c3361a3648d343...`	`3637a5cbc58b1579...`
*-powerpc64-linux-gnu.tar.gz	`1972c6a33c3e7e14...`	`9a9355a15054755a...`
*-riscv64-linux-gnu-debug.tar.gz	`1c3321331846d84a...`	`ceb4885d45ec3e46...`
*-riscv64-linux-gnu.tar.gz	`1330260253e01275...`	`9f4fe243a06ffc0b...`
*-x86_64-apple-darwin-codesigning.tar.gz	`7cbc330771ad9193...`	`eb600b9214d25e6f...`
*-x86_64-apple-darwin-unsigned.tar.gz	`426bfa03adfbb09f...`	`0b01f031616d33e3...`
*-x86_64-apple-darwin-unsigned.zip	`23f8efdab69a8c18...`	`cee777f9668a2df9...`
*-x86_64-linux-gnu-debug.tar.gz	`eb48af97e91875d0...`	`77db7dc5edcb2b0f...`
*-x86_64-linux-gnu.tar.gz	`db07a4c7b7a9ddfa...`	`44c5809a23a7e37f...`
*.tar.gz	`612cf2d5e889847d...`	`509e9472927585a7...`
SHA256SUMS.part	`d1d37d157054fdb7...`	`0b5d66ff079505c6...`
guix_build.log	`3b26cb33be7e6c10...`	`05580ee40e41a737...`
guix_build.log.diff		`d29f2d7747fff509...`

DrahtBot removed the label DrahtBot Guix build requested on Apr 20, 2025

fanquake commented at 10:20 AM on May 8, 2025: member

No movement in #31507, but could rebase & update this with the one new commit?

hebasto force-pushed on May 8, 2025

hebasto commented at 1:14 PM on May 8, 2025: member

No movement in #31507, but could rebase & update this with the one new commit?

Sure! Rebased and updated.

Squashed 'src/secp256k1/' changes from 0cdc758a56..4187a46649

4187a46649 Merge bitcoin-core/secp256k1#1492: tests: Add Wycheproof ECDH vectors
e266ba11ae tests: Add Wycheproof ECDH vectors
13906b7154 Merge bitcoin-core/secp256k1#1669: gitignore: Add Python cache files
c1bcb03276 gitignore: Add Python cache files
70f149b9a1 Merge bitcoin-core/secp256k1#1662: bench: add ellswift to bench help output
6b3fe51fb6 bench: add ellswift to bench help output
d84bb83e26 Merge bitcoin-core/secp256k1#1661: configure: Show exhaustive tests in summary
3f54ed8c1b Merge bitcoin-core/secp256k1#1659: include: remove WARN_UNUSED_RESULT for functions always returning 1
20b05c9d3f configure: Show exhaustive tests in summary
e56716a3bc Merge bitcoin-core/secp256k1#1660: ci: Fix exiting from ci.sh on error
d87c3bc58f ci: Fix exiting from ci.sh on error
1b6e081538 include: remove WARN_UNUSED_RESULT for functions always returning 1
2abb35b034 Merge bitcoin-core/secp256k1#1657: tests: remove unused uncounting_illegal_callback_fn
51907fa918 tests: remove unused uncounting_illegal_callback_fn
a7a5117144 Merge bitcoin-core/secp256k1#1359: Fix symbol visibility issues, add test for it
13ed6f65dc Merge bitcoin-core/secp256k1#1593: Remove deprecated `_ec_privkey_{negate,tweak_add,tweak_mul}` aliases from API
d1478763a5 build: Drop no longer needed  `-fvisibility=hidden` compiler option
8ed1d83d92 ci: Run `tools/symbol-check.py`
41d32ab2de test: Add `tools/symbol-check.py`
88548058b3 Introduce `SECP256K1_LOCAL_VAR` macro
03bbe8c615 Merge bitcoin-core/secp256k1#1655: gha: Print all *.log files, in a separate action
59860bcc24 gha: Print all *.log files, in a separate action
4ba1ba2af9 Merge bitcoin-core/secp256k1#1647: cmake: Adjust diagnostic flags for `clang-cl`
abd25054a1 Merge bitcoin-core/secp256k1#1656: musig: Fix clearing of pubnonces
961ec25a83 musig: Fix clearing of pubnonces
3186082387 Merge bitcoin-core/secp256k1#1614: Add _ge_set_all_gej and use it in musig for own public nonces
6c2a39dafb Merge bitcoin-core/secp256k1#1639: Make static context const
37d2c60bec Remove deprecated _ec_privkey_{negate,tweak_add,tweak_mul} aliases
432ac57705 Make static context const
1b1fc09341 Merge bitcoin-core/secp256k1#1642: Verify `compressed` argument in `secp256k1_eckey_pubkey_serialize`
c0d9480fbb Merge bitcoin-core/secp256k1#1654: use `EXIT_` constants over magic numbers for indicating program execution status
13d389629a CONTRIBUTING: mention that `EXIT_` codes should be used
c855581728 test, bench, precompute_ecmult: use `EXIT_...` constants for `main` return values
965393fcea examples: use `EXIT_...` constants for `main` return values
2e3bf13653 Merge bitcoin-core/secp256k1#1646: README: add instructions for verifying GPG signatures
b682dbcf84 README: add instructions for verifying GPG signatures
00774d0723 Merge bitcoin-core/secp256k1#1650: schnorrsig: clear out masked secret key in BIP-340 nonce function
a82287fb85 schnorrsig: clear out masked secret key in BIP-340 nonce function
4c50d73dd9 ci: Add new "Windows (clang-cl)" job
84c0bd1f72 cmake: Adjust diagnostic flags for clang-cl
f79f46c703 Merge bitcoin-core/secp256k1#1641: doc: Improve cmake instructions in README
2ac9f558c4 doc: Improve cmake instructions in README
1823594761 Verify `compressed` argument in `secp256k1_eckey_pubkey_serialize`
8deef00b33 Merge bitcoin-core/secp256k1#1634: Fix some misspellings
39705450eb Fix some misspellings
ec329c2501 Merge bitcoin-core/secp256k1#1633: release cleanup: bump version after 0.6.0
c97059f594 release cleanup: bump version after 0.6.0
64228a648f musig: Use _ge_set_all_gej for own public nonces
300aab1c05 tests: Improve _ge_set_all_gej(_var) tests
365f274ce3 group: Simplify secp256k1_ge_set_all_gej
d3082ddead group: Add constant-time secp256k1_ge_set_all_gej

git-subtree-dir: src/secp256k1
git-subtree-split: 4187a4664914dc6f6fb6a619c6b85c854fc33033

c31fcaaad3

Update secp256k1 subtree to latest master 915c1fa72c

hebasto force-pushed on May 13, 2025

hebasto commented at 10:33 AM on May 13, 2025: member

Rebased and updated.

fanquake commented at 12:51 PM on May 13, 2025: member

Guix Build:

24986a84cc15356c2761a8d05898d33d60ff10431eecdf68d9fb758432a87f79  guix-build-915c1fa72c07/output/aarch64-linux-gnu/SHA256SUMS.part
be7bba66e8e84ba8428aed395a296e397d07f5d961bb8ab80bdd19d2c48589ba  guix-build-915c1fa72c07/output/aarch64-linux-gnu/bitcoin-915c1fa72c07-aarch64-linux-gnu-debug.tar.gz
a77553ea1b9eca35f6b9bc00f0be22f3016b8fdf1425b71ec93a6fdbcd8e154c  guix-build-915c1fa72c07/output/aarch64-linux-gnu/bitcoin-915c1fa72c07-aarch64-linux-gnu.tar.gz
4f1a82c81d0f9f3510130507e08d90c11eb8a8a601218bab91247d676ba4b687  guix-build-915c1fa72c07/output/arm-linux-gnueabihf/SHA256SUMS.part
094ae0a5049d41f5f657c838bbca63b17c72a5eb421ac6eea1475d205daf5804  guix-build-915c1fa72c07/output/arm-linux-gnueabihf/bitcoin-915c1fa72c07-arm-linux-gnueabihf-debug.tar.gz
e9215a29bd525f5175461f897a861eb8336433136f26dc82ea06ce6a3068efb1  guix-build-915c1fa72c07/output/arm-linux-gnueabihf/bitcoin-915c1fa72c07-arm-linux-gnueabihf.tar.gz
f9e82347e97d4f2bc4dbe441c8835c39b21507f9dd066ec6ba92276b9e9529b7  guix-build-915c1fa72c07/output/arm64-apple-darwin/SHA256SUMS.part
b4f0d40ba5d37051ed529c8611d6cabdedc72084b3050f50816c20579e6516cf  guix-build-915c1fa72c07/output/arm64-apple-darwin/bitcoin-915c1fa72c07-arm64-apple-darwin-codesigning.tar.gz
ab3066e2957caace712cfd310a36b64fe66111319318642314c651c4182f9b2f  guix-build-915c1fa72c07/output/arm64-apple-darwin/bitcoin-915c1fa72c07-arm64-apple-darwin-unsigned.tar.gz
f1e674b9d975a2abba5293552891e883e7ce580c43ab49eb660a991ff63641d2  guix-build-915c1fa72c07/output/arm64-apple-darwin/bitcoin-915c1fa72c07-arm64-apple-darwin-unsigned.zip
b2fbae0c90f64bc18b002af3978dc0a40446f531edd45b1cda8913387fb1b71b  guix-build-915c1fa72c07/output/dist-archive/bitcoin-915c1fa72c07.tar.gz
24c7b06afe8e7c9c1d09b83e47c7be4bc73647de04c6bec9fefda416c81ea3db  guix-build-915c1fa72c07/output/powerpc64-linux-gnu/SHA256SUMS.part
17a3c9417ec76b9a173e111a2b2c34857643faa1db5866dc86e0b6aa37082df8  guix-build-915c1fa72c07/output/powerpc64-linux-gnu/bitcoin-915c1fa72c07-powerpc64-linux-gnu-debug.tar.gz
3fd3e70b571f8b882d87cb145c13baf2de932caaa20ef5574f872612920e1ab6  guix-build-915c1fa72c07/output/powerpc64-linux-gnu/bitcoin-915c1fa72c07-powerpc64-linux-gnu.tar.gz
bf2c637aad143a4b7ce75d065df1604f976fa49125acc09e4280d62fdbe94ea6  guix-build-915c1fa72c07/output/riscv64-linux-gnu/SHA256SUMS.part
27593d36f7c89b7f0b00c550683deab46641f7d85a166e3accb76527bdea9af5  guix-build-915c1fa72c07/output/riscv64-linux-gnu/bitcoin-915c1fa72c07-riscv64-linux-gnu-debug.tar.gz
c250c4c27cf8acb1fdf70f862b342a15dab0bbca1c2345f80934a4687a257a9e  guix-build-915c1fa72c07/output/riscv64-linux-gnu/bitcoin-915c1fa72c07-riscv64-linux-gnu.tar.gz
20c2e602fd4c4dd142fcc51eb5c70ea5d19f3a87a6d656fe3191cba69d1fb704  guix-build-915c1fa72c07/output/x86_64-apple-darwin/SHA256SUMS.part
23df5c5264a93c4569cde1d6449d89848478c01588e301ed4de7b1cc0f21ec7f  guix-build-915c1fa72c07/output/x86_64-apple-darwin/bitcoin-915c1fa72c07-x86_64-apple-darwin-codesigning.tar.gz
79a315e74728f513be0b13ca1685bfa2b6cfc98d288b71296210d288e4439585  guix-build-915c1fa72c07/output/x86_64-apple-darwin/bitcoin-915c1fa72c07-x86_64-apple-darwin-unsigned.tar.gz
8fd043e1110876b2cef30624963b27bb3d0bf9fa7c5808fa92e38db52058bbd0  guix-build-915c1fa72c07/output/x86_64-apple-darwin/bitcoin-915c1fa72c07-x86_64-apple-darwin-unsigned.zip
5ac15743a088b4fdcba018f7ff3e37166757d80b3d7759093dd766e3b596cc42  guix-build-915c1fa72c07/output/x86_64-linux-gnu/SHA256SUMS.part
d969c648d3d8f437e61fe2f698a8dcd5ad7b4baab2244513b782e2a53fb2e964  guix-build-915c1fa72c07/output/x86_64-linux-gnu/bitcoin-915c1fa72c07-x86_64-linux-gnu-debug.tar.gz
737f306a3803822b8b602e67143f29e8de3aea18619e33a5564f614a73933a88  guix-build-915c1fa72c07/output/x86_64-linux-gnu/bitcoin-915c1fa72c07-x86_64-linux-gnu.tar.gz
adc391a6140b93e479bc4c5447986142b0629804356736b3014ba7e2042ebd7d  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/SHA256SUMS.part
142b27dd0def2ab68fcc6801f6885a3fb7cf74c3dd151b7b81c707244cded98a  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/bitcoin-915c1fa72c07-win64-codesigning.tar.gz
81fb7e6c7f5141735e86b077e3cd07eb38fd88b11642a24ed14b5486bd7f7617  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/bitcoin-915c1fa72c07-win64-debug.zip
b4c0fe5eee83b6f7eb6a0357953feb564aab9bf9056fb01a004768d4b2c4306e  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/bitcoin-915c1fa72c07-win64-setup-unsigned.exe
e6badb14bc63d631530d5639e66b2f7fc6898e37116bf0b6ebc54c87995efcac  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/bitcoin-915c1fa72c07-win64-unsigned.zip

hebasto commented at 3:06 PM on May 13, 2025: member

My Guix build:

aarch64
24986a84cc15356c2761a8d05898d33d60ff10431eecdf68d9fb758432a87f79  guix-build-915c1fa72c07/output/aarch64-linux-gnu/SHA256SUMS.part
be7bba66e8e84ba8428aed395a296e397d07f5d961bb8ab80bdd19d2c48589ba  guix-build-915c1fa72c07/output/aarch64-linux-gnu/bitcoin-915c1fa72c07-aarch64-linux-gnu-debug.tar.gz
a77553ea1b9eca35f6b9bc00f0be22f3016b8fdf1425b71ec93a6fdbcd8e154c  guix-build-915c1fa72c07/output/aarch64-linux-gnu/bitcoin-915c1fa72c07-aarch64-linux-gnu.tar.gz
4f1a82c81d0f9f3510130507e08d90c11eb8a8a601218bab91247d676ba4b687  guix-build-915c1fa72c07/output/arm-linux-gnueabihf/SHA256SUMS.part
094ae0a5049d41f5f657c838bbca63b17c72a5eb421ac6eea1475d205daf5804  guix-build-915c1fa72c07/output/arm-linux-gnueabihf/bitcoin-915c1fa72c07-arm-linux-gnueabihf-debug.tar.gz
e9215a29bd525f5175461f897a861eb8336433136f26dc82ea06ce6a3068efb1  guix-build-915c1fa72c07/output/arm-linux-gnueabihf/bitcoin-915c1fa72c07-arm-linux-gnueabihf.tar.gz
f9e82347e97d4f2bc4dbe441c8835c39b21507f9dd066ec6ba92276b9e9529b7  guix-build-915c1fa72c07/output/arm64-apple-darwin/SHA256SUMS.part
b4f0d40ba5d37051ed529c8611d6cabdedc72084b3050f50816c20579e6516cf  guix-build-915c1fa72c07/output/arm64-apple-darwin/bitcoin-915c1fa72c07-arm64-apple-darwin-codesigning.tar.gz
ab3066e2957caace712cfd310a36b64fe66111319318642314c651c4182f9b2f  guix-build-915c1fa72c07/output/arm64-apple-darwin/bitcoin-915c1fa72c07-arm64-apple-darwin-unsigned.tar.gz
f1e674b9d975a2abba5293552891e883e7ce580c43ab49eb660a991ff63641d2  guix-build-915c1fa72c07/output/arm64-apple-darwin/bitcoin-915c1fa72c07-arm64-apple-darwin-unsigned.zip
b2fbae0c90f64bc18b002af3978dc0a40446f531edd45b1cda8913387fb1b71b  guix-build-915c1fa72c07/output/dist-archive/bitcoin-915c1fa72c07.tar.gz
24c7b06afe8e7c9c1d09b83e47c7be4bc73647de04c6bec9fefda416c81ea3db  guix-build-915c1fa72c07/output/powerpc64-linux-gnu/SHA256SUMS.part
17a3c9417ec76b9a173e111a2b2c34857643faa1db5866dc86e0b6aa37082df8  guix-build-915c1fa72c07/output/powerpc64-linux-gnu/bitcoin-915c1fa72c07-powerpc64-linux-gnu-debug.tar.gz
3fd3e70b571f8b882d87cb145c13baf2de932caaa20ef5574f872612920e1ab6  guix-build-915c1fa72c07/output/powerpc64-linux-gnu/bitcoin-915c1fa72c07-powerpc64-linux-gnu.tar.gz
bf2c637aad143a4b7ce75d065df1604f976fa49125acc09e4280d62fdbe94ea6  guix-build-915c1fa72c07/output/riscv64-linux-gnu/SHA256SUMS.part
27593d36f7c89b7f0b00c550683deab46641f7d85a166e3accb76527bdea9af5  guix-build-915c1fa72c07/output/riscv64-linux-gnu/bitcoin-915c1fa72c07-riscv64-linux-gnu-debug.tar.gz
c250c4c27cf8acb1fdf70f862b342a15dab0bbca1c2345f80934a4687a257a9e  guix-build-915c1fa72c07/output/riscv64-linux-gnu/bitcoin-915c1fa72c07-riscv64-linux-gnu.tar.gz
20c2e602fd4c4dd142fcc51eb5c70ea5d19f3a87a6d656fe3191cba69d1fb704  guix-build-915c1fa72c07/output/x86_64-apple-darwin/SHA256SUMS.part
23df5c5264a93c4569cde1d6449d89848478c01588e301ed4de7b1cc0f21ec7f  guix-build-915c1fa72c07/output/x86_64-apple-darwin/bitcoin-915c1fa72c07-x86_64-apple-darwin-codesigning.tar.gz
79a315e74728f513be0b13ca1685bfa2b6cfc98d288b71296210d288e4439585  guix-build-915c1fa72c07/output/x86_64-apple-darwin/bitcoin-915c1fa72c07-x86_64-apple-darwin-unsigned.tar.gz
8fd043e1110876b2cef30624963b27bb3d0bf9fa7c5808fa92e38db52058bbd0  guix-build-915c1fa72c07/output/x86_64-apple-darwin/bitcoin-915c1fa72c07-x86_64-apple-darwin-unsigned.zip
5ac15743a088b4fdcba018f7ff3e37166757d80b3d7759093dd766e3b596cc42  guix-build-915c1fa72c07/output/x86_64-linux-gnu/SHA256SUMS.part
d969c648d3d8f437e61fe2f698a8dcd5ad7b4baab2244513b782e2a53fb2e964  guix-build-915c1fa72c07/output/x86_64-linux-gnu/bitcoin-915c1fa72c07-x86_64-linux-gnu-debug.tar.gz
737f306a3803822b8b602e67143f29e8de3aea18619e33a5564f614a73933a88  guix-build-915c1fa72c07/output/x86_64-linux-gnu/bitcoin-915c1fa72c07-x86_64-linux-gnu.tar.gz
adc391a6140b93e479bc4c5447986142b0629804356736b3014ba7e2042ebd7d  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/SHA256SUMS.part
142b27dd0def2ab68fcc6801f6885a3fb7cf74c3dd151b7b81c707244cded98a  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/bitcoin-915c1fa72c07-win64-codesigning.tar.gz
81fb7e6c7f5141735e86b077e3cd07eb38fd88b11642a24ed14b5486bd7f7617  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/bitcoin-915c1fa72c07-win64-debug.zip
b4c0fe5eee83b6f7eb6a0357953feb564aab9bf9056fb01a004768d4b2c4306e  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/bitcoin-915c1fa72c07-win64-setup-unsigned.exe
e6badb14bc63d631530d5639e66b2f7fc6898e37116bf0b6ebc54c87995efcac  guix-build-915c1fa72c07/output/x86_64-w64-mingw32/bitcoin-915c1fa72c07-win64-unsigned.zip

fanquake commented at 3:27 PM on May 13, 2025: member

Here are the identified typographic and grammatical errors that impact comprehension in the provided git diff:

CHECK(secp256k1_ec_seckey_tweak_add(CTX, privkey, rnd); -> CHECK(secp256k1_ec_seckey_tweak_add(CTX, privkey, rnd)); [missing closing parenthesis]

I can't seem to find CHECK(secp256k1_ec_seckey_tweak_add(CTX, privkey, rnd) in either our, or libsecp256k1s codebase.

fanquake approved

fanquake commented at 3:39 PM on May 13, 2025: member

ACK 915c1fa72c07a1908f7dc18a065230c7c4a64db2

DrahtBot requested review from Sjors on May 13, 2025

fanquake merged this on May 13, 2025

fanquake closed this on May 13, 2025

hebasto deleted the branch on May 13, 2025

maflcko commented at 3:51 PM on May 13, 2025: member

I can't seem to find CHECK(secp256k1_ec_seckey_tweak_add(CTX, privkey, rnd) in either our, or libsecp256k1s codebase.

See https://github.com/maflcko/DrahtBot/issues/50.

Though, it (obviously) can't be fixed here in a subtree bump anyway.