contrib: Fix gen-bitcoin-conf.sh #32049

pull davidgumberg wants to merge 1 commits into bitcoin:master from davidgumberg:3-12-25-conf-gen-fix changing 1 files +2 −1
  1. davidgumberg commented at 10:00 pm on March 12, 2025: contributor

    In #31118, the format of bitcoind’s --help output changed slightly in a way that breaks gen-bitcoin-conf.sh, modify the script to accommodate the new format, by starting after the line that says “Options:” and stripping the -help options and descriptions from the script output.

    Before this PR, all options above -help were excluded from the example bitcoin.conf.

  2. DrahtBot commented at 10:00 pm on March 12, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32049.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK glozow, rkrux, mabu44, BrandonOdiwuor

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Scripts and tools on Mar 12, 2025
  4. contrib: Fix `gen-bitcoin-conf.sh`.
    In #31118, the format of bitcoind's `--help` output changed slightly in
    a way that breaks `gen-bitcoin-conf.sh`, modify the script to accomodate
    the new format, by starting after the line that says "Options:" and
    strip the `-help` option and its description from the output.
    a24419f8be
  5. davidgumberg force-pushed on Mar 12, 2025
  6. achow101 added this to the milestone 29.0 on Mar 12, 2025
  7. achow101 added the label Needs backport (29.x) on Mar 12, 2025
  8. glozow commented at 4:18 am on March 13, 2025: member
    ACK a24419f8bed5e1145ce171dbbdad957750585471
  9. rkrux approved
  10. rkrux commented at 10:34 am on March 13, 2025: contributor

    tACK a24419f8bed5e1145ce171dbbdad957750585471

    I can see it adds the previously excluded options now (starting with alertnotify) in the example conf file.

  11. mabu44 commented at 2:42 pm on March 13, 2025: none
    Tested ACK a24419f8bed5e1145ce171dbbdad957750585471
  12. BrandonOdiwuor commented at 4:46 pm on March 13, 2025: contributor
    crACK a24419f8bed5e1145ce171dbbdad957750585471
  13. glozow merged this on Mar 13, 2025
  14. glozow closed this on Mar 13, 2025

  15. glozow referenced this in commit 80c5d57bd1 on Mar 13, 2025
  16. fanquake removed the label Needs backport (29.x) on Mar 14, 2025
  17. fanquake commented at 3:14 am on March 14, 2025: member
    Backported in #32062.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-28 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me