davidgumberg
commented at 10:00 pm on March 12, 2025:
contributor
In #31118, the format of bitcoind’s --help output changed slightly in a way that breaks gen-bitcoin-conf.sh, modify the script to accommodate the new format, by starting after the line that says “Options:” and stripping the -help options and descriptions from the script output.
Before this PR, all options above -help were excluded from the example bitcoin.conf.
DrahtBot
commented at 10:00 pm on March 12, 2025:
contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label
Scripts and tools
on Mar 12, 2025
contrib: Fix `gen-bitcoin-conf.sh`.
In #31118, the format of bitcoind's `--help` output changed slightly in
a way that breaks `gen-bitcoin-conf.sh`, modify the script to accomodate
the new format, by starting after the line that says "Options:" and
strip the `-help` option and its description from the output.
a24419f8be
davidgumberg force-pushed
on Mar 12, 2025
achow101 added this to the milestone 29.0
on Mar 12, 2025
achow101 added the label
Needs backport (29.x)
on Mar 12, 2025
glozow
commented at 4:18 am on March 13, 2025:
member
ACKa24419f8bed5e1145ce171dbbdad957750585471
rkrux approved
rkrux
commented at 10:34 am on March 13, 2025:
contributor
tACKa24419f8bed5e1145ce171dbbdad957750585471
I can see it adds the previously excluded options now (starting with alertnotify) in the example conf file.
mabu44
commented at 2:42 pm on March 13, 2025:
none
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2025-03-28 15:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me