refactor: Remove spurious virtual from final ~CZMQNotificationInterface #32187

virtual does not make sense here, because:

• The class is final, thus the destructor isn't overridden in a derived class
• The destructor also isn't overriding the destructor of the base, clarified in commit 2b3ea39de40bc7754cab558245e4ddac1b261750
• Clang 21 may warn about this

src/zmq/zmqnotificationinterface.h:25:13: error: virtual method '~CZMQNotificationInterface' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
   25 |     virtual ~CZMQNotificationInterface();
      |             ^

Fix all issues by removing it.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32187.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

(ci failure can be ignored and is unrelated, see #32184)

ACK fa69c42

The change is not crucial, but it makes the code more precise and has additional benefits.

• Code review ✅
• Run tests ✅
• More extensive fuzzer run because of CI failures ✅

ACK fa69c42fdf0aeec0546e951bc6132ab630edb9d4

crACK https://github.com/bitcoin/bitcoin/commit/fa69c42fdf0aeec0546e951bc6132ab630edb9d4

• Clang 21 may warn about this

src/zmq/zmqnotificationinterface.h:25:13: error: virtual method '~CZMQNotificationInterface' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
   25 |     virtual ~CZMQNotificationInterface();
      |             ^

Does Clang 21 have this warning enabled? Asking because I can't see warnings in https://github.com/hebasto/bitcoin-core-nightly/actions/workflows/clang.yml.

Does Clang 21 have this warning enabled? Asking because I can't see warnings in https://github.com/hebasto/bitcoin-core-nightly/actions/workflows/clang.yml.

It ran 6 hours ago, but this pull was merged 7 hours ago. Thus, if you want to test it with clang-21, you'll have to revert the pull first.

Does Clang 21 have this warning enabled? Asking because I can't see warnings in https://github.com/hebasto/bitcoin-core-nightly/actions/workflows/clang.yml.

It ran 6 hours ago, but this pull was merged 7 hours ago. Thus, if you want to test it with clang-21, you'll have to revert the pull first.

This one run @ 74d9598bfbc24c3b7bfe1dad5bf9d988381bf893.

I don't know, but it is possibly before clang enabled the warning by default? I tested Ubuntu clang version 21.0.0 (++20250331082744+4e8fbc60710e-1~exp1~20250331202915.820)

My recommendation would be to just test on a fresh install of everything, if you want to test this.

I can take a look, if it fails to reproduce.

The warning has been reproduced for Ubuntu clang version 21.0.0 (++20250401083335+9e5bfbf77db0-1~exp1~20250401083447.821): https://github.com/hebasto/bitcoin-core-nightly/actions/runs/14217750729/job/39838245769.

Post-merge ACK fa69c42fdf0aeec0546e951bc6132ab630edb9d4.