[28.x] Backports #32299

1. 
   fanquake commented at 2:27 PM on April 17, 2025: member

   Backports:

   • #32070
   • #32187
   • #32286
   • #32336
2. test: Handle empty string returned by CLI as None in RPC tests 9b15b20cb1
3. refactor: Remove spurious virtual from final ~CZMQNotificationInterface

   Github-Pull: #32187
   Rebased-From: fa69c42fdf0aeec0546e951bc6132ab630edb9d4

   2d6c14efba
4. build: use make < 3.82 syntax for define directive

   From the GNU make 3.82 release announcement:
   
   * The 'define' make directive now allows a variable assignment operator
     after the variable name, to allow for simple, conditional, or appending
     multi-line variable assignment.
   
   macOS ships with 3.81. This caused the multiprocess config options
   to be ignored.
   
   Fixes #32068
   
   Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
   
   Github-Pull: #32070
   Rebased-From: 9157d9e449870851ef455e077249ac46fc2df24c

   e65676216c
5. fanquake added this to the milestone 28.2 on Apr 17, 2025
6. 
   DrahtBot commented at 2:27 PM on April 17, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32299.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	willcl-ark

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

7. DrahtBot added the label Backport on Apr 17, 2025
8. DrahtBot added the label CI failed on Apr 17, 2025
9. test: Add imports for util bpf_cflags

   This is required for the next commit.
   
   Github-Pull: #32336
   Rebased-From: fa0c1baaf89805182de56d6a2e8eed2265a94b40

   3df2624ee9
10. fanquake force-pushed on Apr 24, 2025
11. scripted-diff: Use bpf_cflags

    -BEGIN VERIFY SCRIPT-
    
     ren() { sed --regexp-extended -i "s/$1/$2/g" $( git grep --extended-regexp -l "$1" ) ; }
    
     ren 'cflags=\["-Wno-error=implicit-function-declaration"\]' 'cflags=bpf_cflags()'
    
    -END VERIFY SCRIPT-
    
    Github-Pull: #32336
    Rebased-From: facb9b327b9da39ce1e09ed56199be9efb19b5b8

    2ccdfa424c
12. fanquake force-pushed on Apr 24, 2025
13. fanquake marked this as ready for review on May 12, 2025
14. fanquake requested review from willcl-ark on May 12, 2025
15. willcl-ark approved
16. 
    willcl-ark commented at 11:52 AM on May 13, 2025: member

    crACK a325ca34653872534529e7934d07fe4e2ca29cae

    Backports all look clean to me.

    Would only check that #32336 was left out of the release notes intentionally (it's not really "notable")?

17. doc: update release notes for 28.x 812e637521
18. fanquake force-pushed on May 13, 2025
19. 
    fanquake commented at 11:57 AM on May 13, 2025: member

    was left out of the release notes

    Fixed that up.

20. willcl-ark approved
21. 
    willcl-ark commented at 12:00 PM on May 13, 2025: member

    ACK 812e6375213e883a0c22aa926ebcde5da4d23a3e

    Only changes to release note since previous ACK.

22. fanquake merged this on May 13, 2025
23. fanquake closed this on May 13, 2025

    ---

24. fanquake deleted the branch on May 13, 2025

Milestone
28.2