test: Suppress upstream -Wduplicate-decl-specifier in bpfcc #32336

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2504-test-bpf-cflags changing 6 files +46 −26
  1. maflcko commented at 8:27 am on April 24, 2025: member

    On some Linux kernel versions, the bpf compiler invoked in the functional tests will issue a -Wduplicate-decl-specifier warning.

    This seems harmless and should be fixed upstream in the Linux kernel.

    Here, simply suppress it for now. Fixes https://github.com/bitcoin/bitcoin/issues/32322

  2. DrahtBot commented at 8:27 am on April 24, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32336.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK laanwj, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Tests on Apr 24, 2025
  4. test: Add imports for util bpf_cflags
    This is required for the next commit.
    fa0c1baaf8
  5. scripted-diff: Use bpf_cflags
    -BEGIN VERIFY SCRIPT-
    
     ren() { sed --regexp-extended -i "s/$1/$2/g" $( git grep --extended-regexp -l "$1" ) ; }
    
     ren 'cflags=\["-Wno-error=implicit-function-declaration"\]' 'cflags=bpf_cflags()'
    
    -END VERIFY SCRIPT-
    facb9b327b
  6. maflcko force-pushed on Apr 24, 2025
  7. laanwj approved
  8. laanwj commented at 9:19 am on April 24, 2025: member
    Code review ACK facb9b327b9da39ce1e09ed56199be9efb19b5b8
  9. hebasto approved
  10. hebasto commented at 9:24 am on April 24, 2025: member
    ACK facb9b327b9da39ce1e09ed56199be9efb19b5b8, I have reviewed the code and it looks OK.
  11. hebasto merged this on Apr 24, 2025
  12. hebasto closed this on Apr 24, 2025

  13. maflcko deleted the branch on Apr 24, 2025
  14. 0xB10C commented at 10:12 am on April 24, 2025: contributor
    Post merge ACK
  15. fanquake referenced this in commit 84e5576547 on Apr 24, 2025
  16. fanquake referenced this in commit 4e8713094b on Apr 24, 2025
  17. fanquake commented at 2:12 pm on April 24, 2025: member
    Backported to 29.x in #32292.
  18. fanquake referenced this in commit 3df2624ee9 on Apr 24, 2025
  19. fanquake referenced this in commit e478e63cd3 on Apr 24, 2025
  20. fanquake referenced this in commit 2ccdfa424c on Apr 24, 2025
  21. fanquake commented at 4:03 pm on April 24, 2025: member
    Backported to 28.x in #32299.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-30 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me