test: Suppress upstream `-Wduplicate-decl-specifier` in bpfcc #32336

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2504-test-bpf-cflags changing 6 files +46 −26
  1. maflcko commented at 8:27 AM on April 24, 2025: member

    On some Linux kernel versions, the bpf compiler invoked in the functional tests will issue a -Wduplicate-decl-specifier warning.

    This seems harmless and should be fixed upstream in the Linux kernel.

    Here, simply suppress it for now. Fixes https://github.com/bitcoin/bitcoin/issues/32322

  2. DrahtBot commented at 8:27 AM on April 24, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32336.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK laanwj, hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. DrahtBot added the label Tests on Apr 24, 2025
  4. test: Add imports for util bpf_cflags
    This is required for the next commit.
    fa0c1baaf8
  5. scripted-diff: Use bpf_cflags
    -BEGIN VERIFY SCRIPT-
    
     ren() { sed --regexp-extended -i "s/$1/$2/g" $( git grep --extended-regexp -l "$1" ) ; }
    
     ren 'cflags=\["-Wno-error=implicit-function-declaration"\]' 'cflags=bpf_cflags()'
    
    -END VERIFY SCRIPT-
    facb9b327b
  6. maflcko force-pushed on Apr 24, 2025
  7. laanwj approved
  8. laanwj commented at 9:19 AM on April 24, 2025: member

    Code review ACK facb9b327b9da39ce1e09ed56199be9efb19b5b8

  9. hebasto approved
  10. hebasto commented at 9:24 AM on April 24, 2025: member

    ACK facb9b327b9da39ce1e09ed56199be9efb19b5b8, I have reviewed the code and it looks OK.

  11. hebasto merged this on Apr 24, 2025
  12. hebasto closed this on Apr 24, 2025

  13. maflcko deleted the branch on Apr 24, 2025
  14. 0xB10C commented at 10:12 AM on April 24, 2025: contributor

    Post merge ACK

  15. fanquake referenced this in commit 84e5576547 on Apr 24, 2025
  16. fanquake referenced this in commit 4e8713094b on Apr 24, 2025
  17. fanquake commented at 2:12 PM on April 24, 2025: member

    Backported to 29.x in #32292.

  18. fanquake referenced this in commit 3df2624ee9 on Apr 24, 2025
  19. fanquake referenced this in commit e478e63cd3 on Apr 24, 2025
  20. fanquake referenced this in commit 2ccdfa424c on Apr 24, 2025
  21. fanquake commented at 4:03 PM on April 24, 2025: member

    Backported to 28.x in #32299.

  22. fanquake referenced this in commit 4ed5c34abb on May 6, 2025
  23. fanquake referenced this in commit 3665310808 on May 6, 2025
  24. fanquake referenced this in commit a124b91339 on May 13, 2025
  25. fanquake referenced this in commit 1fc7b9d260 on May 13, 2025
  26. fanquake referenced this in commit 882166642c on May 13, 2025
  27. fanquake referenced this in commit 589b56192f on May 22, 2025
  28. stickies-v referenced this in commit 772a33e052 on May 23, 2025
  29. sedited referenced this in commit cb3cd9b8b9 on May 29, 2025
  30. yuvicc referenced this in commit 069643f094 on Jul 6, 2025
  31. bug-castercv502 referenced this in commit 2858098810 on Sep 28, 2025
  32. morozow referenced this in commit f34342243d on May 8, 2026
  33. morozow referenced this in commit 6301f65390 on May 8, 2026
  34. morozow referenced this in commit f7a19fccb4 on May 8, 2026
  35. morozow referenced this in commit e684171497 on May 8, 2026
  36. morozow referenced this in commit 778f435f2d on May 8, 2026
  37. morozow referenced this in commit edc6b10728 on May 8, 2026
  38. morozow referenced this in commit 94c244ae53 on May 8, 2026
  39. morozow referenced this in commit 5e368592a8 on May 8, 2026
  40. Kino1994 referenced this in commit 440423baf0 on Jun 28, 2026
  41. BigcoinBGC referenced this in commit 4fcc9a3392 on Jun 30, 2026
  42. bitcoin locked this on Jul 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-10 22:52 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me