test: Suppress Windows abort message in CI #32409

1. 
   hebasto commented at 7:45 pm on May 2, 2025: member

   This PR ensures that all test executables, such as test_bitcoin.exe and fuzz.exe, run non-interactively in the CI environment.

   Otherwise, a failing assert() triggers the abort routine, which displays a message box and causes a timeout in CI.

   Here are CI jobs for the “Debug” configuration:

   • on the master branch: https://github.com/maflcko/bitcoin-core-with-ci/actions/runs/14759346479/job/41435857332
   • with this PR: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/14801894543/job/41562322239

   Addresses this comment.

2. hebasto added the label Windows on May 2, 2025
3. hebasto added the label Tests on May 2, 2025
4. 
   DrahtBot commented at 7:45 pm on May 2, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32409.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	shahsb

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. in src/test/fuzz/fuzz.cpp:248 in f7f803f4e2 outdated

   244@@ -245,6 +245,10 @@ int main(int argc, char** argv)
   245         test_one_input(buffer);
   246         return 0;
   247     }
   248+#ifdef WIN32
   

   ---

   ---

   

   shahsb commented at 2:35 am on May 3, 2025:

   0#ifdef _WIN32
   

   _WIN32 is a compiler flag and could be used for both windows platform i.e windows_x86 (32-bit) as well as windows_x64 (64-bit)

   ---

   

   hebasto commented at 6:44 am on May 3, 2025:

   The current code is consistent with our entire code base.
6. 
   shahsb commented at 2:36 am on May 3, 2025: none

   Concept ACK
7. 
   maflcko commented at 11:53 am on May 4, 2025: member

   No objection, but assert/Assert seems to be used widely in the codebase, so shouldn’t this be done for all test binaries, or none? Otherwise the same assert could lead to inconsistent behavior, depending on which test binary ran into it.
8. hebasto force-pushed on May 4, 2025
9. hebasto renamed this:
   fuzz: Suppress abort message on Windows
   test: Suppress Windows abort message in CI
   on May 4, 2025
10. 
    hebasto commented at 3:56 pm on May 4, 2025: member

    @maflcko

    No objection, but assert/Assert seems to be used widely in the codebase, so shouldn’t this be done for all test binaries, or none? Otherwise the same assert could lead to inconsistent behavior, depending on which test binary ran into it.

    Thanks! Reworked.

11. test: Suppress abort message on Windows

    This change ensures that all test binaries are non‑interactive in the CI
    environment.

    191bdd1f8e
12. hebasto force-pushed on May 4, 2025

Contributors
hebasto DrahtBot shahsb maflcko

Labels
Windows Tests