[27.x] Backports #32479

pull fanquake wants to merge 8 commits into bitcoin:27.x from fanquake:27_x_backports changing 14 files +63 −31
  1. fanquake commented at 1:31 pm on May 13, 2025: member
  2. test: Handle empty string returned by CLI as None in RPC tests
    Github-Pull: #32286
    Rebased-From: a4041c77f0e20d004524868e70ff12508832c9eb
    992c7cad46
  3. refactor: Remove spurious virtual from final ~CZMQNotificationInterface
    Github-Pull: #32187
    Rebased-From: fa69c42fdf0aeec0546e951bc6132ab630edb9d4
    418bee8f9d
  4. build: use make < 3.82 syntax for define directive
    From the GNU make 3.82 release announcement:
    
    * The 'define' make directive now allows a variable assignment operator
      after the variable name, to allow for simple, conditional, or appending
      multi-line variable assignment.
    
    macOS ships with 3.81. This caused the multiprocess config options
    to be ignored.
    
    Fixes #32068
    
    Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
    
    Github-Pull: #32070
    Rebased-From: 9157d9e449870851ef455e077249ac46fc2df24c
    f52ab00f69
  5. fanquake added this to the milestone 27.3 on May 13, 2025
  6. DrahtBot commented at 1:31 pm on May 13, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32479.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • accomodate -> accommodate [correct spelling]

    drahtbot_id_4_m

  7. DrahtBot added the label Backport on May 13, 2025
  8. fanquake commented at 2:02 pm on May 13, 2025: member

    This is failing in the macOS CI. An issue with Boost Process:

     0 configure:34786: checking whether Boost.Process can be used
     1configure:34817: g++ -std=gnu++11 -std=c++20 -o conftest  -Wno-error=narrowing  -isystem /usr/local/include -DBOOST_MULTI_INDEX_DISABLE_SERIALIZATION  -pthread conftest.cpp  >&5
     2conftest.cpp:64:9: error: no type named 'opstream' in namespace 'boost::process'
     3    bp::opstream stdin_stream;
     4    ~~~~^
     5conftest.cpp:65:18: error: use of undeclared identifier 'stdout_stream'; did you mean 'stdin_stream'?
     6    bp::ipstream stdout_stream;
     7                 ^~~~~~~~~~~~~
     8                 stdin_stream
     9conftest.cpp:64:18: note: 'stdin_stream' declared here
    10    bp::opstream stdin_stream;
    11                 ^
    12conftest.cpp:65:17: error: expected ';' after expression
    13    bp::ipstream stdout_stream;
    
  9. test: Add imports for util bpf_cflags
    This is required for the next commit.
    
    Github-Pull: #32336
    Rebased-From: fa0c1baaf89805182de56d6a2e8eed2265a94b40
    1fc7b9d260
  10. scripted-diff: Use bpf_cflags
    -BEGIN VERIFY SCRIPT-
    
     ren() { sed --regexp-extended -i "s/$1/$2/g" $( git grep --extended-regexp -l "$1" ) ; }
    
     ren 'cflags=\["-Wno-error=implicit-function-declaration"\]' 'cflags=bpf_cflags()'
    
    -END VERIFY SCRIPT-
    
    Github-Pull: #32336
    Rebased-From: facb9b327b9da39ce1e09ed56199be9efb19b5b8
    882166642c
  11. fanquake force-pushed on May 13, 2025
  12. DrahtBot added the label CI failed on May 13, 2025
  13. fanquake commented at 4:54 pm on May 13, 2025: member

    This is failing in the macOS CI. An issue with Boost Process:

    Looks this is because Boost Process V1 compat was broken in Boost 1.88.0, https://github.com/boostorg/process/issues/480, which is the version being used in the macOS CI here, and --enable-external-signer is passed globally in the CI.

  14. ci: remove --enable-external-signer
    Boost 1.88.0 (installed in the macOS CI) broke compat with Boost Process
    V1. As `--enable-external-signer` is set in the CI, this causes the
    macOS CI to fail. Remove `--enable-external-signer` from the CI.
    e0af7bffff
  15. fanquake force-pushed on May 19, 2025
  16. fanquake commented at 12:56 pm on May 19, 2025: member
    I’ve added a commit to drop --enable-external-signer from the global CI config.
  17. fanquake force-pushed on May 21, 2025
  18. fanquake marked this as ready for review on May 21, 2025
  19. fanquake commented at 11:58 am on May 21, 2025: member
    Added a note to the release notes as well.
  20. guix: accomodate migration to codeberg
    See https://guix.gnu.org/blog/2025/migrating-to-codeberg/.
    
    When interacting with the old repo you may now also see:
    ```bash
    warning: redirecting to https://codeberg.org/guix/guix/
    ```
    
    Github-Pull: #32439
    Rebased-From: d5ca4d4fd713a9f7e17e074a1e37dda99bbb09fc
    a328170e09
  21. doc: update release notes for 27.x 2b20f189bc
  22. fanquake force-pushed on May 29, 2025


fanquake DrahtBot

Labels
Backport CI failed

Milestone
27.3


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-29 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me