Set minimum supported Windows version to 1903 (May 2019 Update) #32537

hebasto commented at 4:32 PM on May 16, 2025: member

This PR sets the minimum supported Windows version to 1903 (May 2019 Update).

This version is the minimum required to support the UTF-8 code page (CP_UTF8), which is necessary for #32380.

Additionally, the symbol-check.py script has been amended to verify application manifests for supported OS value.

Set minimum supported Windows version to 1903 (May 2019 Update)

This version is the minimum required to support the UTF-8 code page
(CP_UTF8).

3edc671f54

symbol-check: Add supported OS check for application manifest in Windows 4748c63c1d

hebasto added the label Windows on May 16, 2025

hebasto added the label Build system on May 16, 2025

DrahtBot commented at 4:32 PM on May 16, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32537.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	laanwj

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#32431 (deps: Bump lief to 0.16.5 by davidgumberg)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto renamed this:
~~250516 win min ver~~
Set minimum supported Windows version to 1903 (May 2019 Update)
on May 16, 2025

hebasto commented at 4:33 PM on May 16, 2025: member

My Guix build:

aarch64
db31eebbbd5ed99567eea6d1e692130815e0b6e6c7041e8fe20918eb743ce3db  guix-build-4748c63c1d0f/output/aarch64-linux-gnu/SHA256SUMS.part
05ad41b64f57a027124138e3e5baf3325e4bcb433c851e9086526568068694f2  guix-build-4748c63c1d0f/output/aarch64-linux-gnu/bitcoin-4748c63c1d0f-aarch64-linux-gnu-debug.tar.gz
f230295bc79a313acaa16090609b28c6df6021213b8bd8dea9938b8e48037f17  guix-build-4748c63c1d0f/output/aarch64-linux-gnu/bitcoin-4748c63c1d0f-aarch64-linux-gnu.tar.gz
acc5897b77f8ae9067b48b1fa906383b05aa7b8a913e62823833e88dce37ae28  guix-build-4748c63c1d0f/output/arm-linux-gnueabihf/SHA256SUMS.part
25eb773eb9e07d3509dbbcfa238150bf60776a3510b36adc311fe5f6b3593d0b  guix-build-4748c63c1d0f/output/arm-linux-gnueabihf/bitcoin-4748c63c1d0f-arm-linux-gnueabihf-debug.tar.gz
4edf81fa7c6a138f538036b83b51dd111e1958e61592395f94c2b311672c4ed6  guix-build-4748c63c1d0f/output/arm-linux-gnueabihf/bitcoin-4748c63c1d0f-arm-linux-gnueabihf.tar.gz
296e0143264a41a690c74ea2ee41a9d01145459b79d80b97e7f69b0759920add  guix-build-4748c63c1d0f/output/arm64-apple-darwin/SHA256SUMS.part
b2f2e2f4470eec8ee2f1e33ef22d9b1444fa18360dcd8efedf1a34cc89e1d905  guix-build-4748c63c1d0f/output/arm64-apple-darwin/bitcoin-4748c63c1d0f-arm64-apple-darwin-codesigning.tar.gz
5029eb4e92bcced26e002a1ec9a2a8604eded79e250c8f69b76455334c80de7f  guix-build-4748c63c1d0f/output/arm64-apple-darwin/bitcoin-4748c63c1d0f-arm64-apple-darwin-unsigned.tar.gz
992e548f04795d8566080582543cfb54b0629fa354134b0d1236e4c85c035ec5  guix-build-4748c63c1d0f/output/arm64-apple-darwin/bitcoin-4748c63c1d0f-arm64-apple-darwin-unsigned.zip
f4eb629a80c80d1dd4c66d36d44b55f9122e2bb51fe0bc30949a88550299b733  guix-build-4748c63c1d0f/output/dist-archive/bitcoin-4748c63c1d0f.tar.gz
4c5222ccbaebc02bf0fd77b666676b0f473fdbbb20d78d424aeef1292c36c726  guix-build-4748c63c1d0f/output/powerpc64-linux-gnu/SHA256SUMS.part
c6950145e4020b1798e8f627d4c4b0c2d2b19f35570f93f5b89b9c64bb822af9  guix-build-4748c63c1d0f/output/powerpc64-linux-gnu/bitcoin-4748c63c1d0f-powerpc64-linux-gnu-debug.tar.gz
0ea0475e2fa4f7f0d9eefc71882c4e35a4913e3e0aa9ec92ad52c9e030ec0d4d  guix-build-4748c63c1d0f/output/powerpc64-linux-gnu/bitcoin-4748c63c1d0f-powerpc64-linux-gnu.tar.gz
b31c156f49b45b96637df4059e8d554486e34279f8eaf0fc2cfeec46825a2f38  guix-build-4748c63c1d0f/output/riscv64-linux-gnu/SHA256SUMS.part
9c645dce362afd8f2e54036a7601534aee568fe19eb643268c0b2cc6862b004f  guix-build-4748c63c1d0f/output/riscv64-linux-gnu/bitcoin-4748c63c1d0f-riscv64-linux-gnu-debug.tar.gz
6cf9399171c0b873f96b8ea9d6fb1acec4bfebe84476de54af299c0a2d99b9e0  guix-build-4748c63c1d0f/output/riscv64-linux-gnu/bitcoin-4748c63c1d0f-riscv64-linux-gnu.tar.gz
29e27f06b107e4f7c44eca43c815a530b65739f5b6c7c6180f7cba7f8835fee1  guix-build-4748c63c1d0f/output/x86_64-apple-darwin/SHA256SUMS.part
e97404f1c4fe7bd20bc392fd391dd1acb8e3297c33b847e5fb2077a40597eb3e  guix-build-4748c63c1d0f/output/x86_64-apple-darwin/bitcoin-4748c63c1d0f-x86_64-apple-darwin-codesigning.tar.gz
c35827eca5e43bd235dbd156a9022a55da6de9a3ab5d0782fc60c9633d46c85e  guix-build-4748c63c1d0f/output/x86_64-apple-darwin/bitcoin-4748c63c1d0f-x86_64-apple-darwin-unsigned.tar.gz
d3e33ff9b9495707b9dabc3ae12a74d4185f0d25d3dc49e00c424459f954b7e5  guix-build-4748c63c1d0f/output/x86_64-apple-darwin/bitcoin-4748c63c1d0f-x86_64-apple-darwin-unsigned.zip
256d3a1ece59f2546559486b1601f0b0d92c9cbe3b4b71d2ab069353da6d1e54  guix-build-4748c63c1d0f/output/x86_64-linux-gnu/SHA256SUMS.part
5995534433c36db6662fbc4e88976cc2f905c928a54d55a31d939a55273110be  guix-build-4748c63c1d0f/output/x86_64-linux-gnu/bitcoin-4748c63c1d0f-x86_64-linux-gnu-debug.tar.gz
5c501c4097aa365f33a31e67c672e6f23a002014696faf8d444f9927d7a04e10  guix-build-4748c63c1d0f/output/x86_64-linux-gnu/bitcoin-4748c63c1d0f-x86_64-linux-gnu.tar.gz
016f9b06f1e08267fdb3534bbf111d9bbd13341cc91b26d2c2e03d451d17dd4a  guix-build-4748c63c1d0f/output/x86_64-w64-mingw32/SHA256SUMS.part
e5d474b0a6c3be42694e970b6b83b9822ec34ea617f2ecc57bd01223e92ee749  guix-build-4748c63c1d0f/output/x86_64-w64-mingw32/bitcoin-4748c63c1d0f-win64-codesigning.tar.gz
0914ef733a526f2309445e11d7c7ebd17edd61717c93d20e2ff6ade43ac41bc7  guix-build-4748c63c1d0f/output/x86_64-w64-mingw32/bitcoin-4748c63c1d0f-win64-debug.zip
7f52f6ab37d3a1d8410e0204eb97775b2d9118f16434333a4f07fb297eb6e61e  guix-build-4748c63c1d0f/output/x86_64-w64-mingw32/bitcoin-4748c63c1d0f-win64-setup-unsigned.exe
8f6f83d4a6667f67b1f045fdc9fd14e58fe5ef3dcaa3df8e46edf3f6c4fe1640  guix-build-4748c63c1d0f/output/x86_64-w64-mingw32/bitcoin-4748c63c1d0f-win64-unsigned.zip

hebasto commented at 11:09 AM on May 19, 2025: member

Friendly ping @laanwj @davidgumberg @hodlinator @sipsorcery :)

laanwj commented at 11:28 AM on May 19, 2025: member

Concept ACK. We already require Windows 10, and running a version from more than 5 years ago seems a really bad idea (and unlikely, given how automatic updates work nowadays).

hebasto commented at 2:07 PM on May 19, 2025: member

... a version from more than 5 years ago...

6 :)

in cmake/windows-app.manifest.in:11 in 4748c63c1d

   4 | @@ -5,6 +5,12 @@
   5 |        name="org.bitcoincore.${target}"
   6 |        version="${CLIENT_VERSION_MAJOR}.${CLIENT_VERSION_MINOR}.${CLIENT_VERSION_BUILD}.0"
   7 |    />
   8 | +  <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
   9 | +      <application>
  10 | +          <!-- Windows 10, version 1903 -->
  11 | +          <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}" />

laanwj commented at 2:29 PM on May 19, 2025:

From what i could find, this tag covers every version of Windows 10 and 11, not just version 1903+. Not sure how/if you can specify a more specific minimum version.

hebasto commented at 2:54 PM on May 19, 2025:

You're right. I've misread docs...

hebasto commented at 3:01 PM on May 19, 2025:

In its current state, this PR is not necessary for introducing the UTF-8 code page support.

laanwj commented at 7:57 AM on May 20, 2025:

Imo, no need to do this as a separate step. Might as well roll the update to the release notes template into #32380.

hebasto marked this as a draft on May 19, 2025

hebasto closed this on May 19, 2025