test: Add missing ipc subtree to lint #32623

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2505-lint-sub changing 3 files +13 −20

maflcko commented at 8:12 am on May 27, 2025: member

The subtree docs and lint checks list the subtrees in three places, making it hard to follow and update and easy to miss one.

Fix all issues by including the missing one and removing the list in one place.

DrahtBot commented at 8:12 am on May 27, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32623.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, l0rinc, BrandonOdiwuor, davidgumberg, achow101
Stale ACK	TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Tests on May 27, 2025
TheCharlatan approved
TheCharlatan commented at 10:41 am on May 27, 2025: contributor

ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49

in test/lint/README.md:100 in fa2bf6bdb7 outdated

 98 * for `src/crc32c`: https://github.com/bitcoin-core/crc32c-subtree.git (branch bitcoin-fork)
 99+* for `src/crypto/ctaes`: https://github.com/bitcoin-core/ctaes.git (branch master)
100+* for `src/ipc/libmultiprocess`: https://github.com/bitcoin-core/libmultiprocess (branch master)
101+* for `src/leveldb`: https://github.com/bitcoin-core/leveldb-subtree.git (branch bitcoin-fork)
102 * for `src/minisketch`: https://github.com/bitcoin-core/minisketch.git (branch master)
103+* for `src/secp256k1`: https://github.com/bitcoin-core/secp256k1.git (branch master)

l0rinc commented at 11:46 am on May 27, 2025:

visiting the links will automatically remove the .git suffixes (which was already missing from libmultiprocess):

0* for `src/crc32c`: https://github.com/bitcoin-core/crc32c-subtree (branch `bitcoin-fork`)
1* for `src/crypto/ctaes`: https://github.com/bitcoin-core/ctaes (branch `master`)
2* for `src/ipc/libmultiprocess`: https://github.com/bitcoin-core/libmultiprocess (branch `master`)
3* for `src/leveldb`: https://github.com/bitcoin-core/leveldb-subtree (branch `bitcoin-fork`)
4* for `src/minisketch`: https://github.com/bitcoin-core/minisketch (branch `master`)
5* for `src/secp256k1`: https://github.com/bitcoin-core/secp256k1 (branch `master`)

maflcko commented at 12:28 pm on May 27, 2025:

thx, I’ll leave as-is for now to make it possible to review via --color-moved=dimmed-zebra. Seems better to be done as a repo-wide follow-up anyway, because this affects all docs.

l0rinc approved
l0rinc commented at 11:49 am on May 27, 2025: contributor

Concept ACK, left a consistency nit only
l0rinc commented at 12:29 pm on May 27, 2025: contributor

ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49

in test/lint/README.md:102 in fa2bf6bdb7 outdated

100+* for `src/ipc/libmultiprocess`: https://github.com/bitcoin-core/libmultiprocess (branch master)
101+* for `src/leveldb`: https://github.com/bitcoin-core/leveldb-subtree.git (branch bitcoin-fork)
102 * for `src/minisketch`: https://github.com/bitcoin-core/minisketch.git (branch master)
103+* for `src/secp256k1`: https://github.com/bitcoin-core/secp256k1.git (branch master)
104+
105+Keep this list in sync with `fn get_subtrees()` in the lint runner.

hebasto commented at 1:45 pm on May 27, 2025:

Maybe add a reverse reference to this list in test/lint/test_runner/src/main.rs?

hebasto approved
hebasto commented at 1:45 pm on May 27, 2025: member

ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49.
BrandonOdiwuor commented at 3:36 pm on May 27, 2025: contributor

ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49
test: Add missing ipc subtree to lint fa4b8b16c3
maflcko force-pushed on May 27, 2025
hebasto approved
hebasto commented at 4:51 pm on May 27, 2025: member

re-ACK fa4b8b16c37830bf7ee1419aae94e99f294f0e9f, only a comment has been addressed since my recent review.
DrahtBot requested review from BrandonOdiwuor on May 27, 2025
DrahtBot requested review from TheCharlatan on May 27, 2025
DrahtBot requested review from l0rinc on May 27, 2025
l0rinc commented at 4:52 pm on May 27, 2025: contributor

ACK fa4b8b16c37830bf7ee1419aae94e99f294f0e9f
BrandonOdiwuor commented at 6:11 pm on May 27, 2025: contributor

Re-ACK fa4b8b16c37830bf7ee1419aae94e99f294f0e9f
davidgumberg commented at 6:25 pm on May 27, 2025: contributor

ACK https://github.com/bitcoin/bitcoin/pull/32623/commits/fa4b8b16c37830bf7ee1419aae94e99f294f0e9f
achow101 commented at 7:42 pm on May 27, 2025: member

ACK fa4b8b16c37830bf7ee1419aae94e99f294f0e9f
achow101 merged this on May 27, 2025
achow101 closed this on May 27, 2025
maflcko deleted the branch on May 28, 2025

Contributors
maflcko DrahtBot TheCharlatan l0rinc hebasto BrandonOdiwuor davidgumberg achow101

Review Requested
l0rinc TheCharlatan

Labels
Tests