test: Add missing ipc subtree to lint #32623

1. 
   maflcko commented at 8:12 AM on May 27, 2025: member

   The subtree docs and lint checks list the subtrees in three places, making it hard to follow and update and easy to miss one.

   Fix all issues by including the missing one and removing the list in one place.

2. 
   DrahtBot commented at 8:12 AM on May 27, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32623.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, l0rinc, BrandonOdiwuor, davidgumberg, achow101
   Stale ACK	TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

3. DrahtBot added the label Tests on May 27, 2025
4. TheCharlatan approved
5. 
   TheCharlatan commented at 10:41 AM on May 27, 2025: contributor

   ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49

6. in test/lint/README.md:100 in fa2bf6bdb7 outdated

     98 |  * for `src/crc32c`: https://github.com/bitcoin-core/crc32c-subtree.git (branch bitcoin-fork)
     99 | +* for `src/crypto/ctaes`: https://github.com/bitcoin-core/ctaes.git (branch master)
    100 | +* for `src/ipc/libmultiprocess`: https://github.com/bitcoin-core/libmultiprocess (branch master)
    101 | +* for `src/leveldb`: https://github.com/bitcoin-core/leveldb-subtree.git (branch bitcoin-fork)
    102 |  * for `src/minisketch`: https://github.com/bitcoin-core/minisketch.git (branch master)
    103 | +* for `src/secp256k1`: https://github.com/bitcoin-core/secp256k1.git (branch master)
   

   ---

   ---

   

   l0rinc commented at 11:46 AM on May 27, 2025:

   visiting the links will automatically remove the .git suffixes (which was already missing from libmultiprocess):

   * for `src/crc32c`: https://github.com/bitcoin-core/crc32c-subtree (branch `bitcoin-fork`)
   * for `src/crypto/ctaes`: https://github.com/bitcoin-core/ctaes (branch `master`)
   * for `src/ipc/libmultiprocess`: https://github.com/bitcoin-core/libmultiprocess (branch `master`)
   * for `src/leveldb`: https://github.com/bitcoin-core/leveldb-subtree (branch `bitcoin-fork`)
   * for `src/minisketch`: https://github.com/bitcoin-core/minisketch (branch `master`)
   * for `src/secp256k1`: https://github.com/bitcoin-core/secp256k1 (branch `master`)
   

   ---

   

   maflcko commented at 12:28 PM on May 27, 2025:

   thx, I'll leave as-is for now to make it possible to review via --color-moved=dimmed-zebra. Seems better to be done as a repo-wide follow-up anyway, because this affects all docs.

7. l0rinc approved
8. 
   l0rinc commented at 11:49 AM on May 27, 2025: contributor

   Concept ACK, left a consistency nit only

9. 
   l0rinc commented at 12:29 PM on May 27, 2025: contributor

   ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49

10. in test/lint/README.md:102 in fa2bf6bdb7 outdated

     100 | +* for `src/ipc/libmultiprocess`: https://github.com/bitcoin-core/libmultiprocess (branch master)
     101 | +* for `src/leveldb`: https://github.com/bitcoin-core/leveldb-subtree.git (branch bitcoin-fork)
     102 |  * for `src/minisketch`: https://github.com/bitcoin-core/minisketch.git (branch master)
     103 | +* for `src/secp256k1`: https://github.com/bitcoin-core/secp256k1.git (branch master)
     104 | +
     105 | +Keep this list in sync with `fn get_subtrees()` in the lint runner.
    

    ---

    ---

    

    hebasto commented at 1:45 PM on May 27, 2025:

    Maybe add a reverse reference to this list in test/lint/test_runner/src/main.rs?

11. hebasto approved
12. 
    hebasto commented at 1:45 PM on May 27, 2025: member

    ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49.

13. 
    BrandonOdiwuor commented at 3:36 PM on May 27, 2025: contributor

    ACK fa2bf6bdb7e5f8940fe4bce1aaab29bf2e063b49

14. test: Add missing ipc subtree to lint fa4b8b16c3
15. maflcko force-pushed on May 27, 2025
16. hebasto approved
17. 
    hebasto commented at 4:51 PM on May 27, 2025: member

    re-ACK fa4b8b16c37830bf7ee1419aae94e99f294f0e9f, only a comment has been addressed since my recent review.

18. DrahtBot requested review from BrandonOdiwuor on May 27, 2025
19. DrahtBot requested review from TheCharlatan on May 27, 2025
20. DrahtBot requested review from l0rinc on May 27, 2025
21. 
    l0rinc commented at 4:52 PM on May 27, 2025: contributor

    ACK fa4b8b16c37830bf7ee1419aae94e99f294f0e9f

22. 
    BrandonOdiwuor commented at 6:11 PM on May 27, 2025: contributor

    Re-ACK fa4b8b16c37830bf7ee1419aae94e99f294f0e9f

23. 
    davidgumberg commented at 6:25 PM on May 27, 2025: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/32623/commits/fa4b8b16c37830bf7ee1419aae94e99f294f0e9f

24. 
    achow101 commented at 7:42 PM on May 27, 2025: member

    ACK fa4b8b16c37830bf7ee1419aae94e99f294f0e9f

25. achow101 merged this on May 27, 2025
26. achow101 closed this on May 27, 2025

    ---

27. maflcko deleted the branch on May 28, 2025

Contributors

maflckoDrahtBotTheCharlatanl0rinchebastoBrandonOdiwuordavidgumbergachow101

Review Requested
l0rincTheCharlatan