[28.x] 28.2rc2

fanquake commented at 1:52 pm on June 5, 2025: member

Backports #32568. Bumps to rc2. #32563 & #32639 haved landed since rc1.

depends: use "mkdir -p" when installing xproto

It looks like the mkdir detection in xproto is broken on Alpine. Ensure
we always use `mkdir -p`.

Fixes #32494.

Github-Pull: #32568
Rebased-From: df9ebbf659d5d1282289f36d7f9ee7103aa33a17

a6cbd33d1a

fanquake added this to the milestone 28.2 on Jun 5, 2025

DrahtBot commented at 1:52 pm on June 5, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32684.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	willcl-ark, glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

LLM Linter (✨ experimental)

Possible typos and grammar issues:

guix: accomodate migration → accommodate [spelling error]

drahtbot_id_4_m

DrahtBot added the label Backport on Jun 5, 2025

DrahtBot added the label CI failed on Jun 5, 2025

fanquake commented at 8:43 am on June 6, 2025: member

Guix Build:

 0be30f094366c71bd7251247319dbb0cf1b5674d13e210685328daff1bf855766  guix-build-3b05c498a08e/output/aarch64-linux-gnu/SHA256SUMS.part
 11823e9b3d7c97a533ab77540095223bc48759216b9e9fe757f24575f2323680f  guix-build-3b05c498a08e/output/aarch64-linux-gnu/bitcoin-3b05c498a08e-aarch64-linux-gnu-debug.tar.gz
 28fd4d3a844e845ae13a95d165ae2cd1fea735295c24bc68b3fd28cb91f59c397  guix-build-3b05c498a08e/output/aarch64-linux-gnu/bitcoin-3b05c498a08e-aarch64-linux-gnu.tar.gz
 3b86f8537ceb5f364d6be26a488dc21580697ecfb9d7cc7e1a9d691a611c57324  guix-build-3b05c498a08e/output/arm-linux-gnueabihf/SHA256SUMS.part
 4516a8e1220b18f656f5d1d946ab96f825556d83f32d1ce41fc3f483a246d918b  guix-build-3b05c498a08e/output/arm-linux-gnueabihf/bitcoin-3b05c498a08e-arm-linux-gnueabihf-debug.tar.gz
 56d211598a16829142b608f2b85d138c0346ae7057a21e834f7293f9d04d80dea  guix-build-3b05c498a08e/output/arm-linux-gnueabihf/bitcoin-3b05c498a08e-arm-linux-gnueabihf.tar.gz
 6d133dc0b3081a7048bcf6c7cd0d61333b2372f2763154887069b32ff8ac8ec13  guix-build-3b05c498a08e/output/arm64-apple-darwin/SHA256SUMS.part
 7863ac4e5fcb95766b81039cd85b2740791a3f65e4b6fd0d39fe57cb182e299aa  guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-codesigning.tar.gz
 8765aed969c45f09fc1df4ba3c802d137ad5776101833d63a0d4957ab0802c0b0  guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-unsigned.tar.gz
 947a51e1078002b929c3750cf7c292f576448a42c9fa096efdcb5722682c95f18  guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-unsigned.zip
103dd79826cbce2e43f1767c15b6b8ed529f0278f6ef721a11fd5e1bdd6aebe8b6  guix-build-3b05c498a08e/output/dist-archive/bitcoin-3b05c498a08e.tar.gz
11c4764be65da14dddd84eff11b014cb7d9e01ab8445bf2fe025615455a867aea6  guix-build-3b05c498a08e/output/powerpc64-linux-gnu/SHA256SUMS.part
124b10398475e242acb88b07f550d18e1c7201d6af277489cdd9d626bc966c505d  guix-build-3b05c498a08e/output/powerpc64-linux-gnu/bitcoin-3b05c498a08e-powerpc64-linux-gnu-debug.tar.gz
1367fa43a82454fe19048cff94f9b3a9fd875cace5081db517b623ee62d1625a61  guix-build-3b05c498a08e/output/powerpc64-linux-gnu/bitcoin-3b05c498a08e-powerpc64-linux-gnu.tar.gz
14df16a3f91cff89c05285d447687036847e5ddacde10fa1978f5e8fd0a05a0dc0  guix-build-3b05c498a08e/output/riscv64-linux-gnu/SHA256SUMS.part
1546a3159a395b460b969a34424534ecfe8d2124012c35b4eec41c5039f7729657  guix-build-3b05c498a08e/output/riscv64-linux-gnu/bitcoin-3b05c498a08e-riscv64-linux-gnu-debug.tar.gz
1630cad7f8bb940bc2553ab6b332eaa8fab5b0f58f0c08f03fa236cda7cc0f898e  guix-build-3b05c498a08e/output/riscv64-linux-gnu/bitcoin-3b05c498a08e-riscv64-linux-gnu.tar.gz
176e3329a9e7eb492d4e0af3a86b204da17cb2716c30aa56e6ee701e88d712fc78  guix-build-3b05c498a08e/output/x86_64-apple-darwin/SHA256SUMS.part
18e0a93c6aae317f108aee97aa5625eeb94513e03913a1adb80f64a1525c442398  guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-codesigning.tar.gz
198809523d83765ef203f20502c20abe2a0503ffee96f5d259ac938648f2e9006d  guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-unsigned.tar.gz
208a0408595e3f46fe07cfd8eaa7e90a58d508d8d4204eef3e8903e00c8fc757ca  guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-unsigned.zip
210633262002f982db8925af044457d3440b49b4462af29f1cc5766ce17f7160a6  guix-build-3b05c498a08e/output/x86_64-linux-gnu/SHA256SUMS.part
223369dbbe926b844a44e9629aed18f91ab9894b353be96bf861a5ffb56265f876  guix-build-3b05c498a08e/output/x86_64-linux-gnu/bitcoin-3b05c498a08e-x86_64-linux-gnu-debug.tar.gz
236beb32dd287210021a883112663d0298761ae9c2fb5ecec960debc3805893a4e  guix-build-3b05c498a08e/output/x86_64-linux-gnu/bitcoin-3b05c498a08e-x86_64-linux-gnu.tar.gz
241f5edb8d261c48722648f2df3c95ca687d08e6d3f15f2e5afa94f6e51406c104  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/SHA256SUMS.part
25b89a8df1360bed7aed3d41242b5ba205441df3e6c44c4d36902571372f290c8b  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-codesigning.tar.gz
26646855d3bff2b7b824d58dbdc5ec2981374641c9cdaacc7dce5a78babf99573b  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-debug.zip
27bf13ad6e60d699aa33cab7c9dad72a32edc60cb2c512393dd9dcfbe8d3a64fc8  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-setup-unsigned.exe
2874f0251c369e49162ddbf745df389ee50f70734bcdfb8a6ca5c38ae93acd4f48  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-unsigned.zip

willcl-ark approved

willcl-ark commented at 10:36 am on June 6, 2025: member

crACK 3b05c498a08e004a349e768c7bdbd09362673920

will kick off a guix build over lunch, but backport and version changes all appear correct

willcl-ark commented at 12:29 pm on June 6, 2025: member

 0❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1be30f094366c71bd7251247319dbb0cf1b5674d13e210685328daff1bf855766  guix-build-3b05c498a08e/output/aarch64-linux-gnu/SHA256SUMS.part
 21823e9b3d7c97a533ab77540095223bc48759216b9e9fe757f24575f2323680f  guix-build-3b05c498a08e/output/aarch64-linux-gnu/bitcoin-3b05c498a08e-aarch64-linux-gnu-debug.tar.gz
 38fd4d3a844e845ae13a95d165ae2cd1fea735295c24bc68b3fd28cb91f59c397  guix-build-3b05c498a08e/output/aarch64-linux-gnu/bitcoin-3b05c498a08e-aarch64-linux-gnu.tar.gz
 4b86f8537ceb5f364d6be26a488dc21580697ecfb9d7cc7e1a9d691a611c57324  guix-build-3b05c498a08e/output/arm-linux-gnueabihf/SHA256SUMS.part
 5516a8e1220b18f656f5d1d946ab96f825556d83f32d1ce41fc3f483a246d918b  guix-build-3b05c498a08e/output/arm-linux-gnueabihf/bitcoin-3b05c498a08e-arm-linux-gnueabihf-debug.tar.gz
 66d211598a16829142b608f2b85d138c0346ae7057a21e834f7293f9d04d80dea  guix-build-3b05c498a08e/output/arm-linux-gnueabihf/bitcoin-3b05c498a08e-arm-linux-gnueabihf.tar.gz
 7d133dc0b3081a7048bcf6c7cd0d61333b2372f2763154887069b32ff8ac8ec13  guix-build-3b05c498a08e/output/arm64-apple-darwin/SHA256SUMS.part
 8863ac4e5fcb95766b81039cd85b2740791a3f65e4b6fd0d39fe57cb182e299aa  guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-codesigning.tar.gz
 9765aed969c45f09fc1df4ba3c802d137ad5776101833d63a0d4957ab0802c0b0  guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-unsigned.tar.gz
1047a51e1078002b929c3750cf7c292f576448a42c9fa096efdcb5722682c95f18  guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-unsigned.zip
113dd79826cbce2e43f1767c15b6b8ed529f0278f6ef721a11fd5e1bdd6aebe8b6  guix-build-3b05c498a08e/output/dist-archive/bitcoin-3b05c498a08e.tar.gz
12c4764be65da14dddd84eff11b014cb7d9e01ab8445bf2fe025615455a867aea6  guix-build-3b05c498a08e/output/powerpc64-linux-gnu/SHA256SUMS.part
134b10398475e242acb88b07f550d18e1c7201d6af277489cdd9d626bc966c505d  guix-build-3b05c498a08e/output/powerpc64-linux-gnu/bitcoin-3b05c498a08e-powerpc64-linux-gnu-debug.tar.gz
1467fa43a82454fe19048cff94f9b3a9fd875cace5081db517b623ee62d1625a61  guix-build-3b05c498a08e/output/powerpc64-linux-gnu/bitcoin-3b05c498a08e-powerpc64-linux-gnu.tar.gz
15df16a3f91cff89c05285d447687036847e5ddacde10fa1978f5e8fd0a05a0dc0  guix-build-3b05c498a08e/output/riscv64-linux-gnu/SHA256SUMS.part
1646a3159a395b460b969a34424534ecfe8d2124012c35b4eec41c5039f7729657  guix-build-3b05c498a08e/output/riscv64-linux-gnu/bitcoin-3b05c498a08e-riscv64-linux-gnu-debug.tar.gz
1730cad7f8bb940bc2553ab6b332eaa8fab5b0f58f0c08f03fa236cda7cc0f898e  guix-build-3b05c498a08e/output/riscv64-linux-gnu/bitcoin-3b05c498a08e-riscv64-linux-gnu.tar.gz
186e3329a9e7eb492d4e0af3a86b204da17cb2716c30aa56e6ee701e88d712fc78  guix-build-3b05c498a08e/output/x86_64-apple-darwin/SHA256SUMS.part
19e0a93c6aae317f108aee97aa5625eeb94513e03913a1adb80f64a1525c442398  guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-codesigning.tar.gz
208809523d83765ef203f20502c20abe2a0503ffee96f5d259ac938648f2e9006d  guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-unsigned.tar.gz
218a0408595e3f46fe07cfd8eaa7e90a58d508d8d4204eef3e8903e00c8fc757ca  guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-unsigned.zip
220633262002f982db8925af044457d3440b49b4462af29f1cc5766ce17f7160a6  guix-build-3b05c498a08e/output/x86_64-linux-gnu/SHA256SUMS.part
233369dbbe926b844a44e9629aed18f91ab9894b353be96bf861a5ffb56265f876  guix-build-3b05c498a08e/output/x86_64-linux-gnu/bitcoin-3b05c498a08e-x86_64-linux-gnu-debug.tar.gz
246beb32dd287210021a883112663d0298761ae9c2fb5ecec960debc3805893a4e  guix-build-3b05c498a08e/output/x86_64-linux-gnu/bitcoin-3b05c498a08e-x86_64-linux-gnu.tar.gz
251f5edb8d261c48722648f2df3c95ca687d08e6d3f15f2e5afa94f6e51406c104  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/SHA256SUMS.part
26b89a8df1360bed7aed3d41242b5ba205441df3e6c44c4d36902571372f290c8b  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-codesigning.tar.gz
27646855d3bff2b7b824d58dbdc5ec2981374641c9cdaacc7dce5a78babf99573b  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-debug.zip
28bf13ad6e60d699aa33cab7c9dad72a32edc60cb2c512393dd9dcfbe8d3a64fc8  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-setup-unsigned.exe
2974f0251c369e49162ddbf745df389ee50f70734bcdfb8a6ca5c38ae93acd4f48  guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-unsigned.zip

in doc/release-notes.md:47 in 3b05c498a0 outdated

42@@ -43,6 +43,7 @@ Notable changes
43 - #31500 depends: Fix compiling libevent package on NetBSD
44 - #31627 depends: Fix spacing issue
45 - #32070 build: use make < 3.82 syntax for define directive
46+- #32568 depends: use "mkdir -p" when installing xproto

glozow commented at 6:46 pm on June 6, 2025:

Are we missing #32003 and #32439?

fanquake commented at 9:59 am on June 7, 2025:

Added.

doc: update release notes for rc2 b64faa54c2

build: bump version to 28.2rc2 c2b2942415

doc: update manual pages for 28.2rc2 fb62393277

fanquake force-pushed on Jun 7, 2025

willcl-ark approved

willcl-ark commented at 12:39 pm on June 7, 2025: member

ACK fb6239327700acc8b038d7d241c33439e3f6916e

via git range-diff 3b05c49...fb62393

glozow commented at 3:15 pm on June 9, 2025: member

ACK fb6239327700acc8b038d7d241c33439e3f6916e

glozow merged this on Jun 9, 2025

glozow closed this on Jun 9, 2025

fanquake deleted the branch on Jun 9, 2025

[28.x] 28.2rc2 #32684

Code Coverage & Benchmarks

Reviews

LLM Linter (✨ experimental)