doc, windows: CompanyName "Bitcoin" => "Bitcoin Core project"

hodlinator commented at 6:27 pm on June 10, 2025: contributor

Brings Windows executables in line with /share/setup.nsi.in:14 used by the installer.

Discovered while reviewing tangential PR: #32634 (review)

Matches /share/setup.nsi.in:14

239fc4d62e

DrahtBot commented at 6:27 pm on June 10, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32719.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko, Sjors, janb84, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hodlinator commented at 6:30 pm on June 10, 2025: contributor

Tooltip shown when hovering mouse cursor above bitcoin-qt.exe:

Before: Before

After: After

maflcko added the label Windows on Jun 11, 2025

maflcko added the label DrahtBot Guix build requested on Jun 11, 2025

maflcko commented at 7:24 am on June 11, 2025: member

Makes sense to have the same metadata for the installer and the executables.

lgtm ACK 239fc4d62e73511b3ef5117706d4c5131a921955

Sjors commented at 7:48 am on June 11, 2025: member

utACK 239fc4d62e73511b3ef5117706d4c5131a921955

janb84 commented at 8:25 am on June 11, 2025: contributor

utACK 239fc4d62e73511b3ef5117706d4c5131a921955

Not tested, did a code review. PR makes a (small) change to align the “company name”, in several RC files, to the name used in the installer. Imo this is a sensible change to keep those names aligned. ✅

hebasto approved

hebasto commented at 9:02 am on June 11, 2025: member

ACK 239fc4d62e73511b3ef5117706d4c5131a921955.

hebasto commented at 9:21 am on June 11, 2025: member

My Guix build:

0aarch64
1458b3244f108716a6439c79c99f50da02eeec8e980e995455727fc134630e471  guix-build-239fc4d62e73/output/dist-archive/bitcoin-239fc4d62e73.tar.gz
219e34684107ea85baf7949d341dda007849860ff4341bc5139c1dd61a37a9c48  guix-build-239fc4d62e73/output/x86_64-w64-mingw32/SHA256SUMS.part
34515f2169e10825fa02a34aebd7c928ff366ee2481b4332180cd410fe5e56031  guix-build-239fc4d62e73/output/x86_64-w64-mingw32/bitcoin-239fc4d62e73-win64-codesigning.tar.gz
420a47574d6875275812c08cbbe108696f8761e62ba04f19b011c892a78d4a61c  guix-build-239fc4d62e73/output/x86_64-w64-mingw32/bitcoin-239fc4d62e73-win64-debug.zip
54fd6f3b1e79d3aad6e4ac6feb4169aa84924bb02de8ec754f7fa7c689ab09b98  guix-build-239fc4d62e73/output/x86_64-w64-mingw32/bitcoin-239fc4d62e73-win64-setup-unsigned.exe
6781edc16d9974df92ff25ea23b6cf78abd6b0a2f1f7d11fa12f3ad96810d042a  guix-build-239fc4d62e73/output/x86_64-w64-mingw32/bitcoin-239fc4d62e73-win64-unsigned.zip

hebasto merged this on Jun 11, 2025

hebasto closed this on Jun 11, 2025

maflcko removed the label DrahtBot Guix build requested on Jun 11, 2025

fanquake referenced this in commit c04b16d797 on Jun 11, 2025

fanquake commented at 4:26 pm on June 11, 2025: member

Backported to 29.x in #32589.

DrahtBot commented at 6:38 pm on June 11, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 4b8ac9eacd1b20686b84895560982eb742be894e(master)	commit b7689e07a35ef8ff6ebb9f8bf90339f45b9e2fc5(pull/32719/merge)
*-aarch64-linux-gnu-debug.tar.gz	`95843d791689a0d6...`	`6640674e73a619bb...`
*-aarch64-linux-gnu.tar.gz	`5902b6b4f6e8acb5...`	`bf7ace6eb4aeb23d...`
*-arm-linux-gnueabihf-debug.tar.gz	`ae866e8a69a6a131...`	`2a8b58a16e39f46b...`
*-arm-linux-gnueabihf.tar.gz	`d0ad05f39e0f3961...`	`d3b469d10bcac3a9...`
*-arm64-apple-darwin-codesigning.tar.gz	`bff03356722dedf7...`	`0e0f416c4968f747...`
*-arm64-apple-darwin-unsigned.tar.gz	`35903897cc214374...`	`9dcd40bf5f43abfb...`
*-arm64-apple-darwin-unsigned.zip	`184d537bbed13561...`	`6b69ac29cfdcd478...`
*-powerpc64-linux-gnu-debug.tar.gz	`7a8eaa57cfa61411...`	`80a4e9c6b2a28550...`
*-powerpc64-linux-gnu.tar.gz	`4d82633d664ec7e5...`	`1274f3a59229c887...`
*-riscv64-linux-gnu-debug.tar.gz	`d60a68e9bbdca8e1...`	`454dfe3adb75fd4c...`
*-riscv64-linux-gnu.tar.gz	`428d2aabf5bb0127...`	`4111d9715884d984...`
*-x86_64-apple-darwin-codesigning.tar.gz	`12bdcf4eab32ebab...`	`49998fac5a57b532...`
*-x86_64-apple-darwin-unsigned.tar.gz	`c3c1757df2637822...`	`04efb1fa9fed635e...`
*-x86_64-apple-darwin-unsigned.zip	`b9babe4d47e333a9...`	`5e9b9fd36264be32...`
*-x86_64-linux-gnu-debug.tar.gz	`16ee30da81277705...`	`29f926a9cdc68aec...`
*-x86_64-linux-gnu.tar.gz	`65cd1bf1fc356db2...`	`f7ad3e7a8a5febb4...`
*.tar.gz	`2ae252bdf1632a85...`	`57bdb8549739b81f...`
SHA256SUMS.part	`028db81f12d961c7...`	`7cd6dcc2c53e1a11...`
guix_build.log	`bec9fa8833ef378d...`	`57f0866619e770ef...`
guix_build.log.diff		`fb02fb170dd049f6...`

hodlinator deleted the branch on Jun 12, 2025

doc, windows: CompanyName “Bitcoin” => “Bitcoin Core project” #32719

Code Coverage & Benchmarks

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]