depends: capnp 1.2.0 #32760

1. 
   fanquake commented at 10:03 am on June 16, 2025: member

   See https://github.com/capnproto/capnproto/compare/release-1.1.0...release-1.2.0. We can drop all the patches we are currently applying.
2. depends: capnp 1.2.0 c7eaac326a
3. 
   DrahtBot commented at 10:03 am on June 16, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32760.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theStack, ryanofsky, Sjors
   Concept ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Build system on Jun 16, 2025
5. 
   hebasto commented at 10:17 am on June 16, 2025: member

   Concept ACK.
6. 
   hebasto commented at 10:36 am on June 16, 2025: member

   OpenBSD build looks fine.
7. theStack approved
8. 
   theStack commented at 12:36 pm on June 16, 2025: contributor

   ACK c7eaac326ac20a745d1bc6dbc6bc48c1b5eb46f8

   Verified that the removed patches are contained in the 1.2.0 release and did a MULTIPROCESS=1 depends build locally on OpenBSD 7.7 (amd64).

9. DrahtBot requested review from hebasto on Jun 16, 2025
10. 
    ryanofsky commented at 1:14 pm on June 16, 2025: contributor

    Started reviewing this and ran into something strange. For me the download URL https://capnproto.org/capnproto-c++-1.2.0.tar.gz returns a 404, but adding an extra slash works https://capnproto.org//capnproto-c++-1.2.0.tar.gz. It seems like depends build does add the extra slash so does not have a problem (testing with make MULTIPROCESS=1 V=1 capnp_fetched). Same problem does not affect https://capnproto.org/capnproto-c++-1.1.0.tar.gz
11. ryanofsky approved
12. 
    ryanofsky commented at 1:35 pm on June 16, 2025: contributor

    Code review ACK c7eaac326ac20a745d1bc6dbc6bc48c1b5eb46f8. Just checked hashes, compared tarball to git and diffed 1.1.0 and 1.2.0 tarballs which showed only minor and expected changes.
13. 
    Sjors commented at 2:46 pm on June 16, 2025: member

    ACK c7eaac326ac20a745d1bc6dbc6bc48c1b5eb46f8

    Tested on top of #31802 (comment) including with OpenBSD. Also tested a depends build on macOS 13.7.6 (M4) with https://github.com/Sjors/bitcoin/pull/48 by mining a (SRI signet) block.

    Dropping our patches is nice. But otherwise I didn’t review the upstream changes.

14. ryanofsky assigned ryanofsky on Jun 16, 2025
15. ryanofsky merged this on Jun 16, 2025
16. ryanofsky closed this on Jun 16, 2025

    ---

17. fanquake deleted the branch on Jun 16, 2025
18. 
    fanquake commented at 9:44 am on June 19, 2025: member

    Backported to 29.x in #32589.
19. fanquake referenced this in commit ef6111bd18 on Jun 19, 2025

Contributors
fanquake DrahtBot hebasto theStack ryanofsky Sjors

Review Requested
hebasto

Labels
Build system