depends: capnp 1.2.0 #32760

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:capnp_1_2_0 changing 5 files +2 −227

fanquake commented at 10:03 AM on June 16, 2025: member

See https://github.com/capnproto/capnproto/compare/release-1.1.0...release-1.2.0. We can drop all the patches we are currently applying.
depends: capnp 1.2.0 c7eaac326a
DrahtBot commented at 10:03 AM on June 16, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32760.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK theStack, ryanofsky, Sjors

Concept ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Build system on Jun 16, 2025
hebasto commented at 10:17 AM on June 16, 2025: member

Concept ACK.
hebasto commented at 10:36 AM on June 16, 2025: member

OpenBSD build looks fine.
theStack approved
theStack commented at 12:36 PM on June 16, 2025: contributor

ACK c7eaac326ac20a745d1bc6dbc6bc48c1b5eb46f8

Verified that the removed patches are contained in the 1.2.0 release and did a MULTIPROCESS=1 depends build locally on OpenBSD 7.7 (amd64).
DrahtBot requested review from hebasto on Jun 16, 2025
ryanofsky commented at 1:14 PM on June 16, 2025: contributor

Started reviewing this and ran into something strange. For me the download URL https://capnproto.org/capnproto-c++-1.2.0.tar.gz returns a 404, but adding an extra slash works https://capnproto.org//capnproto-c++-1.2.0.tar.gz. It seems like depends build does add the extra slash so does not have a problem (testing with make MULTIPROCESS=1 V=1 capnp_fetched). Same problem does not affect https://capnproto.org/capnproto-c++-1.1.0.tar.gz
ryanofsky approved
ryanofsky commented at 1:35 PM on June 16, 2025: contributor

Code review ACK c7eaac326ac20a745d1bc6dbc6bc48c1b5eb46f8. Just checked hashes, compared tarball to git and diffed 1.1.0 and 1.2.0 tarballs which showed only minor and expected changes.
Sjors commented at 2:46 PM on June 16, 2025: member

ACK c7eaac326ac20a745d1bc6dbc6bc48c1b5eb46f8

Tested on top of #31802 (comment) including with OpenBSD. Also tested a depends build on macOS 13.7.6 (M4) with https://github.com/Sjors/bitcoin/pull/48 by mining a (SRI signet) block.

Dropping our patches is nice. But otherwise I didn't review the upstream changes.
ryanofsky assigned ryanofsky on Jun 16, 2025
ryanofsky merged this on Jun 16, 2025
ryanofsky closed this on Jun 16, 2025
fanquake deleted the branch on Jun 16, 2025
fanquake commented at 9:44 AM on June 19, 2025: member

Backported to 29.x in #32589.
fanquake referenced this in commit ef6111bd18 on Jun 19, 2025