refactor: modernize deprecated ipc headers #32781

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2024/06/tidy changing 3 files +5 −5
  1. Sjors commented at 2:31 pm on June 19, 2025: member

    Split off from #31802.

    Pre-empt tidy warning when multiprocess is on by default:

    0[10:33:51.654] /ci_container_base/src/ipc/capnp/protocol.cpp:20:10: error: inclusion of deprecated C++ header 'errno.h'; consider using 'cerrno' instead [modernize-deprecated-headers,-warnings-as-errors]
    1[10:33:51.654]    20 | #include <errno.h>
    2[10:33:51.654]       |          ^~~~~~~~~
    3[10:33:51.654]       |          <cerrno>
    4[10:33:51.654] 919 warnings generated.
    

    https://github.com/bitcoin/bitcoin/pull/31802/checks?check_run_id=43968493627

  2. refactor: modernize deprecated ipc headers
    Co-authored-by: fanquake <fanquake@gmail.com>
    74b7e9c7db
  3. DrahtBot added the label Refactoring on Jun 19, 2025
  4. DrahtBot commented at 2:31 pm on June 19, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32781.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, ryanofsky
    Concept ACK enirox001

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. maflcko commented at 2:38 pm on June 19, 2025: member
    lgtm ACK 74b7e9c7dbf73b6df84ba8a1f40dd22924a604ef
  6. enirox001 commented at 9:05 am on June 20, 2025: contributor

    Looks good to me

    ACK

  7. ryanofsky approved
  8. ryanofsky commented at 3:32 pm on June 20, 2025: contributor
    Code review ACK 74b7e9c7dbf73b6df84ba8a1f40dd22924a604ef
  9. fanquake merged this on Jun 23, 2025
  10. fanquake closed this on Jun 23, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-08 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me