refactor: modernize deprecated ipc headers #32781

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2024/06/tidy changing 3 files +5 −5
  1. Sjors commented at 2:31 PM on June 19, 2025: member

    Split off from #31802.

    Pre-empt tidy warning when multiprocess is on by default:

    [10:33:51.654] /ci_container_base/src/ipc/capnp/protocol.cpp:20:10: error: inclusion of deprecated C++ header 'errno.h'; consider using 'cerrno' instead [modernize-deprecated-headers,-warnings-as-errors]
    [10:33:51.654]    20 | #include <errno.h>
    [10:33:51.654]       |          ^~~~~~~~~
    [10:33:51.654]       |          <cerrno>
    [10:33:51.654] 919 warnings generated.
    

    https://github.com/bitcoin/bitcoin/pull/31802/checks?check_run_id=43968493627

  2. refactor: modernize deprecated ipc headers
    Co-authored-by: fanquake <fanquake@gmail.com>
    74b7e9c7db
  3. DrahtBot added the label Refactoring on Jun 19, 2025
  4. DrahtBot commented at 2:31 PM on June 19, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32781.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, ryanofsky
    Concept ACK enirox001

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko commented at 2:38 PM on June 19, 2025: member

    lgtm ACK 74b7e9c7dbf73b6df84ba8a1f40dd22924a604ef

  6. enirox001 commented at 9:05 AM on June 20, 2025: contributor

    Looks good to me

    ACK

  7. ryanofsky approved
  8. ryanofsky commented at 3:32 PM on June 20, 2025: contributor

    Code review ACK 74b7e9c7dbf73b6df84ba8a1f40dd22924a604ef

  9. fanquake merged this on Jun 23, 2025
  10. fanquake closed this on Jun 23, 2025

  11. stringintech referenced this in commit f19e7819e9 on Jul 19, 2025
  12. alexanderwiederin referenced this in commit 9997c3d993 on Jul 25, 2025
  13. alexanderwiederin referenced this in commit 8d6ebb9c4e on Jul 28, 2025
  14. alexanderwiederin referenced this in commit 533a4585b5 on Jul 28, 2025
  15. yuvicc referenced this in commit 22f55cf11d on Aug 26, 2025
  16. bug-castercv502 referenced this in commit d4bd8a1259 on Sep 28, 2025
  17. stickies-v referenced this in commit a19c56cd7c on Nov 4, 2025
  18. Kino1994 referenced this in commit b9122b1095 on Jun 28, 2026
  19. BigcoinBGC referenced this in commit 070091809d on Jun 30, 2026
  20. bitcoin locked this on Jul 30, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-11 10:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me