cmake: Fix regression in `secp256k1.cmake` #33379

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250912-kernel-ipo changing 1 files +2 −1
  1. hebasto commented at 5:00 PM on September 12, 2025: member

    This PR fixes a regression introduced in #33101 (mea culpa).

    From the CMake docs:

    The following restrictions apply to where enable_language() may be called:

    • It must be called in file scope, not in a function call.

    Fixes #33153.

  2. cmake: Fix regression in `secp256k1.cmake`
    The `enable_language` command must be called in file scope, not in a
    function call.
    
    See: https://cmake.org/cmake/help/latest/command/enable_language.html
    9193c3e434
  3. hebasto added this to the milestone 30.0 on Sep 12, 2025
  4. hebasto added the label Build system on Sep 12, 2025
  5. DrahtBot commented at 5:00 PM on September 12, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33379.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan, furszy

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. sedited approved
  7. sedited commented at 6:39 PM on September 12, 2025: contributor

    ACK 9193c3e4340bb5b49af2ab04bce335876e7b1076

  8. furszy commented at 6:49 PM on September 12, 2025: member

    ACK 9193c3e4340bb5b49af2ab04bce335876e7b1076

  9. fanquake merged this on Sep 15, 2025
  10. fanquake closed this on Sep 15, 2025

  11. fanquake referenced this in commit 0a2afbeb77 on Sep 15, 2025
  12. fanquake commented at 8:53 AM on September 15, 2025: member

    Backported to 30.x in #33356.

  13. hebasto deleted the branch on Sep 15, 2025
  14. glozow referenced this in commit b7a722724d on Sep 17, 2025
  15. sedited referenced this in commit 3f14dd4b2a on Oct 7, 2025
  16. sedited referenced this in commit 5f9d179b8d on Oct 8, 2025
  17. sedited referenced this in commit 845b93d99e on Oct 8, 2025
  18. yuvicc referenced this in commit ccce70c31a on Oct 8, 2025
  19. sedited referenced this in commit 3b1e26d5d3 on Oct 10, 2025
  20. sedited referenced this in commit 0fa2fdaca0 on Oct 11, 2025
  21. stringintech referenced this in commit f74b275ffc on Oct 14, 2025
  22. stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
  23. morozow referenced this in commit 393b45da37 on May 8, 2026
  24. morozow referenced this in commit 48f5d00b2b on May 8, 2026
  25. Kino1994 referenced this in commit 00bf4b79ac on Jun 28, 2026
  26. BigcoinBGC referenced this in commit aee801df33 on Jun 30, 2026
  27. Kino1994 referenced this in commit 3769638e13 on Aug 19, 2026
  28. bitcoin locked this on Sep 15, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-28 20:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me