ci: return to using dash in CentOS job #33261

1. 
   fanquake commented at 10:11 am on August 27, 2025: member

   dash is available again: https://bugzilla.redhat.com/show_bug.cgi?id=2335416.
2. DrahtBot added the label Tests on Aug 27, 2025
3. 
   DrahtBot commented at 10:11 am on August 27, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33261.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, janb84, davidgumberg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. in .cirrus.yml:128 in 9124611736 outdated

   124@@ -125,7 +125,7 @@ task:
   125     FILE_ENV: "./ci/test/00_setup_env_arm.sh"
   126 
   127 task:
   128-  name: 'CentOS, depends, gui'
   129+  name: 'CentOS, dash, depends, gui'
   

   ---

   ---

   

   maflcko commented at 10:51 am on August 27, 2025:

   nit: No need to advertise it here. This will only create a conflict with the GHA rewrite?
5. in ci/test/00_setup_env_native_centos.sh:11 in 9124611736 outdated

    7@@ -8,7 +8,7 @@ export LC_ALL=C.UTF-8
    8 
    9 export CONTAINER_NAME=ci_native_centos
   10 export CI_IMAGE_NAME_TAG="quay.io/centos/centos:stream10"
   11-export CI_BASE_PACKAGES="gcc-c++ glibc-devel libstdc++-devel ccache make ninja-build git python3 python3-pip which patch xz procps-ng ksh rsync coreutils bison e2fsprogs cmake"
   12+export CI_BASE_PACKAGES="gcc-c++ glibc-devel libstdc++-devel ccache make ninja-build git python3 python3-pip which patch xz procps-ng ksh rsync coreutils bison e2fsprogs cmake dash"
   

   ---

   ---

   

   maflcko commented at 10:51 am on August 27, 2025:

   nit: remove ksh?
6. maflcko approved
7. 
   maflcko commented at 10:52 am on August 27, 2025: member

   lgtm. Either shell should be fine here, for the purpose to test a non-bash shell.
8. ci: return to using dash in CentOS job 509ffea40a
9. fanquake force-pushed on Aug 27, 2025
10. 
    maflcko commented at 11:31 am on August 27, 2025: member

    lgtm ACK 509ffea40abbc706ef8b8fc449b7de8677fc5096
11. 
    janb84 commented at 2:24 pm on August 27, 2025: contributor

    crACK 509ffea40abbc706ef8b8fc449b7de8677fc5096

    PR Partially reverts faaabfaea768deb7767c489d32fd2097fd180872 because https://bugzilla.redhat.com/show_bug.cgi?id=2335416 is fixed.

    • code-review ✅
    • history-review ✅
12. 
    davidgumberg commented at 10:37 pm on August 27, 2025: contributor

    ACK https://github.com/bitcoin/bitcoin/commit/509ffea40abbc706ef8b8fc449b7de8677fc5096
13. fanquake merged this on Aug 28, 2025
14. fanquake closed this on Aug 28, 2025

    ---

15. fanquake deleted the branch on Aug 28, 2025

Contributors
fanquake DrahtBot maflcko janb84 davidgumberg

Labels
Tests