ci: return to using dash in CentOS job #33261

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:centos_restore_dash changing 2 files +2 −2

fanquake commented at 10:11 AM on August 27, 2025: member

dash is available again: https://bugzilla.redhat.com/show_bug.cgi?id=2335416.
DrahtBot added the label Tests on Aug 27, 2025
DrahtBot commented at 10:11 AM on August 27, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33261.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, janb84, davidgumberg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Type	Reviewers
ACK	maflcko, janb84, davidgumberg

in .cirrus.yml:128 in 9124611736 outdated

 124 | @@ -125,7 +125,7 @@ task:
 125 |      FILE_ENV: "./ci/test/00_setup_env_arm.sh"
 126 |  
 127 |  task:
 128 | -  name: 'CentOS, depends, gui'
 129 | +  name: 'CentOS, dash, depends, gui'

maflcko commented at 10:51 AM on August 27, 2025:

nit: No need to advertise it here. This will only create a conflict with the GHA rewrite?

in ci/test/00_setup_env_native_centos.sh:11 in 9124611736 outdated

   7 | @@ -8,7 +8,7 @@ export LC_ALL=C.UTF-8
   8 |  
   9 |  export CONTAINER_NAME=ci_native_centos
  10 |  export CI_IMAGE_NAME_TAG="quay.io/centos/centos:stream10"
  11 | -export CI_BASE_PACKAGES="gcc-c++ glibc-devel libstdc++-devel ccache make ninja-build git python3 python3-pip which patch xz procps-ng ksh rsync coreutils bison e2fsprogs cmake"
  12 | +export CI_BASE_PACKAGES="gcc-c++ glibc-devel libstdc++-devel ccache make ninja-build git python3 python3-pip which patch xz procps-ng ksh rsync coreutils bison e2fsprogs cmake dash"

maflcko commented at 10:51 AM on August 27, 2025:

nit: remove ksh?

maflcko approved
maflcko commented at 10:52 AM on August 27, 2025: member

lgtm. Either shell should be fine here, for the purpose to test a non-bash shell.
ci: return to using dash in CentOS job 509ffea40a
fanquake force-pushed on Aug 27, 2025
maflcko commented at 11:31 AM on August 27, 2025: member

lgtm ACK 509ffea40abbc706ef8b8fc449b7de8677fc5096
janb84 commented at 2:24 PM on August 27, 2025: contributor
crACK 509ffea40abbc706ef8b8fc449b7de8677fc5096

PR Partially reverts faaabfaea768deb7767c489d32fd2097fd180872 because https://bugzilla.redhat.com/show_bug.cgi?id=2335416 is fixed.
- code-review ✅
- history-review ✅
davidgumberg commented at 10:37 PM on August 27, 2025: contributor

ACK https://github.com/bitcoin/bitcoin/commit/509ffea40abbc706ef8b8fc449b7de8677fc5096
fanquake merged this on Aug 28, 2025
fanquake closed this on Aug 28, 2025
fanquake deleted the branch on Aug 28, 2025
fanquake referenced this in commit 99ab2e70e7 on Sep 3, 2025
glozow referenced this in commit fd784f2774 on Sep 3, 2025
ajtowns referenced this in commit a61b4e06a9 on Sep 4, 2025
alexanderwiederin referenced this in commit 49e068b15b on Sep 16, 2025
alexanderwiederin referenced this in commit 4b0c2f2a8f on Sep 17, 2025
alexanderwiederin referenced this in commit 2edb618ffe on Sep 17, 2025
stringintech referenced this in commit fb8510ba20 on Sep 17, 2025
bug-castercv502 referenced this in commit 9f5d12d027 on Sep 28, 2025
yuvicc referenced this in commit d89c6d0002 on Sep 28, 2025
stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
morozow referenced this in commit d7220cc131 on May 8, 2026
morozow referenced this in commit 76c99ef843 on May 8, 2026
Kino1994 referenced this in commit 813eccc13b on Jun 28, 2026
BigcoinBGC referenced this in commit 5e762643f6 on Jun 30, 2026
Kino1994 referenced this in commit b7c315533f on Aug 19, 2026
bitcoin locked this on Aug 28, 2026

Contributors

Labels

Linked (view graph)

#33271 [29.x] finalise v29.1

ci: return to using dash in CentOS job #33261

Code Coverage & Benchmarks

Reviews