[29.x] finalise v29.1 #33271

1. 
   fanquake commented at 3:34 PM on August 29, 2025: member

   Backports:

   • #33236
   • #33261

   Since rc2, #33212 was also backported in #33251.

2. doc: Remove wrong and redundant doxygen tag

   Remove it in feerate.
   
   Fix it in the other places.
   
   Github-Pull: #33236
   Rebased-From: 966666de9a6211b8748f43d682490c924e132e58

   6448ebb5a7
3. fanquake added this to the milestone 29.1 on Aug 29, 2025
4. DrahtBot added the label Backport on Aug 29, 2025
5. 
   DrahtBot commented at 3:34 PM on August 29, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33271.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	glozow, willcl-ark

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

6. ci: return to using dash in CentOS job

   Github-Pull: #33261
   Rebased-From: 509ffea40abbc706ef8b8fc449b7de8677fc5096

   99ab2e70e7
7. doc: finalise release notes for 29.1 b0d88bcc50
8. build: bump version to v29.1 final 37d115c67e
9. doc: update manual pages for v29.1 084c95a18c
10. fanquake renamed this:
    [29.x] rc3 or final
    [29.x] finalise v29.1
    on Sep 3, 2025
11. fanquake force-pushed on Sep 3, 2025
12. fanquake marked this as ready for review on Sep 3, 2025
13. 
    glozow commented at 2:11 PM on September 3, 2025: contributor

    ACK 084c95a18c9978c0a047ffe219a9eef8ab327ea6

14. willcl-ark approved
15. 
    willcl-ark commented at 2:14 PM on September 3, 2025: member

    ACK 084c95a18c9978c0a047ffe219a9eef8ab327ea6

    This all looks correct to me

16. in doc/release-notes.md:1 in 084c95a18c

    ---

    ---

    

    stickies-v commented at 2:47 PM on September 3, 2025:

    nit: it seems we don't have consistent manner of labeling GUI PRs, with a quick grep showing existing approaches like:

    • #<gui-pr>
    • gui#<gui-pr>
    • #gui<gui-pr>
    • bitcoin-core/gui#<gui-pr>

    No strong view, but perhaps using gui#<gui-pr> here would make sense, since it probably confuses people not familiar with our dual-repo setup:

    ### Gui
    
    - gui#864 Crash fix, disconnect numBlocksChanged() signal during shutdown
    - gui#868 Replace stray tfm::format to cerr with qWarning
    

17. glozow merged this on Sep 3, 2025
18. glozow closed this on Sep 3, 2025

    ---

19. stickies-v approved
20. 
    stickies-v commented at 2:57 PM on September 3, 2025: contributor

    ACK 084c95a18c9978c0a047ffe219a9eef8ab327ea6

    Backport commits aren't clean, but the changes lgtm:

    • 6448ebb5a7c942949a70ffc4a1d2a93338fac130 backported from 966666de9a6211b8748f43d682490c924e132e58: merge-conflict because d3b8a54a81209420ef6447dd4581e1b6b8550647 changed the CFeeRate docstring
    • 99ab2e70e782bf5ca753ad636f69642da6054283 backported from 509ffea40abbc706ef8b8fc449b7de8677fc5096: merge-conflict because of the added ninja-build from 30dd1f1644e0441b5310f1eceecfd6a5abc45f68

    Verified that all backported PRs are listed in release notes (unless they are missing the Github-Pull comment) (except #33011 and #33211 but those are follow-ups to #32604, which is mentioned).

    Verified that I have identical manpages.

21. fanquake deleted the branch on Sep 3, 2025
22. 
    Ystel2001 commented at 5:53 PM on October 7, 2025: none

    SSH

23. morozow referenced this in commit 76c99ef843 on May 8, 2026
24. ivanlele referenced this in commit bf5638cb8c on Jul 14, 2026
25. bitcoin locked this on Oct 7, 2026

Milestone
29.1