Fix benchmark CSV output #33340

1. 
   hebasto commented at 11:14 am on September 8, 2025: member

   The SHA256AutoDetect return output is used, among other use cases, to name benchmarks. Using a comma breaks the bench_bitcoin CSV output.

   This PR replaces the comma with a semicolon, which fixes #33331.

2. 
   DrahtBot commented at 11:14 am on September 8, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33340.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	l0rinc, janb84, Raimo33

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. in src/crypto/sha256.cpp:628 in aed00d901d outdated

   624@@ -625,7 +625,7 @@ std::string SHA256AutoDetect(sha256_implementation::UseImplementation use_implem
   625         Transform = sha256_x86_shani::Transform;
   626         TransformD64 = TransformD64Wrapper<sha256_x86_shani::Transform>;
   627         TransformD64_2way = sha256d64_x86_shani::Transform_2way;
   628-        ret = "x86_shani(1way,2way)";
   629+        ret = "x86_shani(1way;2way)";
   

   ---

   ---

   

   l0rinc commented at 5:29 pm on September 8, 2025:

   We should likely update the arm version as well:

   • https://github.com/bitcoin/bitcoin/blob/36e40417de3fcaa776fb7bb8ebf3a23db4266572/src/crypto/sha256.cpp#L683

   ---

   

   hebasto commented at 5:40 pm on September 8, 2025:

   Thanks! Fixed.
4. l0rinc changes_requested
5. Fix benchmark CSV output

   The `SHA256AutoDetect` return output is used, among other use cases, to
   name benchmarks. Using a comma breaks the CSV output.
   
   This change replaces the comma with a semicolon, which fixes the issue.

   790b440197
6. hebasto force-pushed on Sep 8, 2025
7. l0rinc approved
8. 
   l0rinc commented at 5:41 pm on September 8, 2025: contributor

   Code review ACK 790b440197bde322432a5bab161f1869b667e681
9. 
   janb84 commented at 6:33 pm on September 8, 2025: contributor

   code review ACK 790b440197bde322432a5bab161f1869b667e681

   PR changes the comma’s from the static text in the SHA256AutoDetect return output to semicolons so that it will not interfere with Comma-Separated Values (CSV) output.

10. 
    Raimo33 commented at 8:13 pm on September 8, 2025: none

    Code Review ACK 790b440197bde322432a5bab161f1869b667e681
11. fanquake merged this on Sep 9, 2025
12. fanquake closed this on Sep 9, 2025

    ---

13. fanquake referenced this in commit 2717331981 on Sep 9, 2025
14. hebasto deleted the branch on Sep 9, 2025

Contributors
hebasto DrahtBot l0rinc janb84 Raimo33