[29.x] Backports #33344

1. 
   fanquake commented at 9:19 am on September 9, 2025: member

   Backports:

   • #32646
   • #33296
   • #33310
   • #33340
   • #33364
   • #33395

   Plus changes for 29.2rc1.

2. Fix benchmark CSV output

   The `SHA256AutoDetect` return output is used, among other use cases, to
   name benchmarks. Using a comma breaks the CSV output.
   
   This change replaces the comma with a semicolon, which fixes the issue.
   
   Github-Pull: #33340
   Rebased-From: 790b440197bde322432a5bab161f1869b667e681

   2717331981
3. fanquake added this to the milestone 29.2 on Sep 9, 2025
4. DrahtBot added the label Backport on Sep 9, 2025
5. 
   DrahtBot commented at 9:19 am on September 9, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33344.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	darosior, mzumsande

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

6. DrahtBot added the label CI failed on Sep 9, 2025
7. DrahtBot removed the label CI failed on Sep 10, 2025
8. ci: always use tag for LLVM checkout

   Rather than trying to match the apt installed clang version, which is
   prone to intermittent issues. i.e #33345.
   
   Github-Pull: #33364
   Rebased-From: b736052e39f1f466f63f261ace3dd2deba171e8a

   324caa8497
9. fanquake force-pushed on Sep 12, 2025
10. trace: Workaround GCC bug compiling with old systemtap

    Github-Pull: #33310
    Rebased-From: 93a29ff2830162c8129d35c7b9beb43fab984503

    e97588fc3d
11. fanquake force-pushed on Sep 12, 2025
12. p2p: Add witness mutation check inside FillBlock

    Since #29412, we have not allowed mutated blocks to continue
    being processed immediately the block is received, but this
    is only done for the legacy BLOCK message.
    
    Extend these checks as belt-and-suspenders to not allow
    similar mutation strategies to affect relay by honest peers
    by applying the check inside
    PartiallyDownloadedBlock::FillBlock, immediately before
    returning READ_STATUS_OK.
    
    This also removes the extraneous CheckBlock call.
    
    Github-Pull: #32646
    Rebased-From: bac9ee4830664c86c1cb3d38a5b19c722aae2f54

    9b95ab5e9d
13. p2p: remove vestigial READ_STATUS_CHECKBLOCK_FAILED

    Github-Pull: #32646
    Rebased-From: 28299ce77636d7563ec545d043cf1b61bd2f01c1

    4c940d4789
14. net: check for empty header before calling FillBlock

    Previously in debug builds, this would cause an Assume crash if
    FillBlock had been called previously. This could happen when multiple
    blocktxn messages were received.
    
    Co-Authored-By: Greg Sanders <gsanders87@gmail.com>
    
    Github-Pull: #33296
    Rebased-From: 5e585a0fc4fd68dd7b4982054b34deae2e7aeb89

    569ceb0df4
15. test: send duplicate blocktxn message in p2p_compactblocks.py

    Add test_multiple_blocktxn_response that checks that the peer is
    disconnected.
    
    Github-Pull: #33296
    Rebased-From: 8b6264768030db1840041abeeaeefd6c227a2644

    1288d44804
16. fanquake force-pushed on Sep 12, 2025
17. 
    instagibbs commented at 2:56 pm on September 12, 2025: member

    #32646 and #33296 backports look correct
18. 
    Crypt-iQ commented at 3:58 pm on September 12, 2025: contributor

    Checked that #32646 and #33296 backports are correct and ran p2p_compactblocks.py just to be sure.
19. net: Do not apply whitelist permission to onion inbounds

    Tor inbound connections do not reveal the peer's actual network address.
    Therefore do not apply whitelist permissions to them.
    
    Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
    
    Github-Pull: #33395
    Rebased-From: f563ce90818d486d2a199439d2f6ba39cd106352

    61cdc04a83
20. fanquake force-pushed on Sep 17, 2025
21. fanquake force-pushed on Sep 17, 2025
22. fanquake marked this as ready for review on Sep 17, 2025
23. doc: update release notes for 29.x 9bc4afb62c
24. build: bump version to v29.2rc1 461dd13faf
25. doc: update manual pages for v29.2rc1 f2bd79f80c
26. fanquake force-pushed on Sep 17, 2025
27. darosior approved
28. 
    darosior commented at 5:21 pm on September 17, 2025: member

    utACK f2bd79f80c74a2b77f14954ac65679417697a332
29. 
    mzumsande commented at 5:33 pm on September 17, 2025: contributor

    utACK f2bd79f80c74a2b77f14954ac65679417697a332

    I mostly looked at the p2p backports (#32646, #33296, #33395), the rest looked correct too but I didn’t check very deeply.

30. glozow merged this on Sep 17, 2025
31. glozow closed this on Sep 17, 2025

    ---

32. fanquake deleted the branch on Sep 17, 2025

Contributors
fanquake DrahtBot instagibbs Crypt-iQ darosior mzumsande

Labels
Backport

Milestone
29.2