ci: always use tag for LLVM checkout #33364

1. 
   fanquake commented at 9:56 am on September 11, 2025: member

   Rather than trying to match the apt installed clang version, which is prone to intermittent issues. i.e #33345.
2. ci: always use tag for LLVM checkout

   Rather than trying to match the apt installed clang version, which is
   prone to intermittent issues. i.e #33345.

   b736052e39
3. DrahtBot added the label Tests on Sep 11, 2025
4. 
   DrahtBot commented at 9:56 am on September 11, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33364.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	willcl-ark, davidgumberg

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. willcl-ark approved
6. 
   willcl-ark commented at 10:54 am on September 11, 2025: member

   ACK b736052e39f1f466f63f261ace3dd2deba171e8a

   I did wonder about defining in the *.env files, something like:

    0diff --git a/ci/test/00_setup_env_native_fuzz_with_msan.sh b/ci/test/00_setup_env_native_fuzz_with_msan.sh
    1index c71772b8e2c..47497ed4c81 100755
    2--- a/ci/test/00_setup_env_native_fuzz_with_msan.sh
    3+++ b/ci/test/00_setup_env_native_fuzz_with_msan.sh
    4@@ -26,6 +26,7 @@ export BITCOIN_CONFIG="\
    5  -DAPPEND_CPPFLAGS='-DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE -U_FORTIFY_SOURCE' \
    6 "
    7 export USE_INSTRUMENTED_LIBCPP="MemoryWithOrigins"
    8+export INSTRUMENTED_LIBCPP_LLVM_V="21.1.1"
    9 export RUN_UNIT_TESTS="false"
   10 export RUN_FUNCTIONAL_TESTS="false"
   11 export RUN_FUZZ_TESTS=true
   12diff --git a/ci/test/00_setup_env_native_msan.sh b/ci/test/00_setup_env_native_msan.sh
   13index 4ff82614e9d..ac070b3364a 100755
   14--- a/ci/test/00_setup_env_native_msan.sh
   15+++ b/ci/test/00_setup_env_native_msan.sh
   16@@ -29,3 +29,4 @@ export BITCOIN_CONFIG="\
   17  -DAPPEND_CPPFLAGS='-U_FORTIFY_SOURCE' \
   18 "
   19 export USE_INSTRUMENTED_LIBCPP="MemoryWithOrigins"
   20+export INSTRUMENTED_LIBCPP_LLVM_V="21.1.1"
   21diff --git a/ci/test/00_setup_env_native_tsan.sh b/ci/test/00_setup_env_native_tsan.sh
   22index bf4b68412b2..c6427173e16 100755
   23--- a/ci/test/00_setup_env_native_tsan.sh
   24+++ b/ci/test/00_setup_env_native_tsan.sh
   25@@ -19,3 +19,4 @@ export CI_LIMIT_STACK_SIZE=1
   26 export BITCOIN_CONFIG="-DWITH_ZMQ=ON -DSANITIZERS=thread \
   27 -DAPPEND_CPPFLAGS='-DARENA_DEBUG -DDEBUG_LOCKCONTENTION -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES'"
   28 export USE_INSTRUMENTED_LIBCPP="Thread"
   29+export INSTRUMENTED_LIBCPP_LLVM_V="21.1.1"
   30diff --git a/ci/test/01_base_install.sh b/ci/test/01_base_install.sh
   31index 6944ab42b06..767130bf319 100755
   32--- a/ci/test/01_base_install.sh
   33+++ b/ci/test/01_base_install.sh
   34@@ -56,7 +56,7 @@ if [ -n "$PIP_PACKAGES" ]; then
   35 fi
   36 
   37 if [[ -n "${USE_INSTRUMENTED_LIBCPP}" ]]; then
   38-  ${CI_RETRY_EXE} git clone --depth=1 https://github.com/llvm/llvm-project -b "llvmorg-21.1.1" /llvm-project
   39+  ${CI_RETRY_EXE} git clone --depth=1 https://github.com/llvm/llvm-project -b "llvmorg-${INSTRUMENTED_LIBCPP_LLVM_V}" /llvm-project
   40 
   41   if [ -n "${APT_LLVM_V}" ]; then
   42 
   

   But it only means three places to update rather than one in the future, and I’m not aware of any reason we’d want those jobs using different versions, so current approach seems best for now.

   We could also always fetch the latest llvmorg-* tag, but this would most likely just expose us to “random” Ci failures rather than specifically when we update the target tag, which would probably also be unhelpful.

7. 
   davidgumberg commented at 5:49 pm on September 11, 2025: contributor

   ACK https://github.com/bitcoin/bitcoin/commit/b736052e39f1f466f63f261ace3dd2deba171e8a
8. 
   yorick1125 commented at 2:05 am on September 12, 2025: none

   ,
9. fanquake merged this on Sep 12, 2025
10. fanquake closed this on Sep 12, 2025

    ---

11. fanquake referenced this in commit f7eded1dca on Sep 12, 2025
12. fanquake deleted the branch on Sep 12, 2025
13. 
    fanquake commented at 8:47 am on September 12, 2025: member

    Backported to 30.x in #33356.
14. fanquake referenced this in commit 324caa8497 on Sep 12, 2025

Contributors
fanquake DrahtBot willcl-ark davidgumberg yorick1125

Labels
Tests