cmake: Fix regression in secp256k1.cmake #33379

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250912-kernel-ipo changing 1 files +2 −1
  1. hebasto commented at 5:00 pm on September 12, 2025: member

    This PR fixes a regression introduced in #33101 (mea culpa).

    From the CMake docs:

    The following restrictions apply to where enable_language() may be called:

    • It must be called in file scope, not in a function call.

    Fixes #33153.

  2. cmake: Fix regression in `secp256k1.cmake`
    The `enable_language` command must be called in file scope, not in a
    function call.
    
    See: https://cmake.org/cmake/help/latest/command/enable_language.html
    9193c3e434
  3. hebasto added this to the milestone 30.0 on Sep 12, 2025
  4. hebasto added the label Build system on Sep 12, 2025
  5. DrahtBot commented at 5:00 pm on September 12, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33379.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan, furszy

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  6. TheCharlatan approved
  7. TheCharlatan commented at 6:39 pm on September 12, 2025: contributor
    ACK 9193c3e4340bb5b49af2ab04bce335876e7b1076
  8. furszy commented at 6:49 pm on September 12, 2025: member
    ACK 9193c3e4340bb5b49af2ab04bce335876e7b1076
  9. fanquake merged this on Sep 15, 2025
  10. fanquake closed this on Sep 15, 2025

  11. fanquake referenced this in commit 0a2afbeb77 on Sep 15, 2025
  12. fanquake commented at 8:53 am on September 15, 2025: member
    Backported to 30.x in #33356.
  13. hebasto deleted the branch on Sep 15, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-18 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me