Update libmultiprocess subtree to fix intermittent mptest hang #33412

pull ryanofsky wants to merge 2 commits into bitcoin:master from ryanofsky:pr/subtree-5 changing 11 files +190 −79

ryanofsky commented at 10:04 AM on September 17, 2025: contributor
Includes:
The last change fixes the test hang reported #33244

The changes can be verified by running test/lint/git-subtree-check.sh src/ipc/libmultiprocess as described in developer notes and lint instructions

Squashed 'src/ipc/libmultiprocess/' changes from 13424cf2ecc1..47d79db8a552

47d79db8a552 Merge bitcoin-core/libmultiprocess#201: bug: fix mptest hang, ProxyClient<Thread> deadlock in disconnect handler
f15ae9c9b9fb Merge bitcoin-core/libmultiprocess#211: Add .gitignore
4a269b21b8c8 bug: fix ProxyClient<Thread> deadlock if disconnected as IPC call is returning
85df96482c49 Use try_emplace in SetThread instead of threads.find
ca9b380ea91a Use std::optional in ConnThreads to allow shortening locks
9b0799113557 doc: describe ThreadContext struct and synchronization requirements
d60db601ed9b proxy-io.h: add Waiter::m_mutex thread safety annotations
4e365b019a9f ci: Use -Wthread-safety not -Wthread-safety-analysis
15d7bafbb001 Add .gitignore
fe1cd8c76131 Merge bitcoin-core/libmultiprocess#208: ci: Test minimum cmake version in olddeps job
b713a0b7bfbc Merge bitcoin-core/libmultiprocess#207: ci: output CMake version in CI script
0f580397c913 ci: Test minimum cmake version in olddeps job
d603dcc0eef0 ci: output CMake version in CI script

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 47d79db8a5528097b408e18f7b0bae11a6702d26

535fa0ad0d

Merge commit '535fa0ad0d2637f845beae92ea9dbbbbbe377c74' into pr/subtree-5 c49a43591f
DrahtBot renamed this:
~~Update libmultiprocess subtree to fix intermittent mptest hang~~
Update libmultiprocess subtree to fix intermittent mptest hang
on Sep 17, 2025
DrahtBot commented at 10:04 AM on September 17, 2025: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33412.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK Sjors, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



LLM Linter (✨ experimental)

Possible typos and grammar issues:
- before thread client is -> before the thread client is [missing article makes the sentence awkward and slightly unclear]
- Synchronization note: \ref callback_threads note applies here as well. -> Synchronization note: the callback_threads note applies here as well. [\ref looks like a Doxygen reference; as written the phrase is redundant/awkward ("note" twice) and the backslash ref makes the sentence unclear in plain English]
<sup>drahtbot_id_5_m</sup>
fanquake commented at 1:04 PM on September 18, 2025: member

cc @Sjors
Sjors commented at 5:18 PM on September 18, 2025: member

ACK c49a43591f88dc199cc04e76f3cfcb7ba136f1a6
sedited approved
sedited commented at 9:22 AM on September 19, 2025: contributor

ACK c49a43591f88dc199cc04e76f3cfcb7ba136f1a6
fanquake merged this on Sep 19, 2025
fanquake closed this on Sep 19, 2025
sedited referenced this in commit 3f14dd4b2a on Oct 7, 2025
sedited referenced this in commit 5f9d179b8d on Oct 8, 2025
sedited referenced this in commit 845b93d99e on Oct 8, 2025
yuvicc referenced this in commit ccce70c31a on Oct 8, 2025
sedited referenced this in commit 3b1e26d5d3 on Oct 10, 2025
sedited referenced this in commit 0fa2fdaca0 on Oct 11, 2025
stringintech referenced this in commit f74b275ffc on Oct 14, 2025
stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
Kino1994 referenced this in commit f1baab6b60 on Jun 28, 2026
BigcoinBGC referenced this in commit 5effefa7a5 on Jun 30, 2026
Kino1994 referenced this in commit e430cff012 on Aug 19, 2026
bitcoin locked this on Sep 19, 2026

Type	Reviewers
ACK	Sjors, TheCharlatan

Contributors

Linked (view graph)

#28722 Multiprocess tracking issue #33244 intermittent timeout in mptest unit test #33439 How to backport libmultiprocess changes?

Update libmultiprocess subtree to fix intermittent mptest hang #33412

Code Coverage & Benchmarks

Reviews

LLM Linter (✨ experimental)