fuzz: reduce iterations in slow targets #33429

pull marcofleon wants to merge 1 commits into bitcoin:master from marcofleon:reduce-iterations changing 3 files +4 −4

marcofleon commented at 4:56 PM on September 18, 2025: contributor

The mini_miner, txdownloadman, txdownloadman_impl, and tx_pool_standard fuzz targets are all slow-running targets. Fix this by reducing the iteration count in the LIMITED_WHILE loops.

This should help decrease the run time of the fuzz CI jobs. See #33425.

Addresses #32870 as well.
DrahtBot added the label Tests on Sep 18, 2025
DrahtBot commented at 4:56 PM on September 18, 2025: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33429.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK dergoegge, brunoerg, Crypt-iQ

Concept ACK enirox001

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #33425 (ci: run native_fuzz_with_msan by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
marcofleon commented at 5:01 PM on September 18, 2025: contributor

There should be no loss of coverage when running on the inputs in qa-assets.

For tx_pool_standard I saw a speed up from 1068 to 720 seconds with this change. I think the loop in initialize_tx_pool is still slowing it down? I would need to look into it some more, but I left that as is for now.
fuzz: Reduce iterations in slow targets 6a33970fef
marcofleon force-pushed on Sep 19, 2025
marcofleon commented at 2:32 PM on September 19, 2025: contributor
I ran the MSan fuzz CI script on my machine with these changes and for single run through the qa-assets inputs:
- mini_miner 105 sec
- txdownloadman 115 sec
- txdownloadman_impl 165 sec
- tx_pool_standard 727 sec
Some previous times can be seen in #33425.
marcofleon marked this as ready for review on Sep 19, 2025
dergoegge approved
dergoegge commented at 2:46 PM on September 19, 2025: member

utACK 6a33970fef1b7b4d634f28277607b882958c95ac
marcofleon commented at 5:32 PM on September 19, 2025: contributor
coverage:
- txdownloadman master this PR
- txdownloadman_impl master this PR
- mini_miner master this PR
- tx_pool_standard master this PR
enirox001 commented at 6:00 PM on September 19, 2025: contributor

Concept ACK 6a33970

While working on #32870, I considered reducing iterations to speed up fuzzing, but wasn’t sure it was feasible since that wasn’t the issue’s intended goal. However, I noticed that reducing iterations did speed up the MiniMiner fuzz test.

This seems like a good approach to solving the issue, pending the reimplementation of MiniMiner.
brunoerg approved

Type	Reviewers
ACK	dergoegge, brunoerg, Crypt-iQ
Concept ACK	enirox001

brunoerg commented at 6:34 PM on September 19, 2025: contributor

ACK 6a33970fef1b7b4d634f28277607b882958c95ac

I verified the perfomance gain. e.g. mini_miner target is now 10x faster on my machine.

mini miner (master):

[#256](/bitcoin-bitcoin/256/)	pulse  cov: 4182 ft: 24483 corp: 253/57Kb exec/s: 128 rss: 278Mb
[#512](/bitcoin-bitcoin/512/)	pulse  cov: 4234 ft: 27611 corp: 501/1139Kb exec/s: 8 rss: 761Mb
[#602](/bitcoin-bitcoin/602/)	INITED cov: 4235 ft: 28000 corp: 576/4293Kb exec/s: 5 rss: 797Mb
[#602](/bitcoin-bitcoin/602/)	DONE   cov: 4235 ft: 28000 corp: 576/4293Kb lim: 489495 exec/s: 5 rss: 797Mb
Done 602 runs in 113 second(s)

mini miner (this PR):

[#256](/bitcoin-bitcoin/256/)	pulse  cov: 4100 ft: 22796 corp: 251/57Kb exec/s: 128 rss: 252Mb
[#512](/bitcoin-bitcoin/512/)	pulse  cov: 4121 ft: 24106 corp: 414/715Kb exec/s: 56 rss: 631Mb
[#602](/bitcoin-bitcoin/602/)	INITED cov: 4121 ft: 24200 corp: 454/2430Kb exec/s: 46 rss: 768Mb
[#602](/bitcoin-bitcoin/602/)	DONE   cov: 4121 ft: 24200 corp: 454/2430Kb lim: 296374 exec/s: 46 rss: 768Mb
Done 602 runs in 13 second(s)

DrahtBot requested review from enirox001 on Sep 19, 2025
Crypt-iQ commented at 7:12 PM on September 19, 2025: contributor

crACK 6a33970fef1b7b4d634f28277607b882958c95ac
furszy commented at 7:21 PM on September 19, 2025: member

A few extra optimizations (plus a bug fix) to the mini miner target: https://github.com/furszy/bitcoin-core/tree/2025\_fuzz\_improve\_mini\_miner. They don’t seem to add much gain per @brunoerg’s feedback, but might help on the long run. Feel free to take them if you like them.
fanquake commented at 1:52 PM on September 20, 2025: member

@furszy Could you PR that branch separately?
fanquake merged this on Sep 20, 2025
fanquake closed this on Sep 20, 2025
TheCharlatan referenced this in commit 3f14dd4b2a on Oct 7, 2025
TheCharlatan referenced this in commit 5f9d179b8d on Oct 8, 2025
TheCharlatan referenced this in commit 845b93d99e on Oct 8, 2025
yuvicc referenced this in commit ccce70c31a on Oct 8, 2025
TheCharlatan referenced this in commit 3b1e26d5d3 on Oct 10, 2025
TheCharlatan referenced this in commit 0fa2fdaca0 on Oct 11, 2025
stringintech referenced this in commit f74b275ffc on Oct 14, 2025
fanquake added the label Fuzzing on Oct 30, 2025