[30.x] Backports & rc3 #33473

pull fanquake wants to merge 13 commits into bitcoin:30.x from fanquake:30_0_rc3 changing 26 files +146 −119

fanquake commented at 2:11 pm on September 24, 2025: member
Backports:
- #33434
- #33446
- #33453
- #33475
- #33482
- #33484
- #33504
Includes changes for v30.0rc3:
- Version bump
- Regen manpages
- Regen exmaple .conf

test: add block 2016 to mock mainnet

The next commit requires an additional mainnet block which changes the difficulty.

Also fix a few minor mistakes in the test (suite):
- rename the create_coinbase retarger_period argument to halving_period. Before bitcoin#31583 this was hardcoded for regtest where these values are the same.
- drop unused fees argument from mine helper

Finally the CPU miner instructions for generating the alternative mainnet chain are expanded.

Github-Pull: #33446
Rebased-From: 4c3c1f42cf705e039751395799240da33ca969bd

4ec30d53ec

rpc: fix getblock(header) returns target for tip

A target field was added to the getblock and getblockheader RPC calls in bitcoin#31583, but it mistakingly always used the tip value.

Because regtest does not have difficulty adjustment, a test is added for mainnet instead.

Github-Pull: #33446
Rebased-From: bf7996cbc3becf329d8b1cd2f1007fec9b3a3188

1e348bc55a

fanquake added this to the milestone 30.0 on Sep 24, 2025
DrahtBot added the label Backport on Sep 24, 2025

DrahtBot commented at 2:11 pm on September 24, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33473.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	marcofleon, dergoegge, hebasto, Zero-1729
Concept ACK	instagibbs, Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

miner: fix `addPackageTxs` unsigned integer overflow

Github-Pull: #33475
Rebased-From: b807dfcdc5929c314d43b790c9e705d5bf0a86e8

45703931e5

doc: rpc: fix case typo in `finalizepsbt` help (final_scriptwitness)
Github-Pull: #33484 Rebased-From: ff05bebcc4262966b117082a67dc4c63a3f67d2d
b75afaccb8

datacarrier: Undeprecate configuration option

Reverts commit 0b4048c73385166144d0b3e76beb9a2ac4cc1eca

Github-Pull: #33453
Rebased-From: 451ba9ada41f687c0e4bb34d5925374a68a8f8a3

fce1c60770

fuzz: don't bypass_limits for most mempool harnesses

Using bypass_limits=true is essentially fuzzing part of a
reorg only, and results in TRUC invariants unable to be
checked. Remove most instances of bypassing limits, leaving
one harness able to do so.

Github-Pull: #33504
Rebased-From: bbe8e9063c15dc230553e0cbf16d603f5ad0e4cf

a3a1dcb589

Mempool: Do not enforce TRUC checks on reorg

Not enforcing TRUC topology on reorg was the intended
behavior, but the appropriate bypass argument was not
checked.

This mistake means we could potentially invalidate a long
chain of perfectly incentive-compatible transactions that
were made historically, including subsequent non-TRUC
transactions, all of which may have been very high feerate.

Lastly, it wastes CPU cycles doing topology checks since
this behavior cannot actually enforce the topology in
general for the reorg setting.

Github-Pull: #33504
Rebased-From: 26e71c237d9d2197824b547f55ee3a0a60149f92

3485252584

test: add more TRUC reorg coverge

Github-Pull: #33504
Rebased-From: 06df14ba75be5f48cf9c417424900ace17d1cf4d

e4f9ec2f05

depends: static libxcb_cursor

Modern Ubuntu isn't shipping with this library installed by default.
Staticly link it to remove the need for end-users to install it.

Closes #33432.

Github-Pull: #33434
Rebased-From: eca50854e1cb04e20478bd3df4762e18520a3611

1eb578045d

fanquake marked this as ready for review on Oct 3, 2025
fanquake commented at 2:31 pm on October 3, 2025: member

Edited https://github.com/bitcoin-core/bitcoin-devwiki/wiki/v30.0-Release-Notes-Draft to remove the mention of the libxcb-cursor runtime requirement.
fanquake referenced this in commit 3c790d7bc8 on Oct 3, 2025

contrib: fix using macdploy script without translations.

QT translations are optional, but the script would error when
'translations_dir' falls back to its default value NULL.

This PR fixes it by moving the set-up of QT translations under
the check for 'translations_dir' presence.

Github-Pull: #33482
Rebased-From: 7b5261f7ef3d88361204c40eb10c0d9dc44f5ed7

f957c2171d

fanquake force-pushed on Oct 3, 2025
build: bump version to v30.0rc3 e4b568917c
doc: update manual pages for v30.0rc3 a2ac6cce57
doc: update example bitcoin conf for 30.0rc3 4e869a67aa
instagibbs commented at 3:51 pm on October 3, 2025: member

ACK on #33504 and #33504 changes
marcofleon commented at 6:40 pm on October 3, 2025: contributor

lgtm ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44

The diff looks fine and I did a (light) code review of every PR commit.
DrahtBot requested review from instagibbs on Oct 3, 2025
dergoegge approved
dergoegge commented at 3:32 am on October 4, 2025: member

ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44
Sjors commented at 9:14 am on October 4, 2025: member

ACK on the #33446 changes.

Can you add #33229?
hebasto approved
hebasto commented at 11:24 am on October 5, 2025: member

ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44, I agree on the backported PRs. I’ve reproduced locally all backports, the manpages update, and the example bitcoin.conf updated, and obtained zero diff with this PR.
DrahtBot requested review from Sjors on Oct 5, 2025
Zero-1729 commented at 9:28 pm on October 5, 2025: contributor

LGTM ACK 4e869a67aa7415f9c756bf6463e3437ae0a3ec44

Tested locally, all checks out.
fanquake commented at 9:30 am on October 6, 2025: member

Can you add #33229?

I’m not going to add that here, rc3 is already late. There might be more multiprocess backporting done, so it could be included there, but that’s also blocked on at least https://github.com/bitcoin-core/libmultiprocess/pull/222.
fanquake merged this on Oct 6, 2025
fanquake closed this on Oct 6, 2025
fanquake deleted the branch on Oct 6, 2025

Contributors
fanquake DrahtBot instagibbs marcofleon dergoegge Sjors hebasto Zero-1729

Review Requested
Sjors instagibbs

Labels
Backport

Milestone
30.0