[29.x] Backports #33474

1. 
   fanquake commented at 2:41 pm on September 24, 2025: member

   Backports:

   • #33446
   • #33484
   • #33504
2. test: add block 2016 to mock mainnet

   The next commit requires an additional mainnet block which changes the difficulty.
   
   Also fix a few minor mistakes in the test (suite):
   - rename the create_coinbase retarger_period argument to halving_period. Before bitcoin#31583 this was hardcoded for regtest where these values are the same.
   - drop unused fees argument from mine helper
   
   Finally the CPU miner instructions for generating the alternative mainnet chain are expanded.
   
   Github-Pull: #33446
   Rebased-From: 4c3c1f42cf705e039751395799240da33ca969bd

   118abf4c30
3. rpc: fix getblock(header) returns target for tip

   A target field was added to the getblock and getblockheader RPC calls in bitcoin#31583, but it mistakingly always used the tip value.
   
   Because regtest does not have difficulty adjustment, a test is added for mainnet instead.
   
   Github-Pull: #33446
   Rebased-From: bf7996cbc3becf329d8b1cd2f1007fec9b3a3188

   22ab141243
4. fanquake added this to the milestone 29.2 on Sep 24, 2025
5. DrahtBot added the label Backport on Sep 24, 2025
6. 
   DrahtBot commented at 2:41 pm on September 24, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33474.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge, luke-jr, marcofleon

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

7. doc: rpc: fix case typo in `finalizepsbt` help (final_scriptwitness)

   Github-Pull: #33484
   Rebased-From: ff05bebcc4262966b117082a67dc4c63a3f67d2d

   9d9baafc6f
8. fanquake force-pushed on Sep 29, 2025
9. fuzz: don't bypass_limits for most mempool harnesses

   Using bypass_limits=true is essentially fuzzing part of a
   reorg only, and results in TRUC invariants unable to be
   checked. Remove most instances of bypassing limits, leaving
   one harness able to do so.
   
   Github-Pull: #33504
   Rebased-From: bbe8e9063c15dc230553e0cbf16d603f5ad0e4cf

   6f23ead4a2
10. Mempool: Do not enforce TRUC checks on reorg

    Not enforcing TRUC topology on reorg was the intended
    behavior, but the appropriate bypass argument was not
    checked.
    
    This mistake means we could potentially invalidate a long
    chain of perfectly incentive-compatible transactions that
    were made historically, including subsequent non-TRUC
    transactions, all of which may have been very high feerate.
    
    Lastly, it wastes CPU cycles doing topology checks since
    this behavior cannot actually enforce the topology in
    general for the reorg setting.
    
    Github-Pull: #33504
    Rebased-From: 26e71c237d9d2197824b547f55ee3a0a60149f92

    666aec7d49
11. test: add more TRUC reorg coverge

    Github-Pull: #33504
    Rebased-From: 06df14ba75be5f48cf9c417424900ace17d1cf4d

    a8bb76b61f
12. doc: update release notes for 29.x 2d7ebd2d91
13. fanquake force-pushed on Oct 2, 2025
14. dergoegge approved
15. 
    dergoegge commented at 11:19 pm on October 2, 2025: member

    ACK 2d7ebd2d913ea63c1a23fefa0a09ee06fb069161
16. 
    luke-jr commented at 10:22 am on October 3, 2025: member

    ACK 2d7ebd2d913ea63c1a23fefa0a09ee06fb069161
17. fanquake marked this as ready for review on Oct 3, 2025
18. 
    marcofleon commented at 1:16 pm on October 3, 2025: contributor

    ACK 2d7ebd2d913ea63c1a23fefa0a09ee06fb069161
19. fanquake merged this on Oct 3, 2025
20. fanquake closed this on Oct 3, 2025

    ---

21. fanquake deleted the branch on Oct 3, 2025

Contributors
fanquake DrahtBot dergoegge luke-jr marcofleon

Labels
Backport

Milestone
29.2