cmake: Switch to `minisketch` upstream build system #33841

1. 
   hebasto commented at 2:38 PM on November 10, 2025: member

   This PR:

   1. Switches to minisketch's own build system script.

   2. Does not change behaviour, except for printing "minisketch configure summary" in the build configuration output.

   Fellow reviewers might also be interested in the discussion that took place in #32856.

2. cmake: Switch to `minisketch` upstream build system 7fde815b38
3. hebasto added the label Build system on Nov 10, 2025
4. in cmake/minisketch.cmake:13 in 7fde815b38

     87 | +  set(BUILD_SHARED_LIBS OFF)
     88 | +  set(CMAKE_EXPORT_COMPILE_COMMANDS OFF)
     89 | +  # Hard-code subtree options; they won’t appear in the CMake cache.
     90 | +  set(MINISKETCH_INSTALL OFF)
     91 | +  set(MINISKETCH_BUILD_TESTS OFF)
     92 | +  set(MINISKETCH_BUILD_BENCHMARK OFF)
   

   ---

   ---

   

   BrandonOdiwuor commented at 9:51 PM on December 21, 2025:

   is this to be explicit as this is the default value in minisketch

   https://github.com/bitcoin/bitcoin/blob/7f295e1d9b44c225c823242c1f04239f46fb27a6/src/minisketch/CMakeLists.txt#L58

5. 
   BrandonOdiwuor commented at 9:52 PM on December 21, 2025: contributor

   Concept ACK 7fde815b38145702c5ba47623b6770001e212246

   I was able to configure and build successfully with the minisketch upstream build system on Ubuntu 24.04 (cmake version 3.28.3).

   The new configure summary for minisketch appeared as expected in the output.

   configure <img width="807" height="632" alt="Screenshot 2025-12-21 at 23 50 19" src="https://github.com/user-attachments/assets/987c81b6-89e8-4666-89f1-a39165febf0d" />

   build <img width="789" height="493" alt="Screenshot 2025-12-22 at 00 06 38" src="https://github.com/user-attachments/assets/e60626fd-38cc-434f-8e56-8eb85fa5856e" />

6. 
   DrahtBot commented at 9:52 PM on December 21, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33841.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	bensig
   Concept ACK	BrandonOdiwuor

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

7. 
   bensig commented at 9:38 PM on January 5, 2026: contributor

   ACK 7fde815b38145702c5ba47623b6770001e212246

   Built and tested. Reduces cmake maintenance burden by using minisketch's upstream build system.

8. DrahtBot requested review from BrandonOdiwuor on Jan 5, 2026
9. 
   fanquake commented at 2:45 PM on February 11, 2026: member

   This could be drafted, until an outcome in #34542. I don't think there's a rush/need to make any changes in the interim.

10. fanquake marked this as a draft on Feb 13, 2026

Review Requested
BrandonOdiwuor