fees: leftover references to policy/fees.cpp #33863

issue fanquake openend this issue on November 12, 2025
  1. fanquake commented at 4:33 pm on November 12, 2025: member

    Pointed out here: #33218 (comment)

    I still see some references to the src/policy/fees.h file removed by this PR:

    0$ git grep -n policy/fees.h
    1src/wallet/rpc/spend.cpp:206: * [@param](/bitcoin-bitcoin/contributor/param/)[in]     conf_target       UniValue integer; confirmation target in blocks, values between 1 and 1008 are valid per policy/fees.h;
    2test/functional/rpc_estimatefee.py:39:        # max value of 1008 per src/policy/fees.h
    3test/functional/rpc_psbt.py:604:                assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
    4test/functional/wallet_basic.py:337:            assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
    5test/functional/wallet_fundrawtransaction.py:851:                assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008",  # max value of 1008 per src/policy/fees.h
    6test/functional/wallet_send.py:315:                expect_error=(-8, "Invalid conf_target, must be between 1 and 1008"))  # max value of 1008 per src/policy/fees.h
    
  2. fanquake commented at 4:34 pm on November 12, 2025: member
  3. ismaelsadeeq commented at 5:44 pm on November 12, 2025: member
    Thanks @ryanofsky @fanquake I opened #33864 with a fix
  4. fanquake closed this on Nov 13, 2025

  5. fanquake referenced this in commit dfde31f2ec on Nov 13, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-23 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me