The mempool implementation now uses TxGraph with entries using FeePerWeight, not vsize. This means our package_rbf harness will erroneously add more transaction weight than we can support inside of FeeFrac. Gate more aggressively using WITNESS_SCALE_FACTOR.
fuzz: gate mempool entry based on weight #33985
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2025-12-txgraph_fuzz_package_rbf changing 1 files +3 −2-
instagibbs commented at 3:24 pm on December 1, 2025: member
-
DrahtBot added the label Tests on Dec 1, 2025
-
DrahtBot commented at 3:24 pm on December 1, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33985.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
-
804329400a
fuzz: gate mempool entry based on weight
The mempool implementation now uses TxGraph with entries using FeePerWeight, not vsize. This means our package_rbf harness will erroneously add more transaction weight than we can support inside of FeeFrac. Gate more aggressively using WITNESS_SCALE_FACTOR.
-
instagibbs force-pushed on Dec 1, 2025
-
maflcko added this to the milestone 31.0 on Dec 1, 2025
-
DrahtBot added the label CI failed on Dec 1, 2025
-
instagibbs commented at 3:30 pm on December 1, 2025: membercc @sdaftuar
-
DrahtBot removed the label CI failed on Dec 1, 2025
-
sdaftuar commented at 6:26 pm on December 1, 2025: memberLooks right to me, and I was able to generate a fuzz crash on master that was fixed by this PR. Going to continue fuzzing for a bit to see if there are any other issues.
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-01 21:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-01 21:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me