fuzz: gate mempool entry based on weight #33985

1. 
   instagibbs commented at 3:24 PM on December 1, 2025: member

   The mempool implementation now uses TxGraph with entries using FeePerWeight, not vsize. This means our package_rbf harness will erroneously add more transaction weight than we can support inside of FeeFrac. Gate more aggressively using WITNESS_SCALE_FACTOR.

   Fixes https://github.com/bitcoin/bitcoin/issues/33981

2. DrahtBot added the label Tests on Dec 1, 2025
3. 
   DrahtBot commented at 3:24 PM on December 1, 2025: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33985.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sdaftuar, ismaelsadeeq, dergoegge

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

4. fuzz: gate mempool entry based on weight

   The mempool implementation now uses TxGraph with entries
   using FeePerWeight, not vsize. This means our package_rbf
   harness will erroneously add more transaction weight than we
   can support inside of FeeFrac. Gate more aggressively using
   WITNESS_SCALE_FACTOR.

   804329400a
5. instagibbs force-pushed on Dec 1, 2025
6. maflcko added this to the milestone 31.0 on Dec 1, 2025
7. DrahtBot added the label CI failed on Dec 1, 2025
8. 
   instagibbs commented at 3:30 PM on December 1, 2025: member

   cc @sdaftuar

9. DrahtBot removed the label CI failed on Dec 1, 2025
10. 
    sdaftuar commented at 6:26 PM on December 1, 2025: member

    Looks right to me, and I was able to generate a fuzz crash on master that was fixed by this PR. Going to continue fuzzing for a bit to see if there are any other issues.

11. 
    sdaftuar commented at 1:49 PM on December 2, 2025: member

    ACK 804329400a73df00dfd7a5209c659d4a22b9ce47

12. fanquake added the label Fuzzing on Dec 2, 2025
13. 
    fanquake commented at 1:51 PM on December 2, 2025: member

    cc @dergoegge

14. ismaelsadeeq approved
15. 
    ismaelsadeeq commented at 2:45 PM on December 2, 2025: member

    utACK 804329400a73df00dfd7a5209c659d4a22b9ce47

16. dergoegge approved
17. 
    dergoegge commented at 2:54 PM on December 2, 2025: member

    utACK 804329400a73df00dfd7a5209c659d4a22b9ce47

18. fanquake merged this on Dec 2, 2025
19. fanquake closed this on Dec 2, 2025

    ---

Milestone
31.0