Backports:
[30.x] Backports #34689
pull fanquake wants to merge 10 commits into bitcoin:30.x from fanquake:even_more_30_backports changing 14 files +77 −28-
fanquake commented at 12:05 PM on February 27, 2026: member
- fanquake added this to the milestone 30.3 on Feb 27, 2026
- DrahtBot added the label Backport on Feb 27, 2026
-
DrahtBot commented at 12:05 PM on February 27, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK marcofleon If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- fanquake force-pushed on Mar 2, 2026
- fanquake force-pushed on Mar 4, 2026
- fanquake force-pushed on Mar 4, 2026
- fanquake force-pushed on Mar 5, 2026
- fanquake force-pushed on Mar 8, 2026
-
7220ee3fc7
util: Fix UB in SetStdinEcho when ENOTTY
Github-Pull: #34597 Rebased-From: fa692974ac2d69e01091f03625cd8a227e310065
-
475a5b0504
refactor: Use static_cast<decltype(...)> to suppress integer sanitizer warning
This refactor does not change any behavior, except for the integer sanitizer warning. Can be tested via: UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./bld-cmake/bin/bitcoin-cli -stdinrpcpass uptime Github-Pull: #34597 Rebased-From: fa6af856341384e4a84c5674e66fe7c1f13dd73c
-
304250983e
netif: fix compilation warning in QueryDefaultGatewayImpl()
``` src/common/netif.cpp:137:51: error: comparison of integers of different signs: 'int64_t' (aka 'long') and 'unsigned long' [-Werror,-Wsign-compare] 137 | for (nlmsghdr* hdr = (nlmsghdr*)response; NLMSG_OK(hdr, recv_result); hdr = NLMSG_NEXT(hdr, recv_result)) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/netlink/netlink.h:220:31: note: expanded from macro 'NLMSG_OK' 220 | #define NLMSG_OK(_hdr, _len) NL_ITEM_OK(_hdr, _len, NLMSG_HDRLEN, _NLMSG_LEN) | ^ ~~~~ ~~~~~~~~~~~~ /usr/include/netlink/netlink.h:203:10: note: expanded from macro 'NL_ITEM_OK' 203 | ((_len) >= _hlen && _LEN_M(_ptr) >= _hlen && _LEN_M(_ptr) <= (_len)) | ~~~~ ^ ~~~~~ 1 error generated. ``` Happens on FreeBSD 15.0, with the default compiler (Clang 19). On FreeBSD 14, `/usr/include/netlink/netlink.h` contains: ``` #define NLMSG_HDRLEN ((int)sizeof(struct nlmsghdr)) ``` On FreeBSD 15, `/usr/include/netlink/netlink.h` contains: ``` #define NLMSG_HDRLEN (sizeof(struct nlmsghdr)) ``` Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Github-Pull: #34093 Rebased-From: c1361fc42dd60606fcd6273cede1083cd88866a2 -
c17a5cd5f8
test: Add missing timeout_factor to zmq socket
Github-Pull: #34690 Rebased-From: fa48f8c8655d93e78b32b560a870577909b666d3
-
e1210ac259
doc: Improve dependencies.md IPC documentation
Improve dependencies.md to document IPC dependencies better: - Link to native_capnp.mk file not capnp.mk file so it's possible to see what version of Cap'n Proto is being used in release binaries. This is important since #31895 dropped the "Version Used" column and the capnp.mk file does not include version number. - Indicate Capn"Proto is used for IPC and link to multiprocess.md documenting the feature. - Link to correct PR requiring Cap'n Proto 0.7.1. Previous link was pointing at PR which required 0.7.0. - Mention libmultiprocess as a dependency even though it is included as a git subtree and can be built as a cmake subproject. Libmultiprocess still needs to be built separately when cross compiling, and is useful to build separately when developing, and is still a depends package. Based on 2cf352fd8e6a77003e38d954b6c879b20d4b960a from #33623 by willcl-ark which made similar changes in the 29.x branch. Github-Pull: #34706 Rebased-From: b87a1c27c99821cea995112114eb40afa93417f2
-
d221d1c633
psbt: validate pubkeys in MuSig2 pubnonce/partial sig deserialization
Add validation for pubkeys in MuSig2 pubnonce and partial signature deserialization to prevent crashes with invalid curve points. - Validate aggregate and participant pubkeys in PSBT MuSig2 fields - Add comprehensive test coverage for invalid pubkey rejection - Ensure proper error handling during PSBT deserialization Github-Pull: #34219 Rebased-From: f51665bee72c26d3f3cc6813b6c02adad5f0af6a
-
47ed306689
depends: Allow building Qt packages after interruption
Github-Pull: #34713 Rebased-From: 2a7a4f608a42acef5cdf7370f0d191119fdb94c9
-
597ac36285
doc: Fix `fee` field in `getblock` RPC result
The `fee` field in the `getblock` RPC result (verbosity 2 and 3) may be omitted when block undo data is not available. Marking it optional in the `RPCResult` aligns the documented schema with the runtime behavior. Github-Pull: #34702 Rebased-From: f580cc7e9f26331f7f03a8bbc5722521eb159bb2
- fanquake force-pushed on Mar 9, 2026
- fanquake marked this as ready for review on Mar 10, 2026
- fanquake requested review from willcl-ark on Mar 10, 2026
- fanquake requested review from marcofleon on Mar 10, 2026
-
0f9e08f870
doc: update build guides pre v31
We are testing on FreeBSD 15 (nightly) and macOS 26 (CI). Github-Pull: #34789 Rebased-From: 6b20ad84e0a66c48976a599a7cc5b9b19cd49fab
-
doc: update release notes for v30.x 49a777d0dd
- fanquake force-pushed on Mar 10, 2026
- marcofleon approved
-
marcofleon commented at 5:37 PM on March 10, 2026: contributor
ACK 49a777d0dd0d28105b6ed397976fa8ba66960fea
The only thing I noted was that https://github.com/bitcoin/bitcoin/pull/34010/ looks very similar to https://github.com/bitcoin/bitcoin/pull/34219/, so could possibly backport that as well. However, that's beyond my area of expertise.
- fanquake merged this on Mar 11, 2026
- fanquake closed this on Mar 11, 2026
- fanquake deleted the branch on Mar 11, 2026
Contributors
Labels
Milestone
30.3
Linked (view graph)
#34093 netif: fix compilation warning in QueryDefaultGatewayImpl()#34219 psbt: validate pubkeys in MuSig2 pubnonce/partial sig deserialization#34597 util: Fix UB in SetStdinEcho when ENOTTY#34690 test: Add missing timeout_factor to zmq socket#34702 doc: Fix fee field in getblock RPC result#34706 doc: Improve dependencies.md IPC documentation#34713 depends: Allow building Qt packages after interruption#34789 doc: update build guides pre v31