test: Add missing timeout_factor to zmq socket #34690

1. 
   maflcko commented at 1:02 PM on February 27, 2026: member

   Fixes #34189

   Otherwise, the test may intermittently fail on slow CI systems that have --timeout-factor= properly set.

   It can be tested by running ./bld-cmake/test/functional/interface_zmq.py --timeout-factor=10 with this diff:

   diff --git a/src/validationinterface.cpp b/src/validationinterface.cpp
   index c7be6abc3a..b14cf2aee6 100644
   --- a/src/validationinterface.cpp
   +++ b/src/validationinterface.cpp
   @@ -166,2 +166,3 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()
                LOG_EVENT(fmt, local_name, __VA_ARGS__);           \
   +            UninterruptibleSleep(45ms); \
                event();                                           \
   diff --git a/test/functional/interface_zmq.py b/test/functional/interface_zmq.py
   index 6717007626..eee377daea 100755
   --- a/test/functional/interface_zmq.py
   +++ b/test/functional/interface_zmq.py
   @@ -176,3 +176,3 @@ class ZMQTest (BitcoinTestFramework):
            for sub in subscribers:
   -            sub.socket.set(zmq.RCVTIMEO, recv_timeout*1000)
   +            sub.socket.set(zmq.RCVTIMEO, int(recv_timeout * 1000))
    
   @@ -271,3 +271,3 @@ class ZMQTest (BitcoinTestFramework):
                [(topic, address) for topic in ["hashblock", "hashtx"]],
   -            recv_timeout=2)  # 2 second timeout to check end of notifications
   +            recv_timeout=0.2)  # 2 second timeout to check end of notifications
            self.disconnect_nodes(0, 1)
   

   Before this pull: Test fails with zmq.error.Again: Resource temporarily unavailable

   After this pull: Test passes

2. test: Add missing timeout_factor to zmq socket fa48f8c865
3. DrahtBot added the label Tests on Feb 27, 2026
4. 
   DrahtBot commented at 1:02 PM on February 27, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	l0rinc, achow101

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

5. maflcko added this to the milestone 31.0 on Feb 27, 2026
6. 
   l0rinc commented at 1:32 PM on February 27, 2026: contributor

   code review ACK fa48f8c8655d93e78b32b560a870577909b666d3

   Converting from seconds to millis (pre-existing behavior), scaling by timeout factor meant for heavier CI (not sure if sanitizers are the reason here or just slow machines), and casting the result back from float.

7. 
   achow101 commented at 11:14 PM on February 27, 2026: member

   ACK fa48f8c8655d93e78b32b560a870577909b666d3

8. achow101 merged this on Feb 27, 2026
9. achow101 closed this on Feb 27, 2026

   ---

10. fanquake referenced this in commit 22cc95584e on Mar 2, 2026
11. 
    fanquake commented at 10:05 AM on March 2, 2026: member

    Backported to 30.x in #34689.

12. maflcko deleted the branch on Mar 2, 2026

Milestone
31.0