build: install shell completions via cmake #34721

1. 
   willcl-ark commented at 2:33 pm on March 3, 2026: member

   Fixes: #34714

   Packagers currently need to manually copy shell completion scripts from contrib/completions/ into the appropriate system directories.

   Install bash and fish completions alongside their corresponding binaries as part of install_binary_component(), following the same pattern used for man pages. Completion files are automatically detected per component and installed to the standard locations:

   • bash: ${datadir}/bash-completion/completions/
   • fish: ${datadir}/fish/vendor_completions.d/

   Enabled by default. Can be disabled with -DINSTALL_COMPLETIONS=OFF. (This matches INSTALL_MAN default)

2. build: install shell completions via cmake

   Packagers currently need to manually copy shell completion scripts
   from contrib/completions/ into the appropriate system directories.
   
   Install bash and fish completions alongside their corresponding
   binaries as part of install_binary_component(), following the same
   pattern used for man pages. Completion files are automatically
   detected per component and installed to the standard locations:
   - bash: ${datadir}/bash-completion/completions/
   - fish: ${datadir}/fish/vendor_completions.d/
   
   Enabled by default. Can be disabled with -DINSTALL_COMPLETIONS=OFF.

   0a2d2cd116
3. DrahtBot added the label Build system on Mar 3, 2026
4. 
   DrahtBot commented at 2:33 pm on March 3, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	w0xlt, hebasto, caesrcd

   If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

5. 
   kpcyrd commented at 3:28 pm on March 3, 2026: none

   I tested this patch and it works well for me :smiley_cat:
6. DrahtBot added the label CI failed on Mar 3, 2026
7. 
   w0xlt commented at 3:52 pm on March 3, 2026: contributor

   Concept ACK
8. 
   hebasto commented at 3:57 pm on March 3, 2026: member

   Concept ACK.
9. 
   fanquake commented at 4:08 pm on March 3, 2026: member

   Will we start maintaining these, if we plan on installing them? #33747, #33402, #33385. There doesn’t seem to be any interest historically from contributors.
10. DrahtBot removed the label CI failed on Mar 3, 2026
11. 
    willcl-ark commented at 11:45 am on March 4, 2026: member

    Will we start maintaining these, if we plan on installing them?

    Fair shout. The alternative is to not maintain them and but to then also not ship them at all. My preference would be to maintain and install them.

    I have reviewed #33385 as I think this looks in the best shape to move forward, barring author response time.

12. 
    caesrcd commented at 6:30 pm on March 4, 2026: none

    Concept ACK

Contributors
willcl-ark DrahtBot kpcyrd w0xlt hebasto fanquake caesrcd

Labels
Build system