Without this, invalid vbparams just silently exit with no message
Bugfix: GUI/Intro: Handle errors from SelectParams the same as if during InitConfig #34767
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:fix_qt_intro_chain_except changing 1 files +7 −2-
luke-jr commented at 11:43 PM on March 6, 2026: member
-
55d37546fa
Bugfix: GUI/Intro: Handle errors from SelectParams the same as if during InitConfig
Without this, invalid vbparams just silently exit with no message
-
DrahtBot commented at 11:43 PM on March 6, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34767.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK sedited If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
davidgumberg commented at 11:18 PM on March 9, 2026: contributor
@luke-jr Can you give some guidance on how to reproduce the issue this fixes and/or a test case?
-
luke-jr commented at 11:21 PM on March 9, 2026: member
Just start bitcoin-qt with -regtest -vbparams and some out of range numbers
-
fanquake commented at 10:12 AM on March 12, 2026: member
Is this being moved to the GUI repo?
- fanquake added the label GUI on Mar 12, 2026
- sedited requested review from hebasto on Mar 20, 2026
- sedited approved
-
sedited commented at 12:37 PM on May 25, 2026: contributor
ACK 55d37546faa6b928d361e8b7ce9a90b49057d09a