Update libmultiprocess subtree to fix test timeout #34977

pull Sjors wants to merge 2 commits into bitcoin:master from Sjors:2026/04/libmultiprocess-subtree changing 4 files +17 −11
  1. Sjors commented at 8:31 am on April 1, 2026: member
  2. DrahtBot commented at 8:32 am on April 1, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ryanofsky, achow101

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  3. Sjors commented at 8:34 am on April 1, 2026: member
    @fanquake should I open a separate backport PR like we did for #34804 or can it just go into the normal backport flow? (assuming a slow CI test timeout is worth a backport, and/or we fix more things later)
  4. Sjors commented at 10:25 am on April 1, 2026: member
    No test timeout, but that’s not likely in a single CI run.
  5. achow101 added this to the milestone 31.0 on Apr 1, 2026
  6. achow101 commented at 1:49 am on April 4, 2026: member
    Upstream looks merged, is this ready for review?
  7. maflcko commented at 11:49 am on April 7, 2026: member
  8. Sjors force-pushed on Apr 7, 2026
  9. Sjors marked this as ready for review on Apr 7, 2026
  10. Sjors commented at 1:05 pm on April 7, 2026: member

    Updated after https://github.com/bitcoin-core/libmultiprocess/pull/266 landed.

    Marked ready for review, but if https://github.com/bitcoin-core/libmultiprocess/pull/268 is important, then I’ll just update this PR after it lands. I don’t think it’s relevant to v31.

  11. fanquake commented at 2:17 pm on April 7, 2026: member
  12. Squashed 'src/ipc/libmultiprocess/' changes from 70f632bda8..3edbe8f67c
    3edbe8f67c Merge bitcoin-core/libmultiprocess#268: Use throwRecoverableException instead of raw throw for stored exceptions
    23be44b0d3 Use throwRecoverableException instead of raw throw for stored exceptions
    75c2a2764c Merge bitcoin-core/libmultiprocess#266: test: increase spawn test child timeout to 30 seconds
    8b5f805301 Merge bitcoin-core/libmultiprocess#267: doc: Bump version 9 > 10
    cc0b23fc32 test: increase spawn test child timeout to 30 seconds
    050f878db8 doc: Improve versions.md descriptions and formatting
    c6a288a889 doc: Bump version 9 > 10
    
    git-subtree-dir: src/ipc/libmultiprocess
    git-subtree-split: 3edbe8f67c182dde91c0050065d79ae268722489
    7a6d210989
  13. Merge commit '7a6d210989af56a03d7efa79f1f3a90047bb88fe' into 2026/04/libmultiprocess-subtree 66b4e30ec8
  14. fanquake commented at 3:02 pm on April 7, 2026: member
    This could also be closed in favour of #35014, which already has #268 + a commit to drop the related workaround.
  15. Sjors commented at 3:03 pm on April 7, 2026: member
    Indeed, superseded by #35014.
  16. Sjors closed this on Apr 7, 2026

  17. fanquake removed this from the milestone 31.0 on Apr 7, 2026
  18. Sjors reopened this on Apr 7, 2026

  19. Sjors force-pushed on Apr 7, 2026
  20. DrahtBot added the label CI failed on Apr 7, 2026
  21. Sjors commented at 4:07 pm on April 7, 2026: member
    Reopened and updated to include https://github.com/bitcoin-core/libmultiprocess/pull/268, because the test commit added in #35014 seems to have a conflict with master, causing CI to not run. It may be easier to just merge the subtree update first.
  22. DrahtBot removed the label CI failed on Apr 7, 2026
  23. ryanofsky approved
  24. ryanofsky commented at 8:14 pm on April 7, 2026: contributor
    Code review ACK 66b4e30ec8000514b3c0a65fb5085cb6338ebda7. Reviewed changes and verified subtree matches. Since this branch is based on 613a548648880314e78c3045d0ded12e29a4f036 it can be merged into both 31.x and master branches (if another PR is opened for 31.x).
  25. achow101 added this to the milestone 31.0 on Apr 7, 2026
  26. achow101 commented at 8:23 pm on April 7, 2026: member

    ACK 66b4e30ec8000514b3c0a65fb5085cb6338ebda7

    Going to merge this so that the author of #35014 doesn’t need to figure out subtree updating

  27. achow101 merged this on Apr 7, 2026
  28. achow101 closed this on Apr 7, 2026

  29. achow101 added the label Needs Backport (31.x) on Apr 7, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-08 00:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me