test: remove macOS REDUCE_EXPORTS exception workaround #35014

1. 
   alfonsoromanz commented at 4:56 PM on April 6, 2026: contributor

   Fixes #34723. The underlying fix was merged in #34977 (subtree update from bitcoin-core/libmultiprocess#268). This PR removes the test workaround that accepted the degraded unknown non-KJ exception of type: kj::Exception
   error message on Darwin. Tested: interface_ipc_mining.py passes on macOS (arm64) with REDUCE_EXPORTS=ON.

2. 
   DrahtBot commented at 4:56 PM on April 6, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101, ryanofsky, w0xlt

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

3. DrahtBot added the label CI failed on Apr 6, 2026
4. alfonsoromanz force-pushed on Apr 6, 2026
5. alfonsoromanz marked this as a draft on Apr 7, 2026
6. 
   alfonsoromanz commented at 12:38 AM on April 7, 2026: contributor

   Marking as draft. The type-context.h change needs to go through libmultiprocess upstream first (bitcoin-core/libmultiprocess#268). Once that's merged, I'll update this PR with a subtree merge + the test cleanup.

7. 
   Sjors commented at 1:09 PM on April 7, 2026: member

   I you want fully green CI, you could do a subtree update as the first commit. Though the fact that the other CI jobs pass should be enough to allow review of https://github.com/bitcoin-core/libmultiprocess/pull/268.

8. ryanofsky referenced this in commit 3edbe8f67c on Apr 7, 2026
9. alfonsoromanz force-pushed on Apr 7, 2026
10. 
    Sjors commented at 3:04 PM on April 7, 2026: member

    I closed #34977 in favor of this PR, since you now include both the subtree update and a test for one of the updates.

11. fanquake added this to the milestone 31.0 on Apr 7, 2026
12. alfonsoromanz marked this as ready for review on Apr 7, 2026
13. 
    alfonsoromanz commented at 3:20 PM on April 7, 2026: contributor

    Reopened with a subtree merge from bitcoin-core/libmultiprocess#268 + the test workaround removal.

14. 
    Sjors commented at 3:27 PM on April 7, 2026: member

    One little gotcha is that (when possible) subtree updates need to be based on the commit of the last update. So you'll want to rebase this branch back onto 613a548648880314e78c3045d0ded12e29a4f036.

    Alternatively you can start from my branch )2026/04/libmultiprocess-subtree and cherry-pick your test commit on it.

15. DrahtBot removed the label CI failed on Apr 7, 2026
16. alfonsoromanz force-pushed on Apr 7, 2026
17. 
    Sjors commented at 4:00 PM on April 7, 2026: member

    Mmm, CI is not running, maybe the test commit interacts with something on master?

18. alfonsoromanz force-pushed on Apr 7, 2026
19. 
    Sjors commented at 4:08 PM on April 7, 2026: member

    I reopened #34977 just in case.

20. DrahtBot added the label CI failed on Apr 7, 2026
21. 
    achow101 commented at 6:02 PM on April 7, 2026: member

    Subtree linter is failing

22. alfonsoromanz force-pushed on Apr 7, 2026
23. 
    alfonsoromanz commented at 6:59 PM on April 7, 2026: contributor

    Rebased onto Sjors's branch as suggested. GitHub shows conflicts since the branch isn't on master tip, which seems to be preventing CI from running. Previously when I rebased onto master to resolve the conflicts, the subtree lint failed. How should I proceed?

24. 
    achow101 commented at 7:19 PM on April 7, 2026: member

    Rebasing with subtree update is kind of annoying to do. Easiest is to just redo the subtree commit, see https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees. Redoing it should resolve the linter issue, and you can base on top of master to avoid conflicts.

    The previous push was missing the merge commit which meant that the subtree was not being included properly.

25. alfonsoromanz force-pushed on Apr 7, 2026
26. 
    achow101 commented at 8:34 PM on April 7, 2026: member

    Ah, a second too late. Merged #34977 so you only need to rebase to master.

27. test: remove macOS REDUCE_EXPORTS exception workaround

    The underlying issue was fixed in bitcoin-core/libmultiprocess#268.
    
    Remove the workaround that accepted degraded error messages on Darwin.

    b555a0b789
28. alfonsoromanz force-pushed on Apr 7, 2026
29. alfonsoromanz renamed this:
    ipc: fix exception type visibility with REDUCE_EXPORTS on macOS
    test: remove macOS REDUCE_EXPORTS exception workaround
    on Apr 7, 2026
30. DrahtBot renamed this:
    test: remove macOS REDUCE_EXPORTS exception workaround
    test: remove macOS REDUCE_EXPORTS exception workaround
    on Apr 7, 2026
31. 
    achow101 commented at 9:09 PM on April 7, 2026: member

    ACK b555a0b789fa4f21875e4fa356cd9455aef16879

32. DrahtBot removed the label CI failed on Apr 7, 2026
33. DrahtBot added the label Tests on Apr 7, 2026
34. ryanofsky approved
35. 
    ryanofsky commented at 9:37 PM on April 7, 2026: contributor

    Code review ACK b555a0b789fa4f21875e4fa356cd9455aef16879. Thanks for the fixes!

36. 
    w0xlt commented at 10:42 PM on April 7, 2026: contributor

    ACK b555a0b789fa4f21875e4fa356cd9455aef16879

    This works for the default bundled libmultiprocess build.

37. achow101 merged this on Apr 7, 2026
38. achow101 closed this on Apr 7, 2026

    ---

39. achow101 added the label Needs Backport (31.x) on Apr 7, 2026
40. fanquake referenced this in commit afa8ba04e0 on Apr 8, 2026
41. fanquake removed the label Needs Backport (31.x) on Apr 8, 2026
42. 
    fanquake commented at 3:34 AM on April 8, 2026: member

    Backported to 31.x in #35028.

Contributors

alfonsoromanzDrahtBotSjorsachow101ryanofskyw0xltfanquake

Milestone
31.0